From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9702CD8CB2 for ; Wed, 10 Jun 2026 15:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FB6Xtdl2V5ioScxNLgD1NRtPPkTcVrQQXdi7K20csa0=; b=1ySCxx3MzA/onPPJJNlOyUSLAv mpatYPO86a1Vc4kc+VfdzhEE3n/M2WriK0ub+KFKWQtZYLOi2Rn2Hogsg3uTjF14dfIYFcHugUjuJ unb2/Mo66+WBUXdcQyrjm5r/09/tqKCfA0wRIKYPWIOeRYdAP+yo1+Kne9tzA6sHsVULE432JFBB8 NI/KTxXpB65x1ljdQJlCsvIwVId6I/MIrnV3GNMOBEO3erYs+V/LmdQP08FQHCeltkj5j2CIPx9Bq irOaFNc+jA1Dr/0FMkihCRUwtCM/v8pOhrWbDglhBVjeg3APdSAQbKW3CsTr8MbVuvNZ2P3IJK93X 4zZjMhQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXL8c-000000083dk-3hCm; Wed, 10 Jun 2026 15:46:42 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXL8c-000000083dV-0Lgi; Wed, 10 Jun 2026 15:46:42 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 339B460172; Wed, 10 Jun 2026 15:46:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC2411F00893; Wed, 10 Jun 2026 15:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781106400; bh=KfdWJVUy1kU0Nhcuk2I/MmIfNfdAKh+0EByci0W5Szg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=flSmuyQVfR6Qzzj4264uL/3WKO4fpcjjZ4Jpe9LCYf8w3yyzBkv8J82QVqjrkmzVT f3l9nEUh+vtSycuEhKgKkyJbWjprL/xSDxyAFXi6dOjZfQ0rcmCcqRFBm2BgjCSU21 txjRwsPP3m5KjRCREpBfcg+aHnfP7JKdtnE3YdXLBfg1oC117BM6h+1l4eBsdCO2RV JLA/NvN/HDKG9Kq6SdG9LDOVGP3RRZ4W7tN2KyW6lAf4sQWIIzKpXPsQywVQjX/X7V 9ie4s2b02YYvDDh0WtIhos8Dror3uQHv1HNL0PZ2xdXYrduO2nJ4MSmPBzBybB56Ec DmWapuh2XIRzA== Received: by finisterre.sirena.org.uk (Postfix, from userid 1000) id 5CE5E1AC56C5; Wed, 10 Jun 2026 16:46:38 +0100 (BST) Date: Wed, 10 Jun 2026 16:46:38 +0100 From: Mark Brown To: Jerome Brunet Cc: phucduc.bui@gmail.com, Liam Girdwood , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: meson: axg-tdm-formatter: Use guard() for mutex locks Message-ID: References: <20260610102153.83367-1-phucduc.bui@gmail.com> <1j8q8mfte7.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 In-Reply-To: <1j8q8mfte7.fsf@starbuckisacylon.baylibre.com> X-Cookie: Leave no stone unturned. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4423334776288598612==" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org --===============4423334776288598612== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PxyZ8U/rEKlTlGqo" Content-Disposition: inline --PxyZ8U/rEKlTlGqo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 10, 2026 at 02:54:08PM +0200, Jerome Brunet wrote: > On mer. 10 juin 2026 at 17:21, phucduc.bui@gmail.com wrote: > > Clean up the code using guard() for mutex locks. > > Merely code refactoring, and no behavior change. > I suppose it is OK but it does not seem to really clean anything and > make the code easier to follow in that instance, from my perspective at > least. > If there is policy to systematically use guard() whenever > possible then OK, otherwise it seems unnecessary. I don't know about policy but there's definitely people who are keen on converting things to this pattern. --PxyZ8U/rEKlTlGqo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmopht0ACgkQJNaLcl1U h9CzRwgAgDswQDXFyzP5z4rETNyEf3MQAZYJYQ3LTNsRsjBW0i3YBsbEwiJoeDF5 jfTgd6UguAKKbHKzgkWe6qbYY2bUjMVI3xANcR4Uyd6SbyS92RpWyDH729+mDbLK bP3l4yAWtiGfSsDqDASxflSVpkWJmSFcImDX9QxoEc8L94Xynh4V6Ju3g4U5mo1t Z1sZmpt5uktyvYaTqt8KISlILUGBNzd3XGsmCZYLD+BhPprmyuPKpvDLPho+zXkP +Uop8nWZpZGNNo2iJN5szX8ZEO3XVKsaXLcsbc4PeKNhqf02cu2S5aZm1N9az+Rq 1L7IGgsO7TnmOy1C6O6pK/6Hd9d31Q== =eN3r -----END PGP SIGNATURE----- --PxyZ8U/rEKlTlGqo-- --===============4423334776288598612== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic --===============4423334776288598612==--