Re: [PATCH v5 2/3] nvmem: core: deprecate reg_write callback with reg_write_const

From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Srinivas Kandagatla <srini@kernel.org>
Cc: "Link Mauve" <linkmauve@linkmauve.fr>,
	"Sasha Finkelstein" <k@chaosmail.tech>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Jerome Brunet" <jbrunet@baylibre.com>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"Sven Peter" <sven@kernel.org>, "Janne Grunau" <j@jannau.net>,
	"Neal Gompa" <neal@gompa.dev>, "Frank Li" <Frank.Li@nxp.com>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Vladimir Zapolskiy" <vz@mleia.com>,
	"André Draszik" <andre.draszik@linaro.org>,
	"Orson Zhai" <orsonzhai@gmail.com>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Chunyan Zhang" <zhang.lyra@gmail.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Kalyani Akula" <kalyani.akula@amd.com>,
	"Michal Simek" <michal.simek@amd.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Tamir Duberstein" <tamird@kernel.org>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	"Onur Özkan" <work@onurozkan.dev>,
	"Johan Hovold" <johan@kernel.org>,
	"Ronald Claveau" <linux-kernel-dev@aliel.fr>,
	"Daniel Lezcano" <daniel.lezcano@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	asahi@lists.linux.dev, imx@lists.linux.dev,
	linux-arm-msm@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v5 2/3] nvmem: core: deprecate reg_write callback with reg_write_const
Date: Tue, 15 Sep 2026 10:15:36 +0300	[thread overview]
Message-ID: <aqjwmMn7GkAoxsu2@ashevche-desk.local> (raw)
In-Reply-To: <a1488d9d-3014-44ea-a0d7-6ab99fedccc9@kernel.org>

On Mon, Sep 14, 2026 at 10:48:21PM +0100, Srinivas Kandagatla wrote:
> On 8/4/26 2:59 PM, Link Mauve wrote:

...

> > - * @reg_write:	Callback to write data; return zero if successful.
> > + * @reg_write:	**DEPRECATED** - please use reg_write_const instead.
> 
> Marking here as deprecated is total waste as no one will read it,

This is still okay as we have many such things in the kernel (during the time).

> May be move this message to the core while registering.

No objections here.

...

> >  	nvmem_reg_read_t	reg_read;
> >  	nvmem_reg_write_t	reg_write;
> 
> flag this with compile time __deprecated flag.

__deprecated is DEPRECATED :-)
No new code should use it.

include/linux/compiler_attributes.h:110: * Don't. Just don't. See commit 771c035372a0 ("deprecate the '__deprecated'

> > +	nvmem_reg_write_const_t	reg_write_const;

-- 
With Best Regards,
Andy Shevchenko

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic