From: Frank Li <Frank.li@oss.nxp.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: "Bjorn Andersson" <andersson@kernel.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Brian Masney" <bmasney+clk@redhat.com>,
"Jerome Brunet" <jbrunet+clk@baylibre.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Rob Clark" <robin.clark@oss.qualcomm.com>,
"Dmitry Baryshkov" <lumag@kernel.org>,
"Abhinav Kumar" <abhinav.kumar@linux.dev>,
"Jessica Zhang" <jesszhan0024@gmail.com>,
"Sean Paul" <sean@poorly.run>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
"Frank Li" <Frank.Li@nxp.com>, "Vinod Koul" <vkoul@kernel.org>,
"Yinbo Zhu" <zhuyinbo@loongson.cn>,
"Linus Walleij" <linusw@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Tiffany Lin" <tiffany.lin@mediatek.com>,
"Andrew-CT Chen" <andrew-ct.chen@mediatek.com>,
"Yunfei Dong" <yunfei.dong@mediatek.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Ryder Lee" <ryder.lee@mediatek.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"Eric Anholt" <eric@anholt.net>,
"Kuogee Hsieh" <quic_khsieh@quicinc.com>,
"Peng Fan" <peng.fan@nxp.com>,
"Aakarsh Jain" <aakarsh.jain@samsung.com>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
freedreno@lists.freedesktop.org, imx@lists.linux.dev,
dmaengine@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-iio@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-media@vger.kernel.org, linux-pci@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: Fix property name typos in if/then schemas
Date: Wed, 28 Oct 2026 09:26:13 -0500 [thread overview]
Message-ID: <auIGBc2Wo21H6Rdm@SMW015318> (raw)
In-Reply-To: <20261028120216.2657397-1-robh@kernel.org>
On Wed, Oct 28, 2026 at 07:02:12AM -0500, Rob Herring (Arm) wrote:
> Property names within if/then schemas currently go unchecked whether
> they have a type defined or match what's in the top-level schema. Adding
> a check finds a number of instances of typos. The typos result in the
> schema having no effect on constraints.
>
> With this, fix the mediatek,vcodec-encoder 'clocks' count constraint
> exposed by the name correction.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../devicetree/bindings/clock/qcom,kpss-gcc.yaml | 2 +-
> .../bindings/display/brcm,bcm2711-hdmi.yaml | 2 +-
> .../bindings/display/msm/dp-controller.yaml | 2 +-
> .../devicetree/bindings/display/msm/hdmi.yaml | 4 ++--
> Documentation/devicetree/bindings/dma/fsl,edma.yaml | 2 +-
> .../devicetree/bindings/gpio/loongson,ls-gpio.yaml | 2 +-
> .../bindings/iio/adc/amlogic,meson-saradc.yaml | 2 +-
> .../bindings/media/mediatek,vcodec-encoder.yaml | 12 ++++--------
> .../devicetree/bindings/media/samsung,s5p-mfc.yaml | 2 +-
> .../devicetree/bindings/pci/mediatek-pcie.yaml | 12 ++++++------
> 10 files changed, 19 insertions(+), 23 deletions(-)
Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,kpss-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,kpss-gcc.yaml
> index 88b7672123a0..ed347096df46 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,kpss-gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,kpss-gcc.yaml
> @@ -62,7 +62,7 @@ then:
> - '#clock-cells'
> else:
> properties:
> - clock: false
> + clocks: false
> clock-names: false
> '#clock-cells': false
>
> diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> index c1cefd547391..fd4d598f6ff8 100644
> --- a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> @@ -145,7 +145,7 @@ allOf:
> - description: CEC stuck at low interrupt
> - description: Hotplug connected interrupt
> - description: Hotplug removed interrupt
> - interrupts-names:
> + interrupt-names:
> items:
> - const: cec-tx
> - const: cec-rx
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index 094a6383bb77..f72d1b354007 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -304,7 +304,7 @@ allOf:
> clocks:
> minItems: 6
> maxItems: 6
> - clocks-names:
> + clock-names:
> minItems: 6
> maxItems: 6
>
> diff --git a/Documentation/devicetree/bindings/display/msm/hdmi.yaml b/Documentation/devicetree/bindings/display/msm/hdmi.yaml
> index dfec6c3480f3..02d27ccad024 100644
> --- a/Documentation/devicetree/bindings/display/msm/hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/hdmi.yaml
> @@ -113,7 +113,7 @@ allOf:
> - const: core
> - const: master_iface
> - const: slave_iface
> - core-vcc-supplies: false
> + core-vcc-supply: false
>
> - if:
> properties:
> @@ -136,7 +136,7 @@ allOf:
> - const: core
> - const: alt_iface
> - const: extp
> - hdmi-mux-supplies: false
> + hdmi-mux-supply: false
>
> - if:
> properties:
> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> index f609038e35ae..0260d177c7d0 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> @@ -172,7 +172,7 @@ allOf:
> const: fsl,imx7ulp-edma
> then:
> properties:
> - clock:
> + clocks:
> minItems: 2
> maxItems: 2
> clock-names:
> diff --git a/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml b/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
> index 69852444df23..07c8b233c6bd 100644
> --- a/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/loongson,ls-gpio.yaml
> @@ -80,7 +80,7 @@ allOf:
> - resets
> else:
> properties:
> - "#interrupts-cells": false
> + "#interrupt-cells": false
> interrupt-controller: false
> resets: false
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml
> index 70ab4e140e71..535213ba0c5e 100644
> --- a/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml
> @@ -92,7 +92,7 @@ allOf:
> else:
> properties:
> nvmem-cells: false
> - mvmem-cel-names: false
> + nvmem-cell-names: false
> clocks:
> minItems: 4
> clock-names:
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> index 4505e66876a2..52f471a070d5 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> @@ -110,19 +110,15 @@ allOf:
>
> then:
> properties:
> - clock:
> - items:
> - minItems: 1
> - maxItems: 1
> + clocks:
> + maxItems: 1
> clock-names:
> items:
> - const: venc_lt_sel
> else:
> properties:
> - clock:
> - items:
> - minItems: 1
> - maxItems: 1
> + clocks:
> + maxItems: 1
> clock-names:
> items:
> - const: venc_sel
> diff --git a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> index b46cc780703c..4488d5ca9b9c 100644
> --- a/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> +++ b/Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml
> @@ -174,7 +174,7 @@ allOf:
> - const: mfc
> iommus:
> maxItems: 2
> - iommus-names: false
> + iommu-names: false
>
> examples:
> - |
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml
> index c009a7a52bc6..7c40361f95ec 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie.yaml
> @@ -127,7 +127,7 @@ allOf:
> phy-names:
> const: pcie-phy1
>
> - power-domain: false
> + power-domains: false
>
> required:
> - resets
> @@ -150,7 +150,7 @@ allOf:
> minItems: 2
> maxItems: 2
>
> - reset: false
> + resets: false
>
> reset-names: false
>
> @@ -171,7 +171,7 @@ allOf:
> clocks:
> minItems: 6
>
> - reset: false
> + resets: false
>
> reset-names: false
>
> @@ -193,7 +193,7 @@ allOf:
> clocks:
> minItems: 6
>
> - reset: false
> + resets: false
>
> reset-names: false
>
> @@ -215,7 +215,7 @@ allOf:
> clock-names:
> maxItems: 1
>
> - reset: false
> + resets: false
>
> reset-names: false
>
> @@ -223,7 +223,7 @@ allOf:
>
> phy-names: false
>
> - power-domain: false
> + power-domains: false
>
> mediatek,pbus-csr: false
>
> --
> 2.53.0
>
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-10-28 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 12:02 Rob Herring (Arm)
2026-10-28 14:26 ` Frank Li [this message]
2026-10-28 14:57 ` Bartosz Golaszewski
2026-10-28 16:50 ` Christian Marangi
2026-10-28 23:46 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auIGBc2Wo21H6Rdm@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=aakarsh.jain@samsung.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=andrzej.hajda@intel.com \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=bmasney+clk@redhat.com \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=florian.fainelli@broadcom.com \
--cc=freedreno@lists.freedesktop.org \
--cc=imx@lists.linux.dev \
--cc=jbrunet+clk@baylibre.com \
--cc=jesszhan0024@gmail.com \
--cc=jic23@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=lumag@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mani@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nuno.sa@analog.com \
--cc=peng.fan@nxp.com \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=ryder.lee@mediatek.com \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tiffany.lin@mediatek.com \
--cc=tzimmermann@suse.de \
--cc=vkoul@kernel.org \
--cc=yunfei.dong@mediatek.com \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®