From mboxrd@z Thu Jan 1 00:00:00 1970 From: narmstrong@baylibre.com (Neil Armstrong) Date: Mon, 5 Sep 2016 10:00:21 +0200 Subject: [PATCH 5/7] ARM64: meson-gxbb: add USB Nodes In-Reply-To: References: <20160904213152.25837-1-martin.blumenstingl@googlemail.com> <20160904213152.25837-6-martin.blumenstingl@googlemail.com> Message-ID: To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On 09/05/2016 02:23 AM, Andreas F?rber wrote: > Hi Martin, > > Am 04.09.2016 um 23:31 schrieb Martin Blumenstingl: >> Add the nodes for the dwc2 USB controller and the related USB PHYs. >> Currently we force usb0 to host mode because OTG is currently not >> working in our PHY driver. >> >> Signed-off-by: Jerome Brunet >> Signed-off-by: Martin Blumenstingl >> --- >> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 52 +++++++++++++++++++++++++++++ >> 1 file changed, 52 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >> index 2e8a3d9..02dfc54 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >> @@ -151,6 +151,34 @@ >> #size-cells = <2>; >> ranges; >> >> + usb-phys at c0000000 { >> + compatible = "simple-bus"; >> + reg = <0x0 0xc0000000 0x0 0x40>; >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges = <0x0 0x0 0x0 0xc0000000 0x0 0x40>; > > Does this correspond to any physical bus or could we drop this layer? > >> + >> + usb0_phy: usb_phy at 0 { > > phy at 0 to avoid the underscore in node name? dash otherwise. > If dropping the bus, *phy at c0000000 obviously. > >> + compatible = "amlogic,meson-gxbb-usb2-phy"; >> + #phy-cells = <0>; >> + reg = <0x0 0x0 0x0 0x20>; >> + resets = <&reset 34>; >> + clocks = <&clkc CLKID_USB &clkc CLKID_USB0>; > > <&clkc CLKID_USB>, <&clkc CLKID_USB0> please. > >> + clock-names = "usb_general", "usb"; >> + status = "disabled"; >> + }; >> + >> + usb1_phy: usb_phy at 20 { >> + compatible = "amlogic,meson-gxbb-usb2-phy"; >> + #phy-cells = <0>; >> + reg = <0x0 0x20 0x0 0x20>; >> + resets = <&reset 34>; >> + clocks = <&clkc CLKID_USB &clkc CLKID_USB1>; > > Ditto > >> + clock-names = "usb_general", "usb"; >> + status = "disabled"; >> + }; >> + }; >> + >> cbus: cbus at c1100000 { >> compatible = "simple-bus"; >> reg = <0x0 0xc1100000 0x0 0x100000>; >> @@ -496,6 +524,30 @@ >> }; >> }; >> >> + usb0: usb-controller at c9000000 { > > usb at c9000000 by convention. > >> + compatible = "amlogic,meson-gxbb-usb", "snps,dwc2"; >> + reg = <0x0 0xc9000000 0x0 0x40000>; >> + interrupts = ; >> + clocks = <&clkc CLKID_USB0_DDR_BRIDGE>; >> + clock-names = "otg"; >> + phys = <&usb0_phy>; >> + phy-names = "usb2-phy"; >> + dr_mode = "host"; >> + status = "disabled"; >> + }; >> + >> + usb1: usb-controller at c9100000 { > > usb at c9100000 > >> + compatible = "amlogic,meson-gxbb-usb", "snps,dwc2"; >> + reg = <0x0 0xc9100000 0x0 0x40000>; >> + interrupts = ; >> + clocks = <&clkc CLKID_USB1_DDR_BRIDGE>; >> + clock-names = "otg"; >> + phys = <&usb1_phy>; >> + phy-names = "usb2-phy"; >> + dr_mode = "host"; >> + status = "disabled"; >> + }; >> + >> ethmac: ethernet at c9410000 { >> compatible = "amlogic,meson-gxbb-dwmac", "snps,dwmac"; >> reg = <0x0 0xc9410000 0x0 0x10000 > > Thanks for the huge progress you guys have been making. > > This patchset will probably clash with Neil's GXL preparations? My GXL patch can wait USB ;-) > > Regards, > Andreas > Thanks, Neil