From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E6C9C04EB9 for ; Sat, 1 Dec 2018 15:31:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 649BE2081D for ; Sat, 1 Dec 2018 15:31:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C47D7KcB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="ITw8dhDM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 649BE2081D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ObvTp132LoyoksPCHfxcCRk12q7MA/TkO8eDwgZmivg=; b=C47D7KcBFCUvBs DWWtoiT//kcX8ulj0oUgHX7JOXNzVbqp+2hofEzgjUeAjVzKYJXKxXFZGEf4Hs8WPYZB2ulqLPeTI vFLdkX0iMMCUcw0Yey2/6AaxlIiv7CjSKrLZk8zwYZzuhW6Lpdn7dymfMqN5a+/NaX92FTdaURd4M /aF+2YmJHipCeo0y+qNySLPCz1RKC+hsjE2kMOetTqZeR3QuxORWJIvVRTa5WcC/BejuXFKwKPc5b wr1GhRrYvWo4TGchD+Bkia1Ij6dH3q/Z1echG6T5vDql1pY5oVbnDHZNZ7gyduOrqoWC1zRpQOZtR t+bOQCIr0hU7MdKEWx9w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gT7Eo-0007ZP-Aa; Sat, 01 Dec 2018 15:31:22 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gT7Ek-0007Yc-83 for linux-amlogic@lists.infradead.org; Sat, 01 Dec 2018 15:31:20 +0000 Received: by mail-wm1-x342.google.com with SMTP id 125so1733598wmh.0 for ; Sat, 01 Dec 2018 07:31:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=dOfptwxehh2BOlowhmD9nkQSUoiLytGVrcCDN0HYOOM=; b=ITw8dhDMrfouRs6GR+si7FyYtqrVucZJ89XmfH4dTNTDZ6dRflCBnopc1Sm3Fl5hIx zp3BVYzeQ/6/sXpJJKPSzDACeOdTQu4EPqJOXUpNEXASySCqYwckJTLRXm6BAJquoB0M kljkMkC2UBch4GnRCDLFhcrY3UTbqOD2LhtsSF0MtzYJ+zXUUXCWVLk7BNtTzYBDtSjH ja99lAwEda2/5VBwKHWZI/8BZeLJkHHeKAOZUSu4jeCyWUZrHGaEkSi6boakMUcIZsGo K0P7ikAfVxcoQe//0wlmV6g+VMN2ojFLLMI4pp7cs0CI9cZmPXZ0ik2b61KkWqbi2MxW ngNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=dOfptwxehh2BOlowhmD9nkQSUoiLytGVrcCDN0HYOOM=; b=gIhixL8kZvSp6eG+x7VO/j6Z3ztpVOuYeHlfvHSiddwpNryNg+STcCEUbxSoD9CV+E 8rcOPYEamn7eQC3WRKFb1NfazJkjuR9xlhLaZ4yw8zWoFvCIEc16XI7EuTRHUSpJcbaL gj/EI/o7N2mO/hPrEULChGK45c32JQgDIz+vZv5Z2lvbKLAJuLetm+EASBgIzHhG94Fo aaXkxgicX44dM5YGo+7ZYftnBb/Qd8QGBYP4eVwhOjb6Tld69ZjYP/e0FVBGsJeJlcCv iCLrW15IFYy9P+LcerCKvNtHqPa1epvFc0A/gXmJGfmHUDniDJ+Y0FHmOODa9IVTA8tS LP+A== X-Gm-Message-State: AA+aEWadtZA9tlkjMlXmKrrkkIeFr7LVrYNQGciT69R61tgIhfIGRiHd 0lz2d6E1u3s4aCqJXBPNY96NNOOjzzEMLH35 X-Google-Smtp-Source: AFSGD/WQu4mPt9uK0fYXAEi4QB2eSLELDMgvXraGgspOKe1yANjqG/0u69cF47+MmfDAyd+9hsC7wg== X-Received: by 2002:a1c:9855:: with SMTP id a82mr2433058wme.20.1543678266540; Sat, 01 Dec 2018 07:31:06 -0800 (PST) Received: from xps ([104.207.76.73]) by smtp.gmail.com with ESMTPSA id x14sm5918692wrm.65.2018.12.01.07.31.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Dec 2018 07:31:05 -0800 (PST) Message-ID: Subject: Re: [PATCH] arm64: dts: meson-axg: Fix and enable GPIO interrupt controller From: Carlo Caione To: Martin Blumenstingl Date: Sat, 01 Dec 2018 15:31:04 +0000 In-Reply-To: References: <20181201145614.5381-1-ccaione@baylibre.com> User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181201_073118_293417_364CADE3 X-CRM114-Status: GOOD ( 19.39 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, khilman@baylibre.com, robh+dt@kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sat, 2018-12-01 at 16:20 +0100, Martin Blumenstingl wrote: > Hi Carlo, Hi Martin, > On Sat, Dec 1, 2018 at 3:56 PM Carlo Caione > wrote: > > The GPIO interrupt controller registers are mapped to the wrong > > offset in the DTSI. Fix the offset in the DTSI and enable the > > interrupt > > controller in the DTS of the only AXG board enabled. > > > > Signed-off-by: Carlo Caione > > --- > > arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 6 ++++++ > > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 2 +- > > 2 files changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts > > b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts > > index 18778ada7bd3..c3e4aac75782 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts > > @@ -374,6 +374,12 @@ > > status = "okay"; > > }; > > > > +&gpio_intc { > > + compatible = "amlogic,meson-gpio-intc", > > + "amlogic,meson-axg-gpio-intc"; > multiple compatible strings should be ordered: > - use the most specific compatible (the AXG one) first > - the the less specific ones mindlessly copied and pasted from the GXL. > also why did you add the AXG compatible string in the s400 board .dts > instead of meson-axg.dtsi (which makes it available for all AXG > boards)? good point. > > + status = "okay"; > > +}; > > + > > &ir { > > status = "okay"; > > pinctrl-0 = <&remote_input_ao_pins>; > > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > > b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > > index df017dbd2e57..f1affc12e3e6 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > > +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > > @@ -1415,7 +1415,7 @@ > > > > gpio_intc: interrupt-controller@f080 { > unit-address should match the reg property: ...@9880 > > > compatible = "amlogic,meson-gpio- > > intc"; > > - reg = <0x0 0xf080 0x0 0x10>; > > + reg = <0x0 0x9880 0x0 0x10>; > Amlogic's patched 4.9 buildroot kernel uses 0xf080 - can you add a > short sentence to the description on which board you have tested this > (I assume you used the s400) The datasheet reports a different offset. But I tested again on 0xf080 and it looks like 0xf080 is actually the correct one? Need to test this better. I'll follow this up with v2. Cheers, -- Carlo Caione _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic