mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: hkallweit1@gmail.com (Heiner Kallweit)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] mmc: meson-gx: work around broken SDIO with certain WiFi chips
Date: Thu, 8 Jun 2017 20:36:49 +0200	[thread overview]
Message-ID: <b1419988-65c9-270f-3b4f-21b56165adf0@gmail.com> (raw)
In-Reply-To: <CAPDyKFpoev_izy=C6=ZO_Bq=ABZG9LD=V_uvn1vKkQD4xd3hhA@mail.gmail.com>

Am 08.06.2017 um 08:56 schrieb Ulf Hansson:
> On 8 June 2017 at 07:56, Heiner Kallweit <hkallweit1@gmail.com> wrote:
>> There have been reports about SDIO failing with certain WiFi chips in
>> descriptor chain mode. SD / eMMC are working fine.
>>
>> So let's fall back to bounce buffer mode for command SD_IO_RW_EXTENDED.
>> This was reported to fix this error.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> Is this material for stable? What commit does it fix?
> 
> Please resend to linux-mmc.
> 
Sorry, will re-send with the missing information.

Rgds, Heiner


> Kind regards
> Uffe
> 
>> ---
>>  drivers/mmc/host/meson-gx-mmc.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
>> index 1842ed34..4cdbe3c0 100644
>> --- a/drivers/mmc/host/meson-gx-mmc.c
>> +++ b/drivers/mmc/host/meson-gx-mmc.c
>> @@ -210,6 +210,15 @@ static void meson_mmc_get_transfer_mode(struct mmc_host *mmc,
>>         int i;
>>         bool use_desc_chain_mode = true;
>>
>> +       /*
>> +        * Broken SDIO with AP6335-based WiFi on Khadas VIM Pro has been
>> +        * reported. For some strange reason this occurs in descriptor
>> +        * chain mode only. So let's fall back to bounce buffer mode
>> +        * for command SD_IO_RW_EXTENDED.
>> +        */
>> +       if (mrq->cmd->opcode == SD_IO_RW_EXTENDED)
>> +               return;
>> +
>>         for_each_sg(data->sg, sg, data->sg_len, i)
>>                 /* check for 8 byte alignment */
>>                 if (sg->offset & 7) {
>> --
>> 2.13.0
>>
> 

  reply	other threads:[~2017-06-08 18:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08  5:56 Heiner Kallweit
2017-06-08  6:56 ` Ulf Hansson
2017-06-08 18:36   ` Heiner Kallweit [this message]
2017-06-08 18:43 Heiner Kallweit
2017-06-09 22:06 ` Martin Blumenstingl
2017-06-10 11:34   ` Heiner Kallweit
2017-06-11 20:31     ` Martin Blumenstingl
2017-06-15 12:36       ` crow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1419988-65c9-270f-3b4f-21b56165adf0@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®