mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Jun Li <lijun.kernel@gmail.com>
Cc: Felipe Balbi <balbi@kernel.org>,
	Jianxin Pan <jianxin.pan@amlogic.com>,
	khilman@baylibre.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, Tim <elatllat@gmail.com>,
	Dongjin Kim <tobetter@gmail.com>,
	linux-amlogic@lists.infradead.org,
	Thinh Nguyen <thinhn@synopsys.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] usb: dwc3: gadget: Add support for disabling SS instances in park mode
Date: Fri, 21 Feb 2020 10:10:59 +0100	[thread overview]
Message-ID: <b2439923-5590-349e-754b-6b047d4becaf@baylibre.com> (raw)
In-Reply-To: <CAKgpwJXVo_Psyu45+KfRKsTRBc6LRWSvUw2CWdUQseAoKd2p9g@mail.gmail.com>

On 21/02/2020 02:59, Jun Li wrote:
> Neil Armstrong <narmstrong@baylibre.com> 于2020年2月19日周三 下午10:18写道：
>>
>> In certain circumstances, the XHCI SuperSpeed instance in park mode
>> can fail to recover, thus on Amlogic G12A/G12B/SM1 SoCs when there is high
>> load on the single XHCI SuperSpeed instance, the controller can crash like:
>>  xhci-hcd xhci-hcd.0.auto: xHCI host not responding to stop endpoint command.
>>  xhci-hcd xhci-hcd.0.auto: Host halt failed, -110
>>  xhci-hcd xhci-hcd.0.auto: xHCI host controller not responding, assume dead
>>  xhci-hcd xhci-hcd.0.auto: xHCI host not responding to stop endpoint command.
>>  hub 2-1.1:1.0: hub_ext_port_status failed (err = -22)
>>  xhci-hcd xhci-hcd.0.auto: HC died; cleaning up
>>  usb 2-1.1-port1: cannot reset (err = -22)
>>
>> Setting the PARKMODE_DISABLE_SS bit in the DWC3_USB3_GUCTL1 mitigates
>> the issue. The bit is described as :
>> "When this bit is set to '1' all SS bus instances in park mode are disabled"
>>
>> Synopsys explains in [1]:
>> The GUCTL1.PARKMODE_DISABLE_SS is only available in
>> dwc_usb3 controller running in host mode.
>> This should not be set for other IPs.
>> This can be disabled by default based on IP, but I recommend to have a
>> property to enable this feature for devices that need this.
>>
>> [1] https://lore.kernel.org/linux-usb/45212db9-e366-2669-5c0a-3c5bd06287f6@synopsys.com
> 
> This is not for gadget, patch title should be:
> 
> usb: dwc3: core: add support...
> 
> Li Jun
> 

Indeed... time for a v4.

Thanks,

Neil

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2020-02-21  9:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19 14:18 [PATCH v3 0/3] usb: dwc3: parkmode_disable_ss_quirk on DWC3 controller Neil Armstrong
2020-02-19 14:18 ` [PATCH v3 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode Neil Armstrong
2020-02-19 14:18 ` [PATCH v3 2/3] usb: dwc3: gadget: Add support " Neil Armstrong
2020-02-21  1:59   ` Jun Li
2020-02-21  9:10     ` Neil Armstrong [this message]
2020-02-19 14:18 ` [PATCH v3 3/3] arm64: dts: g12-common: add parkmode_disable_ss_quirk on DWC3 controller Neil Armstrong
2020-02-21  9:11 ` [PATCH v3 0/3] usb: dwc3: " Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2439923-5590-349e-754b-6b047d4becaf@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=balbi@kernel.org \
    --cc=elatllat@gmail.com \
    --cc=jianxin.pan@amlogic.com \
    --cc=khilman@baylibre.com \
    --cc=lijun.kernel@gmail.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=thinhn@synopsys.com \
    --cc=tobetter@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®