From: Yu Tu <yu.tu@amlogic.com>
To: <linux-serial@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Jiri Slaby <jirislaby@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH] tty: serial: meson: Make the bit24 and bit [26, 27] of the UART_REG5 register writable
Date: Mon, 10 Jan 2022 16:55:05 +0800 [thread overview]
Message-ID: <b553aea7-cb78-830a-4a4c-51d2ee2a1850@amlogic.com> (raw)
In-Reply-To: <20220110082616.13474-3-yu.tu@amlogic.com>
Hi All,
I'm really sorry for sending the wrong specified file. Please ignore
the email. I will resend V4.
On 2022/1/10 16:26, Yu Tu wrote:
> The UART_REG5 register defaults to 0. The console port is set in
> ROMCODE. But other UART ports default to 0, so make bit24 and
> bit[26,27] writable so that the UART can choose a more
> appropriate clock.
>
> Signed-off-by: Yu Tu <yu.tu@amlogic.com>
> ---
> drivers/tty/serial/meson_uart.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 7c3f30cea68e..b0551750dff8 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -693,7 +693,7 @@ static int meson_uart_probe_clocks(struct uart_port *port)
> CLK_SET_RATE_NO_REPARENT,
> port->membase + AML_UART_REG5,
> 26, 2,
> - CLK_DIVIDER_READ_ONLY,
> + CLK_DIVIDER_ROUND_CLOSEST,
> xtal_div_table, NULL);
> if (IS_ERR(hw))
> return PTR_ERR(hw);
> @@ -719,7 +719,7 @@ static int meson_uart_probe_clocks(struct uart_port *port)
> CLK_SET_RATE_PARENT,
> port->membase + AML_UART_REG5,
> 24, 0x1,
> - CLK_MUX_READ_ONLY,
> + CLK_MUX_ROUND_CLOSEST,
> NULL, NULL);
> if (IS_ERR(hw))
> return PTR_ERR(hw);
>
> base-commit: 93a770b7e16772530196674ffc79bb13fa927dc6
> prerequisite-patch-id: 95191c926509964c8e9bf4128b8bbad8a277b84a
> prerequisite-patch-id: a2e4756ff85f0df0efe111d7e2cb51b8e26e226f
> prerequisite-patch-id: 4e4d909acabcb7533da20e2207207be73454a88c
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2022-01-10 9:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 8:26 [PATCH 1/2] dt-bindings: serial: meson: Drop compatible = amlogic, meson-gx-uart Yu Tu
2022-01-10 8:26 ` [PATCH] tty: serial: meson: Change request_irq to devm_request_irq and move devm_request_irq to meson_uart_probe() Yu Tu
2022-01-10 8:54 ` Yu Tu
2022-01-10 8:26 ` [PATCH] tty: serial: meson: Make the bit24 and bit [26, 27] of the UART_REG5 register writable Yu Tu
2022-01-10 8:55 ` Yu Tu [this message]
2022-01-10 8:26 ` [PATCH] tty: serial: meson: meson_uart_shutdown omit clear AML_UART_TX_EN bit Yu Tu
2022-01-10 8:55 ` Yu Tu
2022-01-10 8:26 ` [PATCH] tty: serial: meson: Request the register region in meson_uart_probe() Yu Tu
2022-01-10 8:55 ` Yu Tu
2022-01-10 8:26 ` [PATCH 1/2] tty: serial: meson: The UART baud rate calculation is described using the common clock code Yu Tu
2022-01-10 8:55 ` Yu Tu
2022-01-10 8:54 ` [PATCH 1/2] dt-bindings: serial: meson: Drop compatible = amlogic,meson-gx-uart Yu Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b553aea7-cb78-830a-4a4c-51d2ee2a1850@amlogic.com \
--to=yu.tu@amlogic.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbrunet@baylibre.com \
--cc=jirislaby@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®