From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77B91C43603 for ; Wed, 18 Dec 2019 08:00:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BF0A21D7D for ; Wed, 18 Dec 2019 08:00:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SXH/GiZU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BF0A21D7D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=itHu/L4HJQ4YfejIG6FOpJ6KXNk5ksYgJjd5Nugba2A=; b=SXH/GiZUnbjlqR+PbvI2mPF8D Parz2nZsy9XYG3Nq8m0RJIdTV2TBjsP8Zjg0dJLEEL7RvLP6YoQyFbDO2Tcs2VIJQXHqTu8eRePYx uMbRU40s5NgG9WTcXILQTHYJuil2stTHe2EHclZ/pggiBk81bK8r3jqDHwF/Kao/3wTxL7Hjn3J/5 FiQXnxchFcn4jEOtTRXKSYoqt5hcOn1hz27lsia1nLYaA7WjZw0md91jCWHzKRZqy36o54dwc5Hra 7NFtm9kmRdZNW0Z8QMrahH6uYwV46tEtOs1H9eJlX1XLxJhhQCN2pP5X9dRjK98L2Jw5DWP1HC9d1 c3K4PN8cg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihUFj-0004FQ-Hd; Wed, 18 Dec 2019 08:00:15 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihUFb-0004BZ-0R; Wed, 18 Dec 2019 08:00:11 +0000 Received: from [10.28.39.99] (10.28.39.99) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Wed, 18 Dec 2019 16:00:21 +0800 Subject: Re: [PATCH v4 1/6] dt-bindings: clock: meson: add A1 PLL clock controller bindings To: Maxime Ripard References: <20191206074052.15557-1-jian.hu@amlogic.com> <20191206074052.15557-2-jian.hu@amlogic.com> <20191213103856.qo7vlnuk4ajz3vq5@gilmour.lan> From: Jian Hu Message-ID: Date: Wed, 18 Dec 2019 16:00:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20191213103856.qo7vlnuk4ajz3vq5@gilmour.lan> Content-Language: en-US X-Originating-IP: [10.28.39.99] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191218_000007_534757_18CD22DE X-CRM114-Status: GOOD ( 18.71 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Victor Wan , Jianxin Pan , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Michael Turquette , linux-kernel@vger.kernel.org, Stephen Boyd , devicetree@vger.kernel.org, Qiufang Dai , Chandle Zou , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Maxime Thanks for your review On 2019/12/13 18:38, Maxime Ripard wrote: > Hi, > > On Fri, Dec 06, 2019 at 03:40:47PM +0800, Jian Hu wrote: >> Add the documentation to support Amlogic A1 PLL clock driver, >> and add A1 PLL clock controller bindings. >> >> Signed-off-by: Jian Hu >> --- >> .../bindings/clock/amlogic,a1-pll-clkc.yaml | 59 +++++++++++++++++++ >> include/dt-bindings/clock/a1-pll-clkc.h | 16 +++++ >> 2 files changed, 75 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml >> create mode 100644 include/dt-bindings/clock/a1-pll-clkc.h >> >> diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml >> new file mode 100644 >> index 000000000000..7feeef5abf1b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml >> @@ -0,0 +1,59 @@ >> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ >> +/* >> + * Copyright (c) 2019 Amlogic, Inc. All rights reserved. >> + */ >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/clock/amlogic,a1-pll-clkc.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: Amlogic Meson A/C serials PLL Clock Control Unit Device Tree Bindings >> + >> +maintainers: >> + - Neil Armstrong >> + - Jerome Brunet >> + - Jian Hu >> + >> +properties: >> + compatible: >> + - enum: >> + - amlogic,a1-pll-clkc > > I'm not sure this works, compatible shouldn't contain a list. > I refered to Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml. I have used 'dt-doc-validate' tools to check, it will report something wrong below. properties:compatible: [{'enum': ['amlogic,a1-pll-clkc']}] is not of type 'object', 'boolean' Refer to https://github.com/robherring/dt-schema/blob/master/example-schema.yaml I will change it like this: properties: compatible: oneOf: - enum: - amlogic,a1-pll-clkc And It has been passed by 'dt-doc-validate' tools. Is it right? > You can write this like: > compatible: > const: amlogic,a1-pll-clkc > >> + "#clock-cells": >> + const: 1 >> + >> + reg: >> + maxItems: 1 >> + >> +clocks: >> + minItems: 2 >> + maxItems: 2 > > This is redundant, it will be added automatically by the tools ... If I remove the minItems, it will pass by dt-doc-validate. Would please tell how to use dt-schema to generate automatically it? > >> + items: >> + - description: Input xtal_fixpll >> + - description: Input xtal_hifipll > > ... When you have a list of items :) > >> + >> +clock-names: >> + minItems: 2 >> + maxItems: 2 >> + items: >> + - const: xtal_fixpll >> + - const: xtal_hifipll > > Same story here OK, I will change it when I find the right way. > > Maxime > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic