mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: jbrunet@baylibre.com (jbrunet at baylibre.com)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 3/3] ARM64: dts: meson-gxl: Add support for the Smartlabs SML-5442TW
Date: Thu, 08 Nov 2018 16:56:40 +0100	[thread overview]
Message-ID: <bafa32609200e57d8efe9843247429a46916bbef.camel@baylibre.com> (raw)
In-Reply-To: <1541691207-24768-3-git-send-email-christianshewitt@gmail.com>

On Thu, 2018-11-08 at 19:33 +0400, Christian Hewitt wrote:
> 
> +&audio {
> +	status = "okay";
> +};
> +
> +&aiu_i2s_dma {
> +	status = "okay";
> +};
> +
> +&i2s_dai {
> +	status = "okay";
> +};

The audio stuff has not made it's way upstream (yet) please drop this

> +
> +&cvbs_vdac_port {
> +	cvbs_vdac_out: endpoint {
> +		remote-endpoint = <&cvbs_connector_in>;
> +	};
> +};
> +
> 
[ ... ]

> +
> +/* This is connected to the Bluetooth module: */
> +&uart_A {
> +	status = "okay";
> +	pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>;
> +	pinctrl-names = "default";

Did you forget to put 'uart-has-rtscts;' here ?

> +};
> +
> +/* This UART is brought out to the debug header */
> +&uart_AO {
> +	status = "okay";
> +	pinctrl-0 = <&uart_ao_a_pins>;
> +	pinctrl-names = "default";
> +};
> +
> +&usb0 {
> +	status = "okay";
> +};

Also, you sent a multipatch series. Such patchset should start with a cover
letter describing the general intent ... even if it is obvious.

  reply	other threads:[~2018-11-08 15:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08 15:33 [PATCH 1/3] dt-bindings: Add vendor prefix for Smartlabs Christian Hewitt
2018-11-08 15:33 ` [PATCH 2/3] dt-bindings: arm: amlogic: Add support for the Smartlabs SML-5442TW Christian Hewitt
2018-11-08 15:33 ` [PATCH 3/3] ARM64: dts: meson-gxl: " Christian Hewitt
2018-11-08 15:56   ` jbrunet at baylibre.com [this message]
2018-11-09  1:31   ` kbuild test robot
2018-11-08 17:01 ` [PATCH v2 0/3] ARM64: dts: meson-gxl: Add dts and bindings for " Christian Hewitt
2018-11-08 17:01   ` [PATCH v2 1/3] dt-bindings: Add vendor prefix for Smartlabs Christian Hewitt
2018-11-08 17:07     ` Andreas Färber
2018-11-08 17:01   ` [PATCH v2 2/3] dt-bindings: arm: amlogic: Add support for the Smartlabs SML-5442TW Christian Hewitt
2018-11-08 17:01   ` [PATCH v2 3/3] ARM64: dts: meson-gxl: " Christian Hewitt
2018-11-08 17:03     ` jbrunet at baylibre.com
2018-11-08 19:43 ` [PATCH v3 0/3] ARM64: dts: meson-gxl: Add dts and bindings for " Christian Hewitt
2018-11-08 19:43   ` [PATCH v3 1/3] dt-bindings: Add vendor prefix for Smartlabs LLC Christian Hewitt
2018-11-09 18:29     ` Andreas Färber
2018-11-09 18:44       ` Christian Hewitt
2018-11-08 19:43   ` [PATCH v3 2/3] dt-bindings: arm: amlogic: Add support for the Smartlabs SML-5442TW Christian Hewitt
2018-11-13  2:12     ` Rob Herring
2018-11-08 19:43   ` [PATCH v3 3/3] ARM64: dts: meson-gxl: " Christian Hewitt
2018-11-09  9:41     ` Neil Armstrong
2018-11-09 13:17     ` jbrunet at baylibre.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bafa32609200e57d8efe9843247429a46916bbef.camel@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®