From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2980FEB64D9 for ; Mon, 10 Jul 2023 11:10:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jCA2TNFAOIbDmRGyKWRsionvmixArRK9YlQMRkgYrq0=; b=dV28rs66H3Xf29UjIbp++Tf2br vNPik5wqK72zCIKPV5dvUIo1u2IjPc+OwWU/5tE9TFTyO60XX/VjLAh+Mh7icPgc/tR5B4X0IHlBM wGJaMTTMqk2vM7v5unA0E+KN8SFHy05svkjUqqbo8ReyeRDQILL0bKi2RFl6dg2wkOkt0ilcEbEU2 m9UkSNhU0bVWIe/j/8iytOIAeP/Ps4M2XW/Nj3EV9ptr3KXbvOMp787RbnE3oIS1ePpl3ctgpn+NB EMhZrP0Qp5GnO6VsBKhtvOekyUFDqoVpzLqQOxkhQt2kZi+um2JBIgOWSY1mhDxd4hYi0Xv0jqnY5 WlDRTRRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qIomY-00BRTk-2i; Mon, 10 Jul 2023 11:10:18 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qIomW-00BRT3-0d; Mon, 10 Jul 2023 11:10:17 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0AAB360F99; Mon, 10 Jul 2023 11:10:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BE7CC433C7; Mon, 10 Jul 2023 11:10:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688987414; bh=gBzc2tZIawZS0PUBWYuNntkIVRyxrqJrpV4aYLufX50=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YCpsYi8hZ5dhRZJo2dzz+GDrlvZ3y3Af66p3CIYUZn5Y7dTwO5nu+KqKKyalcHXoR PkygyNMxxD1kJ/lpREraWAr7ptMwrZdtMjK3PU29AnATl/uf8vAL9Nckrl/+MeLppg 19u1l5oucwxlHlsOpcNXdgeY/3jdD6Md8RpxHE5vhqDd2CdGQZpt4EJ9jkXLMIe2Vi j8G3+oragW3KzCHXGkgfsqlqyuDdPjSBwMnDouPbYGO7j5vHL2lOm/CiBcEG3D/6Yt UEI3ZfBZW8x+aJt6SPMz70Pu1DNSCBE7XnZHCFijw9ibPwJlex9VzJs5Gg1OIblL+p 7Sf/vgDKmS0KA== Date: Mon, 10 Jul 2023 12:10:03 +0100 From: Mark Brown To: Andy Shevchenko Cc: Yang Yingliang , Amit Kumar Mahapatra via Alsa-devel , Kris Bahnsen , Neil Armstrong , Tharun Kumar P , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, Radu Pirea , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Tudor Ambarus , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Max Filippov , Richard Cochran Subject: Re: [PATCH v1 4/8] spi: Get rid of old SPI_MASTER_NO_.X and SPI_MASTER_MUST_.X Message-ID: References: <20230710102751.83314-1-andriy.shevchenko@linux.intel.com> <20230710102751.83314-5-andriy.shevchenko@linux.intel.com> <1ffd5603-4140-4bf6-bfed-af70a6759bda@sirena.org.uk> MIME-Version: 1.0 In-Reply-To: X-Cookie: Do you have lysdexia? X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_041016_337623_EFF6EDD2 X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1360491223496758796==" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org --===============1360491223496758796== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XsbcL+9pzd4b793B" Content-Disposition: inline --XsbcL+9pzd4b793B Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 10, 2023 at 02:08:00PM +0300, Andy Shevchenko wrote: > On Mon, Jul 10, 2023 at 12:04:35PM +0100, Mark Brown wrote: > > On Mon, Jul 10, 2023 at 01:27:47PM +0300, Andy Shevchenko wrote: > >=20 > > > Convert the users to SPI_CONTROLLER_NO_?X and SPI_CONTROLLER_MUST_.X > > > and kill the not used anymore definitions. > > The above is not what this change does: > How to improve it? I was sure that the form of "converting to something a= nd > something" is clear... > > > - controller->flags =3D SPI_MASTER_MUST_RX | SPI_MASTER_MUST_TX; > > > + controller->flags =3D SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_= TX; The change here is not the change that is described above. --XsbcL+9pzd4b793B Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSr5woACgkQJNaLcl1U h9AETQf/V6X5zgJr6k7uYHVQFcwbbL/m5vofjoxPJtbBrBmanG5Gk4nvQRtvE5KM RpVSjTeFZ6uC+MkUxft/VIyhHYX0UETqWF2qmW7X91ieOzQ+qA80TTz19J1soL8A bdQuSDpZRGY0O5f9XVApQSJ9PvLzql1IvaU8JVkUlF9HL8cNol+5w/YPdvB3kKU0 zxUG62Tx0R0Qvo/ku288lZhsKbhtXH6jwNvsxH39TNsnewnat7fJiZvShg6theLk vV02J7JmsFAeUR3ZH24aBIcYM3bYv86vKInV1cKHAzBjoan98DG8cghY3IvapKia sf0W5e1oHmvyUi1zga0aGvHvsKHkcA== =AmsT -----END PGP SIGNATURE----- --XsbcL+9pzd4b793B-- --===============1360491223496758796== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic --===============1360491223496758796==--