From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 585FEC47DA9 for ; Sat, 27 Jan 2024 01:42:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=irghWkQAcDbqh4WVPjlFduPc3ImJAvEjr2skA5LXZRo=; b=mZ85PNubn32fnC YlfIeSXzEjdL9EybMVj+SYyO4XHQTkOSHww5H5cYsnSK9QClEqrMlo9BbC6S7IAAZ10U/Y5v+qsNk zCNtSk0mGegycDU8kQkQv4a2m7Oew9+yZxoD782Sv+/+qLm6WDo3assWpOey3PP3QLXF5JSp9+12v j5BOckJukQJMyICsPvanBhYjok6LU1WwagAeiejdqZjs2B3SIjDE2BCzuKu1XVaUI7J9UxcdQeTdS /LxdOgkPeYsht2y8ep9cwIt04SqixQSDpxyEIRf52S+gtYzH+mMike9HYvi1jHtR/Y1YMDMG9ZueU LEClF2yolpWEr0bdaPUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTXiP-000000069Aj-06hc; Sat, 27 Jan 2024 01:42:37 +0000 Received: from [50.53.50.0] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTXiL-0000000698f-1Znu; Sat, 27 Jan 2024 01:42:33 +0000 Message-ID: Date: Fri, 26 Jan 2024 17:42:32 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/17] media: videodev2.h: Fix kerneldoc Content-Language: en-US To: Ricardo Ribalda , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno , Sakari Ailus , Laurent Pinchart , Hans Verkuil , Hans Verkuil , Kieran Bingham , Bin Liu , Ezequiel Garcia , Philipp Zabel , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Marek Szyprowski , Andrzej Hajda , Bingbu Cao , Tianshu Qiu , Greg Kroah-Hartman , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, linux-amlogic@lists.infradead.org References: <20240126-gix-mtk-warnings-v1-0-eed7865fce18@chromium.org> <20240126-gix-mtk-warnings-v1-2-eed7865fce18@chromium.org> From: Randy Dunlap In-Reply-To: <20240126-gix-mtk-warnings-v1-2-eed7865fce18@chromium.org> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 1/26/24 15:16, Ricardo Ribalda wrote: > Named nested unions need their prefix: > https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html#nested-structs-unions > > Signed-off-by: Ricardo Ribalda Reviewed-by: Randy Dunlap Tested-by: Randy Dunlap Thanks. > --- > include/uapi/linux/videodev2.h | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 68e7ac178cc2..a8015e5e7fa4 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -1041,13 +1041,13 @@ struct v4l2_requestbuffers { > * struct v4l2_plane - plane info for multi-planar buffers > * @bytesused: number of bytes occupied by data in the plane (payload) > * @length: size of this plane (NOT the payload) in bytes > - * @mem_offset: when memory in the associated struct v4l2_buffer is > + * @m.mem_offset: when memory in the associated struct v4l2_buffer is > * V4L2_MEMORY_MMAP, equals the offset from the start of > * the device memory for this plane (or is a "cookie" that > * should be passed to mmap() called on the video node) > - * @userptr: when memory is V4L2_MEMORY_USERPTR, a userspace pointer > + * @m.userptr: when memory is V4L2_MEMORY_USERPTR, a userspace pointer > * pointing to this plane > - * @fd: when memory is V4L2_MEMORY_DMABUF, a userspace file > + * @m.fd: when memory is V4L2_MEMORY_DMABUF, a userspace file > * descriptor associated with this plane > * @m: union of @mem_offset, @userptr and @fd > * @data_offset: offset in the plane to the start of data; usually 0, > @@ -1085,14 +1085,14 @@ struct v4l2_plane { > * @sequence: sequence count of this frame > * @memory: enum v4l2_memory; the method, in which the actual video data is > * passed > - * @offset: for non-multiplanar buffers with memory == V4L2_MEMORY_MMAP; > + * @m.offset: for non-multiplanar buffers with memory == V4L2_MEMORY_MMAP; > * offset from the start of the device memory for this plane, > * (or a "cookie" that should be passed to mmap() as offset) > - * @userptr: for non-multiplanar buffers with memory == V4L2_MEMORY_USERPTR; > + * @m.userptr: for non-multiplanar buffers with memory == V4L2_MEMORY_USERPTR; > * a userspace pointer pointing to this buffer > - * @fd: for non-multiplanar buffers with memory == V4L2_MEMORY_DMABUF; > + * @m.fd: for non-multiplanar buffers with memory == V4L2_MEMORY_DMABUF; > * a userspace file descriptor associated with this buffer > - * @planes: for multiplanar buffers; userspace pointer to the array of plane > + * @m.planes: for multiplanar buffers; userspace pointer to the array of plane > * info structs for this buffer > * @m: union of @offset, @userptr, @planes and @fd > * @length: size in bytes of the buffer (NOT its payload) for single-plane > @@ -2423,15 +2423,15 @@ struct v4l2_meta_format { > > /** > * struct v4l2_format - stream data format > - * @type: enum v4l2_buf_type; type of the data stream > - * @pix: definition of an image format > - * @pix_mp: definition of a multiplanar image format > - * @win: definition of an overlaid image > - * @vbi: raw VBI capture or output parameters > - * @sliced: sliced VBI capture or output parameters > - * @raw_data: placeholder for future extensions and custom formats > - * @fmt: union of @pix, @pix_mp, @win, @vbi, @sliced, @sdr, @meta > - * and @raw_data > + * @type: enum v4l2_buf_type; type of the data stream > + * @fmt.pix: definition of an image format > + * @fmt.pix_mp: definition of a multiplanar image format > + * @fmt.win: definition of an overlaid image > + * @fmt.vbi: raw VBI capture or output parameters > + * @fmt.sliced: sliced VBI capture or output parameters > + * @fmt.raw_data: placeholder for future extensions and custom formats > + * @fmt: union of @pix, @pix_mp, @win, @vbi, @sliced, @sdr, > + * @meta and @raw_data > */ > struct v4l2_format { > __u32 type; > -- #Randy _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic