mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: amlogic: drop redundant status=okay
Date: Mon, 11 Dec 2023 10:08:44 +0100	[thread overview]
Message-ID: <c336d071-34a9-4635-bcde-3861c7f11bd6@linaro.org> (raw)
In-Reply-To: <20231209124401.93814-1-krzysztof.kozlowski@linaro.org>

On 09/12/2023 13:44, Krzysztof Kozlowski wrote:
> New device nodes are enabled by default, so no need for status=okay.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Tested by comparing decompiled DTBs.
> ---
>   arch/arm64/boot/dts/amlogic/meson-axg-s400.dts         | 5 -----
>   arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts      | 1 -
>   arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts     | 1 -
>   arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts      | 1 -
>   arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dts   | 1 -
>   arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi    | 1 -
>   arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts     | 1 -
>   arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts        | 1 -
>   arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi   | 1 -
>   arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts | 1 -
>   arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts    | 1 -
>   arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts     | 1 -
>   arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts       | 1 -
>   13 files changed, 17 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> index df16eead2c80..c8905663bc75 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> @@ -66,7 +66,6 @@ linein: audio-codec-0 {
>   		VDDA-supply = <&vcc_3v3>;
>   		VDDP-supply = <&vcc_3v3>;
>   		VDDD-supply = <&vcc_3v3>;
> -		status = "okay";
>   		sound-name-prefix = "Linein";
>   	};
>   
> @@ -75,14 +74,12 @@ lineout: audio-codec-1 {
>   		compatible = "everest,es7154";
>   		VDD-supply = <&vcc_3v3>;
>   		PVDD-supply = <&vcc_5v>;
> -		status = "okay";
>   		sound-name-prefix = "Lineout";
>   	};
>   
>   	spdif_dit: audio-codec-2 {
>   		#sound-dai-cells = <0>;
>   		compatible = "linux,spdif-dit";
> -		status = "okay";
>   		sound-name-prefix = "DIT";
>   	};
>   
> @@ -91,14 +88,12 @@ dmics: audio-codec-3 {
>   		compatible = "dmic-codec";
>   		num-channels = <7>;
>   		wakeup-delay-ms = <50>;
> -		status = "okay";
>   		sound-name-prefix = "MIC";
>   	};
>   
>   	spdif_dir: audio-codec-4 {
>   		#sound-dai-cells = <0>;
>   		compatible = "linux,spdif-dir";
> -		status = "okay";
>   		sound-name-prefix = "DIR";
>   	};
>   
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> index 0ad0c2b7dfef..4c4550dd4711 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> @@ -45,7 +45,6 @@ dmics: audio-codec-1 {
>   		compatible = "dmic-codec";
>   		num-channels = <2>;
>   		wakeup-delay-ms = <50>;
> -		status = "okay";
>   		sound-name-prefix = "MIC";
>   	};
>   
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> index 4969a76460fa..9b55982b6a6b 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
> @@ -22,7 +22,6 @@ aliases {
>   	spdif_dit: audio-codec-1 {
>   		#sound-dai-cells = <0>;
>   		compatible = "linux,spdif-dit";
> -		status = "okay";
>   		sound-name-prefix = "DIT";
>   	};
>   
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts
> index 8fc2e143cb54..0da386cabe1a 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts
> @@ -22,7 +22,6 @@ aliases {
>   	spdif_dit: audio-codec-1 {
>   		#sound-dai-cells = <0>;
>   		compatible = "linux,spdif-dit";
> -		status = "okay";
>   		sound-name-prefix = "DIT";
>   	};
>   
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dts
> index ce548b373296..6396f190d703 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dts
> @@ -17,7 +17,6 @@ / {
>   	spdif_dit: audio-codec-1 {
>   		#sound-dai-cells = <0>;
>   		compatible = "linux,spdif-dit";
> -		status = "okay";
>   		sound-name-prefix = "DIT";
>   	};
>   
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi
> index 18f7b730289e..e59c3c92b1e7 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi
> @@ -26,7 +26,6 @@ dio2133: analog-amplifier {
>   	spdif_dit: audio-codec-0 {
>   		#sound-dai-cells = <0>;
>   		compatible = "linux,spdif-dit";
> -		status = "okay";
>   		sound-name-prefix = "DIT";
>   	};
>   
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
> index e238f1f10124..f28452b9f00f 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
> @@ -18,7 +18,6 @@ / {
>   	spdif_dit: audio-codec-0 {
>   		#sound-dai-cells = <0>;
>   		compatible = "linux,spdif-dit";
> -		status = "okay";
>   		sound-name-prefix = "DIT";
>   	};
>   
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
> index 292c718ee19c..591455c50e88 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dts
> @@ -18,7 +18,6 @@ / {
>   	spdif_dit: audio-codec-0 {
>   		#sound-dai-cells = <0>;
>   		compatible = "linux,spdif-dit";
> -		status = "okay";
>   		sound-name-prefix = "DIT";
>   	};
>   
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
> index e8303089bff6..74df32534231 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95.dtsi
> @@ -21,7 +21,6 @@ chosen {
>   	spdif_dit: audio-codec-0 {
>   		#sound-dai-cells = <0>;
>   		compatible = "linux,spdif-dit";
> -		status = "okay";
>   		sound-name-prefix = "DIT";
>   	};
>   
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
> index e1b74b174915..376760d86766 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dts
> @@ -17,7 +17,6 @@ / {
>   	spdif_dit: audio-codec-0 {
>   		#sound-dai-cells = <0>;
>   		compatible = "linux,spdif-dit";
> -		status = "okay";
>   		sound-name-prefix = "DIT";
>   	};
>   
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts
> index 7d525bdb0e06..ad2dd4ad0a31 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dts
> @@ -28,7 +28,6 @@ chosen {
>   	spdif_dit: audio-codec-0 {
>   		#sound-dai-cells = <0>;
>   		compatible = "linux,spdif-dit";
> -		status = "okay";
>   		sound-name-prefix = "DIT";
>   	};
>   
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts
> index 50d49aec41bd..d05dde8da5c5 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts
> @@ -37,7 +37,6 @@ memory@0 {
>   	spdif_dit: audio-codec-0 {
>   		#sound-dai-cells = <0>;
>   		compatible = "linux,spdif-dit";
> -		status = "okay";
>   		sound-name-prefix = "DIT";
>   	};
>   
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
> index 095579c55f18..109932068dbe 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
> @@ -32,7 +32,6 @@ dmics: audio-codec-1 {
>   		compatible = "dmic-codec";
>   		num-channels = <2>;
>   		wakeup-delay-ms = <50>;
> -		status = "okay";
>   		sound-name-prefix = "MIC";
>   	};
>   

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2023-12-11  9:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-09 12:44 Krzysztof Kozlowski
2023-12-11  9:08 ` Neil Armstrong [this message]
2023-12-11 11:08 ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c336d071-34a9-4635-bcde-3861c7f11bd6@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®