From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C3F2C56201 for ; Tue, 24 Nov 2020 13:24:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C16C2076E for ; Tue, 24 Nov 2020 13:24:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EJh53beJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="gj9xtUkz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C16C2076E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fup0XDaAthzUl3FKoITjlhQX8rkztfMXqmBmmDLj0yg=; b=EJh53beJqpOiPcaepckHKon4Nr NqS0JdOVaFjbDOsCFa7Dl+ogb0GxyGFoQqTr7QJB3dEXLlRBxi8ZqGlexSCGbZU1DQuQfOdz2gwGb sUpkjWxfSczSsQaSAMeVhP2Z10tJ+gETwIDEhm0LgjeYLPQqf1u6Yu7IySWDm60krx8j/AJ65uaQd Z+0MxSaX1Ks+xtU58GZsUkir8SwS77m+y8OCLfmLVky/kE4Q3zbxIv288ENKL4YNFQHVKQJhWBOCl gJWM+t7YRTQ7UhTJeNR8srdnzD747RXB+Wj+ZXWWrPKDCAcMjKbnHnywCY4R20IYtQIiRbU0azO3U F1fBBgiA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khYIy-0007UT-Kk; Tue, 24 Nov 2020 13:24:24 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khYIt-0007Sw-FI for linux-amlogic@lists.infradead.org; Tue, 24 Nov 2020 13:24:21 +0000 Received: by mail-wr1-x444.google.com with SMTP id g14so7111702wrm.13 for ; Tue, 24 Nov 2020 05:24:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:autocrypt:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=joK0uYh+g9axnkU4sYYOePA4lWxUi/sKt+xtkHJq3/o=; b=gj9xtUkzlieDr+vB4lLEah/BpQVMCj7W0vaBfc4PlKQ2vr4QmtSlYExv2sv8YXQSBL ohzJ9DcGEcY8C7C4tnFpJYmZqFaLLa0ebQtugCYFCDQ73nSts4oHz425/P+C1j67NKDQ Sk/fBMExHWSzG/JXEtuSSShfGtI8ENBdwUeFrQ9LvjgRiVvByuPeq2u0bq2DbzOirthY bH6KHdoDCHJMZCg9WQ40ZgFn4mJt2OkdYEHLP7uvDZm8KMXk0pVRMI8ndzmcuSDcnzVw 3SGSezmeuo8hMQxU9LGtUHwwFFCdk3pMouegYzaI/ffJVIVU3BTigcgAGBPnaCj3Oay5 LeYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=joK0uYh+g9axnkU4sYYOePA4lWxUi/sKt+xtkHJq3/o=; b=B/tncNvvoQlg6sLu7DUkfXrO64/rWHsKqQvCgx1hu/3AOHdh0iPrcMfC6XOegfxihV MASiG8+4XQ0p/gPL1cZwtP0JsaMiKYvp/fMpQOUjwQwH+O1Mb3r+g/MTvVdggBgXNiwa h4JSHNzDAT2ST3r4L12dwVYutah0FRQEv+uJtFk+Tkt3d5pNpQR+yjfbBJihUtXB5Uf4 0JdOE5ScsoM+KDc71Lelfjk7h5r/8JBYof+qYqHJxGUd7mytfUgRHRzuHb39lfToQrRI qtMUb8n63gDuxxpDx15nyP/bndLS5AMVZZmbd5T8N6D15YrcHRTAboIjINu97esLMJQ+ MSyg== X-Gm-Message-State: AOAM5305Sr25rV/sbE3dw7QhVFw98rcsP/k0UpoSBqvrDJpvvIPxDX0W ZF5as8KeO1xt5h86J9iSrE1WbA== X-Google-Smtp-Source: ABdhPJzWWzoCVKgvXVk+cSvFOUFsPSxpNaGV/cSTZYha0Vg0cJSBVGXzuPEJhMr1wSoYap78frmVUA== X-Received: by 2002:a5d:4408:: with SMTP id z8mr5646869wrq.204.1606224256582; Tue, 24 Nov 2020 05:24:16 -0800 (PST) Received: from ?IPv6:2a01:e35:2ec0:82b0:3daa:7c69:63d6:7d7d? ([2a01:e35:2ec0:82b0:3daa:7c69:63d6:7d7d]) by smtp.gmail.com with ESMTPSA id s13sm10016035wrt.80.2020.11.24.05.24.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Nov 2020 05:24:15 -0800 (PST) Subject: Re: [PATCH] arm64: dts: meson: Add capacity-dmips-mhz attributes to GXM To: Christian Hewitt , Rob Herring , Mark Rutland , Kevin Hilman , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20201124121740.25704-1-christianshewitt@gmail.com> From: Neil Armstrong Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= mQENBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAG0KE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT6JATsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIW5AQ0ETVkGzwEIALyKDN/O GURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYpQTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXM coJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hi SvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY4yG6xI99NIPEVE9lNBXBKIlewIyVlkOa YvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoMMtsyw18YoX9BqMFInxqYQQ3j/HpVgTSv mo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUXoUk33HEAEQEAAYkBHwQYAQIACQUCTVkG zwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfnM7IbRuiSZS1unlySUVYu3SD6YBYnNi3G 5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa33eDIHu/zr1HMKErm+2SD6PO9umRef8V8 2o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCSKmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+ RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJ C3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTTQbM0WUIBIcGmq38+OgUsMYu4NzLu7uZF Acmp6h8guQINBFYnf6QBEADQ+wBYa+X2n/xIQz/RUoGHf84Jm+yTqRT43t7sO48/cBW9vAn9 GNwnJ3HRJWKATW0ZXrCr40ES/JqM1fUTfiFDB3VMdWpEfwOAT1zXS+0rX8yljgsWR1UvqyEP 3xN0M/40Zk+rdmZKaZS8VQaXbveaiWMEmY7sBV3QvgOzB7UF2It1HwoCon5Y+PvyE3CguhBd 9iq5iEampkMIkbA3FFCpQFI5Ai3BywkLzbA3ZtnMXR8Qt9gFZtyXvFQrB+/6hDzEPnBGZOOx zkd/iIX59SxBuS38LMlhPPycbFNmtauOC0DNpXCv9ACgC9tFw3exER/xQgSpDVc4vrL2Cacr wmQp1k9E0W+9pk/l8S1jcHx03hgCxPtQLOIyEu9iIJb27TjcXNjiInd7Uea195NldIrndD+x 58/yU3X70qVY+eWbqzpdlwF1KRm6uV0ZOQhEhbi0FfKKgsYFgBIBchGqSOBsCbL35f9hK/JC 6LnGDtSHeJs+jd9/qJj4WqF3x8i0sncQ/gszSajdhnWrxraG3b7/9ldMLpKo/OoihfLaCxtv xYmtw8TGhlMaiOxjDrohmY1z7f3rf6njskoIXUO0nabun1nPAiV1dpjleg60s3OmVQeEpr3a K7gR1ljkemJzM9NUoRROPaT7nMlNYQL+IwuthJd6XQqwzp1jRTGG26J97wARAQABiQM+BBgB AgAJBQJWJ3+kAhsCAikJEBaat7Gkz/iuwV0gBBkBAgAGBQJWJ3+kAAoJEHfc29rIyEnRk6MQ AJDo0nxsadLpYB26FALZsWlN74rnFXth5dQVQ7SkipmyFWZhFL8fQ9OiIoxWhM6rSg9+C1w+ n45eByMg2b8H3mmQmyWztdI95OxSREKwbaXVapCcZnv52JRjlc3DoiiHqTZML5x1Z7lQ1T3F 8o9sKrbFO1WQw1+Nc91+MU0MGN0jtfZ0Tvn/ouEZrSXCE4K3oDGtj3AdC764yZVq6CPigCgs 6Ex80k6QlzCdVP3RKsnPO2xQXXPgyJPJlpD8bHHHW7OLfoR9DaBNympfcbQJeekQrTvyoASw EOTPKE6CVWrcQIztUp0WFTdRGgMK0cZB3Xfe6sOp24PQTHAKGtjTHNP/THomkH24Fum9K3iM /4Wh4V2eqGEgpdeSp5K+LdaNyNgaqzMOtt4HYk86LYLSHfFXywdlbGrY9+TqiJ+ZVW4trmui NIJCOku8SYansq34QzYM0x3UFRwff+45zNBEVzctSnremg1mVgrzOfXU8rt+4N1b2MxorPF8 619aCwVP7U16qNSBaqiAJr4e5SNEnoAq18+1Gp8QsFG0ARY8xp+qaKBByWES7lRi3QbqAKZf yOHS6gmYo9gBmuAhc65/VtHMJtxwjpUeN4Bcs9HUpDMDVHdfeRa73wM+wY5potfQ5zkSp0Jp bxnv/cRBH6+c43stTffprd//4Hgz+nJcCgZKtCYIAPkUxABC85ID2CidzbraErVACmRoizhT KR2OiqSLW2x4xdmSiFNcIWkWJB6Qdri0Fzs2dHe8etD1HYaht1ZhZ810s7QOL7JwypO8dscN KTEkyoTGn6cWj0CX+PeP4xp8AR8ot4d0BhtUY34UPzjE1/xyrQFAdnLd0PP4wXxdIUuRs0+n WLY9Aou/vC1LAdlaGsoTVzJ2gX4fkKQIWhX0WVk41BSFeDKQ3RQ2pnuzwedLO94Bf6X0G48O VsbXrP9BZ6snXyHfebPnno/te5XRqZTL9aJOytB/1iUna+1MAwBxGFPvqeEUUyT+gx1l3Acl ZaTUOEkgIor5losDrePdPgE= Organization: Baylibre Message-ID: Date: Tue, 24 Nov 2020 14:24:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201124121740.25704-1-christianshewitt@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201124_082419_699162_889223D2 X-CRM114-Status: GOOD ( 20.17 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 24/11/2020 13:17, Christian Hewitt wrote: > GXM (S912) is a big-little design with CPUs 0-3 clocked at 1.5GHz > and CPUs 4-7 at 1.0GHz. Adding capacity-dmips-mhz attributes allows > the scheduler to factor the different clock speeds into capacity > calculations and prefer the higher-clocked cluster to improve > overall performance. > > This was inspired by the similar change for G12B [0] boards. The > diference here is that all cores are A53's so the same dmips-mhz > value is used. > > VIM2:~ # cat /sys/devices/system/cpu/cpu*/cpufreq/scaling_cur_freq > 1512000 > 1512000 > 1512000 > 1512000 > 1000000 > 1000000 > 1000000 > 1000000 > > before: > > VIM2:~ # cat /sys/devices/system/cpu/cpu*/cpu_capacity > 1024 > 1024 > 1024 > 1024 > 1024 > 1024 > 1024 > 1024 > > after: > > VIM2:~ # cat /sys/devices/system/cpu/cpu*/cpu_capacity > 1024 > 1024 > 1024 > 1024 > 677 > 677 > 677 > 677 > > The after value matches my table-napkin calculation: > > (1000000 / 1512000 = 0.661) * 1024 = 677 > > [0] https://github.com/torvalds/linux/commit/6eeaf4d2452ec8b1ece58776812140734fc2e088 > > Signed-off-by: Christian Hewitt > --- > arch/arm64/boot/dts/amlogic/meson-gxm.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi > index fe4145112295..411cc312fc62 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxm.dtsi > @@ -42,11 +42,28 @@ > }; > }; > > + cpu0: cpu@0 { > + capacity-dmips-mhz = <1024>; > + }; > + > + cpu1: cpu@1 { > + capacity-dmips-mhz = <1024>; > + }; > + > + cpu2: cpu@2 { > + capacity-dmips-mhz = <1024>; > + }; > + > + cpu3: cpu@3 { > + capacity-dmips-mhz = <1024>; > + }; > + > cpu4: cpu@100 { > device_type = "cpu"; > compatible = "arm,cortex-a53"; > reg = <0x0 0x100>; > enable-method = "psci"; > + capacity-dmips-mhz = <1024>; > next-level-cache = <&l2>; > clocks = <&scpi_dvfs 1>; > #cooling-cells = <2>; > @@ -57,6 +74,7 @@ > compatible = "arm,cortex-a53"; > reg = <0x0 0x101>; > enable-method = "psci"; > + capacity-dmips-mhz = <1024>; > next-level-cache = <&l2>; > clocks = <&scpi_dvfs 1>; > #cooling-cells = <2>; > @@ -67,6 +85,7 @@ > compatible = "arm,cortex-a53"; > reg = <0x0 0x102>; > enable-method = "psci"; > + capacity-dmips-mhz = <1024>; > next-level-cache = <&l2>; > clocks = <&scpi_dvfs 1>; > #cooling-cells = <2>; > @@ -77,6 +96,7 @@ > compatible = "arm,cortex-a53"; > reg = <0x0 0x103>; > enable-method = "psci"; > + capacity-dmips-mhz = <1024>; > next-level-cache = <&l2>; > clocks = <&scpi_dvfs 1>; > #cooling-cells = <2>; > Re-reading the bindings, the value is correct and necessary to have the cpu_capacity calculated to help the scheduler. Thanks! Reviewed-by: Neil Armstrong _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic