From: Neil Armstrong <neil.armstrong@linaro.org>
To: Yangtao Li <frank.li@vivo.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] reset: meson-audio-arb: Convert to devm_platform_ioremap_resource()
Date: Tue, 4 Jul 2023 14:12:47 +0200 [thread overview]
Message-ID: <c6d4daa1-d58a-2a29-3121-e1405c3ccc15@linaro.org> (raw)
In-Reply-To: <20230704120211.38122-2-frank.li@vivo.com>
On 04/07/2023 14:02, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> drivers/reset/reset-meson-audio-arb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/reset/reset-meson-audio-arb.c b/drivers/reset/reset-meson-audio-arb.c
> index 6a3f6a6a3bbf..355e041214bd 100644
> --- a/drivers/reset/reset-meson-audio-arb.c
> +++ b/drivers/reset/reset-meson-audio-arb.c
> @@ -138,7 +138,6 @@ static int meson_audio_arb_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> const struct meson_audio_arb_match_data *data;
> struct meson_audio_arb_data *arb;
> - struct resource *res;
> int ret;
>
> data = of_device_get_match_data(dev);
> @@ -154,8 +153,7 @@ static int meson_audio_arb_probe(struct platform_device *pdev)
> if (IS_ERR(arb->clk))
> return dev_err_probe(dev, PTR_ERR(arb->clk), "failed to get clock\n");
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - arb->regs = devm_ioremap_resource(dev, res);
> + arb->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(arb->regs))
> return PTR_ERR(arb->regs);
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2023-07-04 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230704120211.38122-1-frank.li@vivo.com>
2023-07-04 12:02 ` Yangtao Li
2023-07-04 12:12 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6d4daa1-d58a-2a29-3121-e1405c3ccc15@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=frank.li@vivo.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®