From: Neil Armstrong <narmstrong@baylibre.com>
To: Fabio Estevam <festevam@denx.de>, martin.blumenstingl@googlemail.com
Cc: linux-arm-kernel@lists.infradead.org, khilman@baylibre.com,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2 2/2] arm64: dts: meson-sm1-sei610: Remove 'enable-active-low'
Date: Mon, 29 Aug 2022 09:37:46 +0200 [thread overview]
Message-ID: <c949f3cd-b3f4-5c51-0bc8-7d46c1e26809@baylibre.com> (raw)
In-Reply-To: <20220827203813.1742715-2-festevam@denx.de>
On 27/08/2022 22:38, Fabio Estevam wrote:
> The 'enable-active-low' property is not a valid one.
>
> Only 'enable-active-high' is valid, and when this property is absent
> the gpio regulator will act as active low by default.
>
> Remove the invalid 'enable-active-low' property.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> Changes since v1:
> - Put linux-amlogic on Cc and added Martin's Reviewed-by tag.
>
> arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
> index 603337ca5608..9068a334ea57 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
> @@ -171,7 +171,6 @@ vddao_3v3_t: regulator-vddao_3v3_t {
> regulator-max-microvolt = <3300000>;
> vin-supply = <&vddao_3v3>;
> gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
> - enable-active-low;
> regulator-always-on;
> };
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2022-08-29 7:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-27 20:38 [PATCH v2 1/2] arm64: dts: meson-g12a: " Fabio Estevam
2022-08-27 20:38 ` [PATCH v2 2/2] arm64: dts: meson-sm1-sei610: " Fabio Estevam
2022-08-29 7:37 ` Neil Armstrong [this message]
2022-08-29 7:37 ` [PATCH v2 1/2] arm64: dts: meson-g12a: " Neil Armstrong
2022-08-29 7:49 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c949f3cd-b3f4-5c51-0bc8-7d46c1e26809@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=festevam@denx.de \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®