From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4924C74A21 for ; Wed, 10 Jul 2019 16:01:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A95482064A for ; Wed, 10 Jul 2019 16:01:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YXpBFOyX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A95482064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iImUOmevVUQMSmESrqXe4lkbvdNUKy/jHP3uJFCBg/Q=; b=YXpBFOyXIlyF6O l8JRc0ANNybxSe4VcLV0fvxDKwyLZfM7OmBJIwrq45fzc4oMrT9W9HBc1MdHbjseuXYZn2XxPBPUs 39OUeFeke8ZYteeT9P6D0fGuvscyZqbWkr8CVI07CPHV7/LPiKaO+kzx1CN6AVNlY8LNsZmG3x9rD gZWTLtWBUZBc8PgP3qG27TVeBSnocIboDWb9qetSxuZaAJd6xYL/cl684ntlrYJsF9qqTgh+IEanY 6GJ1PQIXJBlQKsudzDxqoPjVN5Vviyvv00s9WO9fnlMauvCg0nOC2BqZAxCiI33rHYUvwpL0CYENS qh0qxMVgq8ciww56JOvg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hlF2K-0002L0-Uk; Wed, 10 Jul 2019 16:01:40 +0000 Received: from smtprelay0218.hostedemail.com ([216.40.44.218] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hlF2H-0002Jj-Mp; Wed, 10 Jul 2019 16:01:39 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id A05E28368EF4; Wed, 10 Jul 2019 16:01:31 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: balls52_46dfd74d6cd5c X-Filterd-Recvd-Size: 2713 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA; Wed, 10 Jul 2019 16:01:26 +0000 (UTC) Message-ID: Subject: Re: [PATCH 00/12] treewide: Fix GENMASK misuses From: Joe Perches To: Russell King - ARM Linux admin , Johannes Berg Date: Wed, 10 Jul 2019 09:01:25 -0700 In-Reply-To: References: <5fa1fa6998332642c49e2d5209193ffe2713f333.camel@sipsolutions.net> <20190710094337.wf2lftxzfjq2etro@shell.armlinux.org.uk> User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190710_090137_818444_F39CF14E X-CRM114-Status: GOOD ( 12.00 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-mmc@vger.kernel.org, alsa-devel@alsa-project.org, Benjamin Fair , linux-aspeed@lists.ozlabs.org, Andrew Jeffery , Patrick Venture , openbmc@lists.ozlabs.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Nancy Yuen , linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, linux-amlogic@lists.infradead.org, Andrew Morton , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed, 2019-07-10 at 08:45 -0700, Joe Perches wrote: > On Wed, 2019-07-10 at 10:43 +0100, Russell King - ARM Linux admin wrote: > > On Wed, Jul 10, 2019 at 11:17:31AM +0200, Johannes Berg wrote: > > > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > > > These GENMASK uses are inverted argument order and the > > > > actual masks produced are incorrect. Fix them. > > > > > > > > Add checkpatch tests to help avoid more misuses too. > > > > > > > > Joe Perches (12): > > > > checkpatch: Add GENMASK tests > > > > > > IMHO this doesn't make a lot of sense as a checkpatch test - just throw > > > in a BUILD_BUG_ON()? > > I tried that. > > It'd can't be done as it's used in declarations > and included in asm files and it uses the UL() > macro. > > I also tried just making it do the right thing > whatever the argument order. I forgot. I also made all those arguments when it was introduced in 2013. https://lore.kernel.org/patchwork/patch/414248/ > Oh well. yeah. _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic