Re: [PATCH v10 1/2] perf/amlogic: Add support for Amlogic meson G12 SoC DDR PMU driver

From: Jiucheng Xu <jiucheng.xu@amlogic.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-amlogic@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Jonathan Corbet <corbet@lwn.net>, Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Shuai Xue <xueshuai@linux.alibaba.com>,
	John Garry <john.garry@huawei.com>,
	Wan Jiabing <wanjiabing@vivo.com>,
	Chris Healy <cphealy@gmail.com>,
	Jianxin Pan <jianxin.pan@amlogic.com>,
	Kelvin Zhang <kelvin.zhang@amlogic.com>,
	Chris Healy <healych@amzon.com>
Subject: Re: [PATCH v10 1/2] perf/amlogic: Add support for Amlogic meson G12 SoC DDR PMU driver
Date: Wed, 16 Nov 2022 17:49:43 +0800	[thread overview]
Message-ID: <ccc924e6-8626-c95a-1be8-c2280fa06f3a@amlogic.com> (raw)
In-Reply-To: <Y3SjuC6xHn1uz2zX@debian.me>


> What about this description below?
>
> ```
> Add support for Amlogic Meson G12 Series SOC - DDR bandwidth PMU driver
> framework and interfaces. The PMU can not only monitor the total DDR
> bandwidth, but also individual IP module bandwidth.
> ```
Thanks, Your description looks like much better. I agree with you.
>> Example usage:
>>
>>   $ perf stat -a -e meson_ddr_bw/total_rw_bytes/ -I 1000 sleep 10
>>
>> - or -
>>
>>   $ perf stat -a -e \
>>     meson_ddr_bw/total_rw_bytes/,\
>>     meson_ddr_bw/chan_1_rw_bytes,arm=1/ -I 1000 \
>>     sleep 10
>>
>> g12 SoC support 4 channels to monitor DDR bandwidth
>> simultaneously. Each channel can monitor up to 4 IP modules
>> simultaneously.
>>
>> For Instance, If you want to get the sum of DDR bandwidth
>> from CPU, GPU, USB3.0 and VDEC. You can use the following
>> command parameters to display.
>>
>>   $ perf stat -a -e \
>>     meson_ddr_bw/chan_2_rw_bytes,arm=1,gpu=1,usb3_0=1,nna=1/ -I 1000 \
>>     sleep 10
>>
>> Other events are supported, and advertised via perf list.
> The demo example should have been outside the patch description, though
> (more appropriate documentation as in patch [2/2]).
>
> Thanks.
Okay, I will modify it in the next version.

-- 
Thanks,
Jiucheng


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic