From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04E11CD4851 for ; Tue, 19 May 2026 06:25:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:Subject:From: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p7x7Z8+dwvf07ADxORb/QoiI/z/AHuC1Tc6JuxngEQU=; b=0bNqNipv2zHMKm f0m4XdpugGkpUkZzb4j5z/Hyruejfbc6V0YDNBlbnM+dsniBDqEsVYlDa9sBFloJ5QpyDR6HMFSP3 yc24ARcPO41lyBrKgIqQpzbi6D+77PSJ1673HyhTo0E7a6Bk+mtv3Nf/VQLFZt53UUqDICNXilZYr O4gEqSczkwhGJVwCrDXAjNu2PUHRjZ6f/qnVbQuAYCFHyODvqcmE0KSqORXfcr9XYG+wlnkSBeQgN DkBFlxO9xWThCUGStDN3b2icSd3xG6tnb2jBZZtACEaLk7iwtBgkkyKhob8cpIPgp3m3nI4JvUThs POyLPYYT3KD4HMIDj5yA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPDtE-00000000K2e-2rLE; Tue, 19 May 2026 06:25:16 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPDtD-00000000K2F-0F1y; Tue, 19 May 2026 06:25:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 677F2601FD; Tue, 19 May 2026 06:25:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 906AEC2BCF6; Tue, 19 May 2026 06:25:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779171914; bh=MpgzPBqE/fWyBM0VdbQHNzKaNFoOyD/JuCeyGfbplSs=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=jo9E0rC68t/vIL+8vT1U3oPlIMgYNtoE9ZXok8N9x6ULV/N8mqfPdAyrI1tQRnzQ4 b6QTyyd+G3c/kCJsgwdMx3M3d8HKPSkkH8hmd8EVqnNoIm82itL7fLwFpAjTZs2NKI oP6dVzJRWYA4pTC1US5z6FoZgtHmFCvoJcG1iQ9dFyImwn6Jsp547vwZEkqH+lOrUF 9YdQgczrAATdePQFoJZud3qudrVVW1A6x4Me4zNLcZscep3QjS9UFEjYDKuS/Yd16y szYTcOAY6zjO62mRMRlVNgTxWvs5+GY6+blpY87MbZiB5sgBbeWR76O0RsXqC7klT+ lzTnBLfMrCnlg== Message-ID: Date: Tue, 19 May 2026 08:25:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Hans Verkuil Subject: Re: [PATCH v7 10/23] drm: bridge: dw_hdmi: Invalidate CEC phys addr from connector detect To: Jonas Karlman , Andrzej Hajda , Neil Armstrong , Robert Foss , Heiko Stuebner , Laurent Pinchart , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter References: <20260518180206.2480119-1-jonas@kwiboo.se> <20260518180206.2480119-11-jonas@kwiboo.se> Content-Language: en-US, nl In-Reply-To: <20260518180206.2480119-11-jonas@kwiboo.se> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Baryshkov , imx@lists.linux.dev, Liu Ying , linux-kernel@vger.kernel.org, Sandy Huang , dri-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev, Diederik de Haas , linux-rockchip@lists.infradead.org, linux-amlogic@lists.infradead.org, Andy Yan , Chen-Yu Tsai , Nicolas Frattaroli , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 18/05/2026 20:01, Jonas Karlman wrote: > Wait until the connector detect ops is called to invalidate CEC phys > addr instead of doing it directly from the irq handler. > > The CEC notifier is only registered for the dw-hdmi connector so this > has no impact when the bridge connector is used. > > Reviewed-by: Neil Armstrong > Tested-by: Diederik de Haas # Rock64, RockPro64, Quartz64-B > Signed-off-by: Jonas Karlman Acked-by: Hans Verkuil Regards, Hans > --- > v7: Update commit message > v6: Collect t-b tag > v5: No change > v4: No change > v3: No change > v2: Collect r-b tag > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 5fd26ff8f55b..aae1b890167b 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -2472,7 +2472,17 @@ dw_hdmi_connector_detect(struct drm_connector *connector, bool force) > { > struct dw_hdmi *hdmi = container_of(connector, struct dw_hdmi, > connector); > - return dw_hdmi_detect(hdmi); > + enum drm_connector_status status; > + > + status = dw_hdmi_detect(hdmi); > + > + if (status == connector_status_disconnected) { > + mutex_lock(&hdmi->cec_notifier_mutex); > + cec_notifier_phys_addr_invalidate(hdmi->cec_notifier); > + mutex_unlock(&hdmi->cec_notifier_mutex); > + } > + > + return status; > } > > static int dw_hdmi_connector_get_modes(struct drm_connector *connector) > @@ -3106,12 +3116,6 @@ static irqreturn_t dw_hdmi_irq(int irq, void *dev_id) > phy_stat & HDMI_PHY_HPD, > phy_stat & HDMI_PHY_RX_SENSE); > > - if ((phy_stat & (HDMI_PHY_RX_SENSE | HDMI_PHY_HPD)) == 0) { > - mutex_lock(&hdmi->cec_notifier_mutex); > - cec_notifier_phys_addr_invalidate(hdmi->cec_notifier); > - mutex_unlock(&hdmi->cec_notifier_mutex); > - } > - > if ((intr_stat & HDMI_IH_PHY_STAT0_HPD) && > (phy_stat & HDMI_PHY_HPD)) > status = connector_status_connected; _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic