From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36A77D69119 for ; Thu, 28 Nov 2024 15:35:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:References:In-Reply-To: Message-Id:Cc:To:From:Date:MIME-Version:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=8wSZaZ2oDfifBwJttjodGAbI7ehLn5d392fLqRCLKLc=; b=sDFwIfRroSPH9ELuC9y28kOu3F WL2MYQYt6Ne42VCID1Kl3M9JIziulT+P8MNlxuYv1DCaCeCgm3GfkqiFJxpxRSK56Li7oRlzE+yt5 CJeJrCqDzdXg1l37q5JMTiRtw6U4E3tXoDlBW62SdMSQCUVO7Uj6VC939vowgWTguwikARsV6GB53 R3//B1elIk8+5QQ6Ibskp7b2R4MYnivO7UspQOiNB+/zMlkrfLCof+r3nH5KpU7OflZs7sSTTUsA5 /5Xc1qn9lFLFFaCxOnn298I8ztWhLllBQzqgNnAp6+1CXd+exrgDwmiBLhoDs0kp5/171QrkDXbZI EyTXOXlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tGgYH-0000000Fu3X-3Haa; Thu, 28 Nov 2024 15:35:33 +0000 Received: from fout-b3-smtp.messagingengine.com ([202.12.124.146]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tGgYE-0000000Fu34-1sUp; Thu, 28 Nov 2024 15:35:32 +0000 Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.stl.internal (Postfix) with ESMTP id C559611401AA; Thu, 28 Nov 2024 10:35:28 -0500 (EST) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Thu, 28 Nov 2024 10:35:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1732808128; x=1732894528; bh=ABd2E925i20MEj4ELZS+Ijgs5QfhIL7sEUJJIVYesWg=; b= BEMNsoQ9uCXfNDsb0MTId8qxxrNIFf6WII43GdcSgCtAF5NjH3ErVbMNW+UYrCPz jJIaPgs2irKbfmRFIhgEpaf8dO13WBgCeIWGGNmgq6hCY0o6vNuDRLo7JH3YysI6 adWri8GFYNdOUA1QfAUR3yHxfQvNwJuZfzOI7/wHtsYGuTt+xE0AhHNqtK9FPzYr ND+Q9NAeiCBLUFu1jgRPwERvWLLlAJSL5jZN7KFBhfan8xnbQyGn9F15K1RvT9Oh 8Jk0yyP10aor/jop+auqG1h6B0Ul7vcVDzl1aFVSljjzUydrgpOyHSms82cJYY63 UzfD/AbyP+tNrJEr7nWW9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1732808128; x= 1732894528; bh=ABd2E925i20MEj4ELZS+Ijgs5QfhIL7sEUJJIVYesWg=; b=4 qbVI3GCWTAuAgTnL/VwXQnOQ3cZgRSKdUzStu3ng0ZQyfUz/ozrYsBvKSDyaaZxG GcZOzFDKltWxWCfZzku/nc2gS0toHdFukvTPtDx4LTlJ2QaUvvfeVHAuDJqdL6qg Q/PAnsf4oSnUXZlCxQubTJbdYZJjwvqdUASdY5B72oKSeH5ywjTEnAQSR5Nmo4tt nridA5YQ69ZdqLqNuRAaAk7+yLKAqRu8VtUob9EGUTBv/onLOYzRPcgfE8XaK8/8 J6UuqSaXjPWdvhMn7Bsl3wYiioo+FKPcggaN/KbMQDZgw2EV2Gjm9tsBsYM7eGAX Lumfh89mEd72OW2ZvTeUg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrhedugdejiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthejredtredttden ucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdrug gvqeenucggtffrrghtthgvrhhnpeefhfehteffuddvgfeigefhjeetvdekteekjeefkeek leffjeetvedvgefhhfeihfenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhgusegrrhhn uggsrdguvgdpnhgspghrtghpthhtohepuddupdhmohguvgepshhmthhpohhuthdprhgtph htthhopehjsghruhhnvghtsegsrgihlhhisghrvgdrtghomhdprhgtphhtthhopehkhhhi lhhmrghnsegsrgihlhhisghrvgdrtghomhdprhgtphhtthhopehmthhurhhquhgvthhtvg essggrhihlihgsrhgvrdgtohhmpdhrtghpthhtohepmhgrrhhtihhnrdgslhhumhgvnhhs thhinhhglhesghhoohhglhgvmhgrihhlrdgtohhmpdhrtghpthhtohepsghrohhonhhivg eskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepshgsohihugeskhgvrhhnvghlrdhorhhg pdhrtghpthhtohepnhgvihhlrdgrrhhmshhtrhhonhhgsehlihhnrghrohdrohhrghdprh gtphhtthhopehlihhnuhigqdgrmhhlohhgihgtsehlihhsthhsrdhinhhfrhgruggvrggu rdhorhhgpdhrtghpthhtoheplhhinhhugidqrghrmhdqkhgvrhhnvghlsehlihhsthhsrd hinhhfrhgruggvrggurdhorhhg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 394B72220071; Thu, 28 Nov 2024 10:35:28 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Thu, 28 Nov 2024 16:34:46 +0100 From: "Arnd Bergmann" To: "Jerome Brunet" Cc: "Neil Armstrong" , "Michael Turquette" , "Stephen Boyd" , "Kevin Hilman" , "Martin Blumenstingl" , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Mark Brown" Message-Id: In-Reply-To: <1jplmf1jqa.fsf@starbuckisacylon.baylibre.com> References: <20241127-clk-audio-fix-rst-missing-v1-1-9f9d0ab98fce@baylibre.com> <12f29978-c8ce-4bee-a447-dcd086eb936d@app.fastmail.com> <1ja5dk2y5l.fsf@starbuckisacylon.baylibre.com> <1j4j3r32ld.fsf@starbuckisacylon.baylibre.com> <306b0b30-5a32-4c7c-86b4-57d50e2307e8@app.fastmail.com> <1jy1131kxz.fsf@starbuckisacylon.baylibre.com> <1jplmf1jqa.fsf@starbuckisacylon.baylibre.com> Subject: Re: [PATCH] clk: amlogic: axg-audio: select RESET_MESON_AUX X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241128_073531_196540_B04E07C8 X-CRM114-Status: GOOD ( 19.54 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Thu, Nov 28, 2024, at 16:06, Jerome Brunet wrote: > On Thu 28 Nov 2024 at 15:51, "Arnd Bergmann" wrote: >> On Thu, Nov 28, 2024, at 15:39, Jerome Brunet wrote: >>> On Thu 28 Nov 2024 at 15:11, "Arnd Bergmann" wrote: >>> Eventually that will happen for the rest of the reset implemented >>> under drivers/clk/meson. >>> >>> It allows to make some code common between the platform reset >>> drivers and the aux ones. It also ease maintainance for both >>> Stephen and Philipp. >> >> I don't understand how this helps: the entire point of using >> an auxiliary device is to separate the lifetime rules of >> the different bits, but by doing the creation of the device >> in the same file as the implementation, you are not taking >> advantage of that at all, but instead get the complexity of >> a link-time dependency in addition to a lot of extra code >> for dealing with the additional device. > > My initial rework had the creation in clock (note: that is why I > initially used 'imply', and forgot to update when the creation moved to > reset). > > I was asked to move the creation in reset: > https://lore.kernel.org/r/217a785212d7c1a5b504c6040b3636e6.sboyd@kernel.org > > We are deviating a bit from the initial regression reported by Mark. > Is Ok with you to proceed with that fix and then continue this discussion > ? I really don't want to see those stray 'select' statements in there, as that leave very little incentive for anyone to fix it properly. It sounds like Stephen gave you bad advice for how it should be structured, so my best suggestion would be to move the the problem (and the reset driver) back into his subsystem and leave only a simple 'select RESET_CONTROLLER'. >From the message you cited, I think Stephen had the right intentions ("so that the clk and reset drivers are decoupled"), but the end result did not actually do what he intended even if you did what he asked for. Stephen, can you please take a look here and see if you have a better idea for either decoupling the two drivers enough to avoid the link time dependency, or to reintegrate the reset controller code into the clk driver and avoid the complexity? Arnd _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic