From: Guenter Roeck <linux@roeck-us.net>
To: Huqiang Qin <huqiang.qin@amlogic.com>
Cc: wim@linux-watchdog.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
neil.armstrong@linaro.org, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 3/4] watchdog: Add support for Amlogic-T7 SoCs
Date: Wed, 23 Aug 2023 08:48:39 -0700 [thread overview]
Message-ID: <ceabbef7-e952-4e74-af10-e49946cb9c62@roeck-us.net> (raw)
In-Reply-To: <20230802033222.4024946-4-huqiang.qin@amlogic.com>
On Wed, Aug 02, 2023 at 11:32:21AM +0800, Huqiang Qin wrote:
> Compared with the previous Amlogic-GXBB, the watchdog of Amlogic-T7
> has a different reset enable bit.
>
> Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
> Reviewed-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> V1 -> V2: Use the BIT() macro to build rst initial value.
>
> drivers/watchdog/meson_gxbb_wdt.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c
> index 18180d91543e..a48622d11ad7 100644
> --- a/drivers/watchdog/meson_gxbb_wdt.c
> +++ b/drivers/watchdog/meson_gxbb_wdt.c
> @@ -147,8 +147,13 @@ static const struct wdt_params gxbb_params = {
> .rst = BIT(21),
> };
>
> +static const struct wdt_params t7_params = {
> + .rst = BIT(22),
> +};
> +
> static const struct of_device_id meson_gxbb_wdt_dt_ids[] = {
> { .compatible = "amlogic,meson-gxbb-wdt", .data = &gxbb_params, },
> + { .compatible = "amlogic,t7-wdt", .data = &t7_params, },
> { /* sentinel */ },
> };
> MODULE_DEVICE_TABLE(of, meson_gxbb_wdt_dt_ids);
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-08-23 15:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 3:32 [PATCH V2 0/4] Add watchdog " Huqiang Qin
2023-08-02 3:32 ` [PATCH V2 1/4] dt-bindings: watchdog: Add " Huqiang Qin
2023-08-02 7:36 ` Dmitry Rokosov
2023-08-23 15:47 ` Guenter Roeck
2023-08-02 3:32 ` [PATCH V2 2/4] watchdog: Add a new struct for Amlogic-GXBB driver Huqiang Qin
2023-08-02 7:38 ` Dmitry Rokosov
2023-08-23 15:47 ` Guenter Roeck
2023-08-02 3:32 ` [PATCH V2 3/4] watchdog: Add support for Amlogic-T7 SoCs Huqiang Qin
2023-08-02 7:37 ` Dmitry Rokosov
2023-08-23 15:48 ` Guenter Roeck [this message]
2023-08-02 3:32 ` [PATCH V2 4/4] arm64: dts: Add watchdog node " Huqiang Qin
2023-09-11 9:46 ` (subset) [PATCH V2 0/4] Add watchdog support " Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceabbef7-e952-4e74-af10-e49946cb9c62@roeck-us.net \
--to=linux@roeck-us.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=huqiang.qin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®