From: Neil Armstrong <narmstrong@baylibre.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 1/1] mfd: khadas-mcu: Fix randconfig 'unused-const-variable' warning
Date: Fri, 28 Aug 2020 11:19:44 +0200 [thread overview]
Message-ID: <d09b2285-96b7-5c6d-02e7-73cdc5219a48@baylibre.com> (raw)
In-Reply-To: <20200828085007.2008096-1-lee.jones@linaro.org>
Hi Lee,
On 28/08/2020 10:50, Lee Jones wrote:
> When testing with !OF, the build system reports:
>
>>> drivers/mfd/khadas-mcu.c:125:34: warning: unused variable 'khadas_mcu_of_match' [-Wunused-const-variable]
> static const struct of_device_id khadas_mcu_of_match[] = {
> ^
>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/mfd/khadas-mcu.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/khadas-mcu.c b/drivers/mfd/khadas-mcu.c
> index 44d5bb462daba..f3d418810693c 100644
> --- a/drivers/mfd/khadas-mcu.c
> +++ b/drivers/mfd/khadas-mcu.c
> @@ -122,11 +122,13 @@ static int khadas_mcu_probe(struct i2c_client *client,
> return 0;
> }
>
> +#ifdef CONFIG_OF
> static const struct of_device_id khadas_mcu_of_match[] = {
> { .compatible = "khadas,mcu", },
> {},
> };
> MODULE_DEVICE_TABLE(of, khadas_mcu_of_match);
> +#endif
>
> static struct i2c_driver khadas_mcu_driver = {
> .driver = {
>
Thanks for the patch,
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2020-08-28 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 8:50 Lee Jones
2020-08-28 9:19 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d09b2285-96b7-5c6d-02e7-73cdc5219a48@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=lee.jones@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®