From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BD84C433F5 for ; Fri, 8 Apr 2022 15:22:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HJFfeSdrRzv93iFfe9k0EusIiVXl5whiBqXt+70oEC8=; b=FgNlrm40u3LO4e xMFjougGHrvME4DCke76d0MrueAc4r4MTHkIysTKTsfn/22es6+zDbLsumZpd4r69BNCZyaXhyONj HKh/6obSPisNiBDBwcCPcx5hAHTCblSuM5bAKCXH7Z0sxLeUJTOWOXihTZ/wv3AzV5z8eOZ0uwjlG iBHgDF2E4VFpk5VCbPjrf/m65cwVa1uUCEYZS9rIRweXCWLRpg14ZPFLktlFBT+FpGiZWPiAvZ6wo KFSMZWkHs0zfHNq1ZV88+YZfAIp3ygR9+tk0dZb9aHdNbUVA7WmqRIuVbIgr0OrI5RV858VxatzPS 4SnJ97oCS/VH/hOSTiDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncqRT-000Fvd-7r; Fri, 08 Apr 2022 15:22:31 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncqRP-000Fs9-Hc for linux-amlogic@lists.infradead.org; Fri, 08 Apr 2022 15:22:28 +0000 Received: by mail-wr1-x431.google.com with SMTP id r13so13392618wrr.9 for ; Fri, 08 Apr 2022 08:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=sPygLbD1B7EQ520hW5RQW4mGJJ5DO7vPlVdwf9z6NxI=; b=rnNZUmsDC25DLs3861xbnitTubGbaLpRp0g4SSNU90qrEH3Em2POjR8w4Wc+PNhH+N x2k51skqLe1F+lNYA9yvKLgAqtBISBFL6XVsgUZcRPfauhPI80VDFulZpkt5bmLpVDYY ZtcQhj39tTE2VqLciTtIybGXe+9YaHlgWcLqIkY0nOkMJZBBMOlSvxWId5Ha6vVxvmYz 7xnHdPudHX8+SFOLpTAwifky/xUbZjXnyx5436vJaaC0pZeTZxL3DQb4xvQz3KJUXv9q L9x98EaoaCIDFhQ0BAtDJvGbbNLRFinrYxieLx/dCD5jaTsZlGT4ryA5e8iHSxWZ89Kc mMPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=sPygLbD1B7EQ520hW5RQW4mGJJ5DO7vPlVdwf9z6NxI=; b=5zwgwKEgMWCLxH4nXOgbCZoz3XUW0R+vTo1KW78AwiK144zCg5ekvAur5/hk/wCREy 2CcVHIEZDcp+lD+tFrgY3zmezVDFyYimO3FpCOTVEZCtKZz+LINdOia9qYuKdsaCh/iI 4GLMd+jXQ9naPesF8yYct69+wi1fla7PvXnceX4JEqqIldXTZ4w8iv7deOVhUCtAgXhR 36tzszwkcpUOovz6yxq5eJF6H9x2Scrgw0xyznP4KoQsINfUG8zZ9EO2drZrGL1DBYoH xINYc9RzMHMt6plj599msGuIyug/Y/ysEMyaBDdVrJLppYbIgKuWFxqfkvtL0WPgVpUn jesg== X-Gm-Message-State: AOAM532q4Z/b7znt1598YhO4iI7c0ooI7tnxtuNjXxSWAyjVjNVDtRMn HYt4LfdQ4iSasxA3IQU0JULrZ4PJqSJz2WWn X-Google-Smtp-Source: ABdhPJxGPNgXgsufUjB8Lp8JJWbca8cu17Hg8qjIbnxCrticuxKM/31Uln39Sz96BlX1M76FBt7ZIw== X-Received: by 2002:a5d:6dac:0:b0:204:12ba:45ef with SMTP id u12-20020a5d6dac000000b0020412ba45efmr14920479wrs.416.1649431343717; Fri, 08 Apr 2022 08:22:23 -0700 (PDT) Received: from [192.168.0.188] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id r4-20020a1c2b04000000b0038a0e15ee13sm10714642wmr.8.2022.04.08.08.22.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Apr 2022 08:22:23 -0700 (PDT) Message-ID: Date: Fri, 8 Apr 2022 17:22:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v4 05/13] pinctrl: samsung: Switch to use for_each_gpiochip_node() helper Content-Language: en-US To: Andy Shevchenko , Qianggui Song , Geert Uytterhoeven , Marc Zyngier , Fabien Dessenne , Linus Walleij , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Cc: Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Bartosz Golaszewski , Philipp Zabel References: <20220401103604.8705-1-andriy.shevchenko@linux.intel.com> <20220401103604.8705-6-andriy.shevchenko@linux.intel.com> From: Krzysztof Kozlowski In-Reply-To: <20220401103604.8705-6-andriy.shevchenko@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220408_082227_597186_2F3E0DA6 X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 01/04/2022 12:35, Andy Shevchenko wrote: > Switch the code to use for_each_gpiochip_node() helper. > (...) > /* > * Iterate over all driver pin banks to find one matching the name of node, > * skipping optional "-gpio" node suffix. When found, assign node to the bank. > */ > -static void samsung_banks_of_node_get(struct device *dev, > - struct samsung_pinctrl_drv_data *d, > - struct device_node *node) > +static void samsung_banks_node_get(struct device *dev, struct samsung_pinctrl_drv_data *d) This is worth simplification anyway, so please split it to separate patch. > { > const char *suffix = "-gpio-bank"; > struct samsung_pin_bank *bank; > - struct device_node *child; > + struct fwnode_handle *child; > /* Pin bank names are up to 4 characters */ > char node_name[20]; > unsigned int i; > @@ -1038,17 +1037,17 @@ static void samsung_banks_of_node_get(struct device *dev, > continue; > } > > - for_each_child_of_node(node, child) { > - if (!of_find_property(child, "gpio-controller", NULL)) > - continue; This does not look equivalent. There are nodes without this property. > - if (of_node_name_eq(child, node_name)) > + for_each_gpiochip_node(dev, child) { > + struct device_node *np = to_of_node(child); > + > + if (of_node_name_eq(np, node_name)) > break; > - else if (of_node_name_eq(child, bank->name)) > + if (of_node_name_eq(np, bank->name)) > break; > } This patch has to wait till someone provides you a tested-by. I might do it around next week. Best regards, Krzysztof _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic