Re: [PATCH 1/1] dt-bindings: clock: meson: Convert axg-audio-clkc to YAML format

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
	Alexander Stein <alexander.stein@mailbox.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: clock: meson: Convert axg-audio-clkc to YAML format
Date: Thu, 10 Aug 2023 09:46:10 +0200	[thread overview]
Message-ID: <d2225b8a-a622-3936-1e43-d5a9801c2cd7@linaro.org> (raw)
In-Reply-To: <1jwmy39wfs.fsf@starbuckisacylon.baylibre.com>

On 10/08/2023 09:32, Jerome Brunet wrote:
>>>> Then why do you have this huge, apparently unnecessary, oneOf? If it's
>>>> the same, then drop the oneOf and make number of clocks fixed.
>>>
>>> But as far as I understand the number of clocks is not fixed. As Jerome pointed 
>>> out in the other post, it can have any combination of clocks and range from 1 
>>> up to 11, where 'pclk' is always 1st clock.
>>> I currently have no idea how to constraint that, despite limiting the number 
>>> of clock-names.
>>
>> The same as in all other clock controllers (was also present on my list
>> of useful patterns - Variable length arrays (per variant)):
>> https://elixir.bootlin.com/linux/v5.19-rc6/source/Documentation/devicetree/bindings/clock/samsung,exynos7-clock.yaml#L57
> 
> In the example provided, the number and list of clocks required by each
> controller variant is fixed, if I'm reading it correctly
> 
> Here the controller (regardless of the variant) accepts a maximum 29
> clock inputs. Only pclk is required. It is valid to have any of 28
> optional clocks at index 2, 3, etc ...

I actually doubt that it is optional. These are valid clock inputs. I
could imagine they are optional depending on the use-case, like some
block being turned off or on... but then still the clock is there, just
not actively used.

Aren't you now describing existing Linux driver?

> I guess the question is how do you recommend to model that ?
> I can think of 'Anyof' with all the optional clocks repeated 28 times
> but that would be fairly ugly.

Best regards,
Krzysztof

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic