From: hkallweit1@gmail.com (Heiner Kallweit)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v5 04/10] i2c: meson: use i2c core for DT clock-frequency parsing
Date: Sat, 25 Mar 2017 14:06:35 +0100 [thread overview]
Message-ID: <e051fc67-3747-b84b-220d-6a2d26c465f8@gmail.com> (raw)
In-Reply-To: <645519b8-93e6-57b1-ae8f-7804c6beb9b1@gmail.com>
We don't have to parse the DT manually to retrieve the bus frequency
and we don't have to maintain an own default for the bus frequency.
Let the i2c core do this for us.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
---
v2:
- added Reviewed-by
v3:
- changed order of patches
v4:
- update DT binding documentation
v5:
- remove unused properties from binding documentation
---
Documentation/devicetree/bindings/i2c/i2c-meson.txt | 2 ++
drivers/i2c/busses/i2c-meson.c | 8 +++-----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-meson.txt b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
index 386357d1..611b934c 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-meson.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-meson.txt
@@ -8,6 +8,8 @@ Required properties:
- #address-cells: should be <1>
- #size-cells: should be <0>
+For details regarding the following core I2C bindings see also i2c.txt.
+
Optional properties:
- clock-frequency: the desired I2C bus clock frequency in Hz; in
absence of this property the default value is used (100 kHz).
diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
index e597764e..ac0ac82d 100644
--- a/drivers/i2c/busses/i2c-meson.c
+++ b/drivers/i2c/busses/i2c-meson.c
@@ -38,7 +38,6 @@
#define REG_CTRL_CLKDIV_MASK ((BIT(10) - 1) << REG_CTRL_CLKDIV_SHIFT)
#define I2C_TIMEOUT_MS 500
-#define DEFAULT_FREQ 100000
enum {
TOKEN_END = 0,
@@ -387,15 +386,14 @@ static int meson_i2c_probe(struct platform_device *pdev)
struct device_node *np = pdev->dev.of_node;
struct meson_i2c *i2c;
struct resource *mem;
- u32 freq;
+ struct i2c_timings timings;
int irq, ret = 0;
i2c = devm_kzalloc(&pdev->dev, sizeof(struct meson_i2c), GFP_KERNEL);
if (!i2c)
return -ENOMEM;
- if (of_property_read_u32(pdev->dev.of_node, "clock-frequency", &freq))
- freq = DEFAULT_FREQ;
+ i2c_parse_fw_timings(&pdev->dev, &timings, true);
i2c->dev = &pdev->dev;
platform_set_drvdata(pdev, i2c);
@@ -453,7 +451,7 @@ static int meson_i2c_probe(struct platform_device *pdev)
return ret;
}
- meson_i2c_set_clk_div(i2c, freq);
+ meson_i2c_set_clk_div(i2c, timings.bus_freq_hz);
return 0;
}
--
2.12.0
next prev parent reply other threads:[~2017-03-25 13:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-25 12:57 [PATCH v5 00/10] i2c: meson: series with improvements Heiner Kallweit
2017-03-25 12:58 ` [PATCH v5 01/10] i2c: meson: use min instead of min_t where min_t isn't needed Heiner Kallweit
2017-03-25 13:01 ` [PATCH v5 02/10] i2c: meson: remove member irq from struct meson_i2c Heiner Kallweit
2017-03-25 13:04 ` [PATCH v5 03/10] i2c: meson: set clock divider in probe instead of setting it for each transfer Heiner Kallweit
2017-03-25 13:06 ` Heiner Kallweit [this message]
2017-03-25 13:07 ` [PATCH v5 05/10] i2c: meson: use full 12 bits for clock divider Heiner Kallweit
2017-03-25 13:09 ` [PATCH v5 06/10] i2c: meson: remove variable count from meson_i2c_xfer Heiner Kallweit
2017-03-25 13:10 ` [PATCH v5 07/10] i2c: meson: improve interrupt handler and detect spurious interrupts Heiner Kallweit
2017-03-25 13:11 ` [PATCH v5 08/10] i2c: meson: don't create separate token chain just for the stop command Heiner Kallweit
2017-03-25 13:12 ` [PATCH v5 09/10] i2c: meson: remove meson_i2c_write_tokens Heiner Kallweit
2017-03-25 13:14 ` [PATCH v5 10/10] i2c: meson: improve and simplify interrupt handler Heiner Kallweit
2017-03-30 15:56 ` [PATCH v5 00/10] i2c: meson: series with improvements Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e051fc67-3747-b84b-220d-6a2d26c465f8@gmail.com \
--to=hkallweit1@gmail.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®