mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Zhentao Guo <zhentao.guo@amlogic.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v10 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder
Date: Tue, 29 Sep 2026 17:41:18 +0800	[thread overview]
Message-ID: <e0f29358-f5e8-4bf5-83aa-dba342b49e07@amlogic.com> (raw)
In-Reply-To: <9679c161-d36c-401b-80a7-46b0524a7eaf@kernel.org>


> On 29/09/2026 10:21, Zhentao Guo wrote:
>> Hi Krzysztof,
>>
>>> On 29/09/2026 08:23, Zhentao Guo wrote:
>>>> In the previous version of this patch,
>>>> allowing one entry was simply a mistake, not an option we ever supported.
>>> I do not think it is true, please test it.
>> I re-ran the dt_binding_check against the new schema and a full
>> dtbs_check, the binding validates, its example compiles and passes, no
>> failures found.
>>
>> If there is any additional testing you would recommend, I would be glad
>> to run it.Or do you have any remaining concerns about the change? I'm
>> happy to clarify anything that is still unclear.
> So please kindly provide a proof that one entry was before allowed, how
> you claim. Remember, we speak ABOUT ONLY one thing - the quote I started
> with.

Sorry for missing your point eariler.I tested it:

With the previous version (|reg: maxItems: 2 |plus the 2-entry 
|reg-names |items list), a DTS with a single |reg |entry is rejected by 
dt_binding_check ("reg: ... is too short").

Let me clarify what I originally meant by "maxItems: 2 implies that a 
single item is also allowed" — my point was about readability, not about 
dtschema's actual validation behavior. I should have phrased it better.

Just to make sure if my understanding is right: the two items already 
listed in each |"*-names"|array imply an effective minimum of 2 for the 
properties (including regs, interrupts, power-domains), so I still need 
to specify the maxItems for them? I would greatly appreciate your 
correction if I have misunderstood this.

>> maxItems: 2 implies that a single items is also allowed,
>
> Best regards,
> Krzysztof

Best regards,

Zhentao


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2026-09-29  9:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24  7:55 [PATCH v10 0/6] Add Amlogic stateless H.264 video decoder for S4 Zhentao Guo via B4 Relay
2026-09-24  7:55 ` [PATCH v10 1/6] firmware: meson: sm: video firmware loading via secure monitor Zhentao Guo via B4 Relay
2026-09-24  7:55 ` [PATCH v10 2/6] firmware: meson: sm: Add video firmware loading SMC call Zhentao Guo via B4 Relay
2026-09-24  7:55 ` [PATCH v10 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder Zhentao Guo via B4 Relay
2026-09-24  8:01   ` sashiko-bot
2026-09-28 10:58   ` Krzysztof Kozlowski
2026-09-29  2:59     ` Zhentao Guo
2026-09-29  5:40       ` Krzysztof Kozlowski
2026-09-29  5:57         ` Zhentao Guo
2026-09-29  6:00           ` Krzysztof Kozlowski
2026-09-29  6:23             ` Zhentao Guo
2026-09-29  6:36               ` Krzysztof Kozlowski
2026-09-29  8:21                 ` Zhentao Guo
2026-09-29  8:25                   ` Krzysztof Kozlowski
2026-09-29  9:41                     ` Zhentao Guo [this message]
2026-09-24  7:55 ` [PATCH v10 4/6] decoder: Add V4L2 stateless H.264 decoder driver Zhentao Guo via B4 Relay
2026-09-24  8:16   ` sashiko-bot
2026-09-24  7:55 ` [PATCH v10 5/6] arm64: dts: amlogic: Add video decoder driver support for S4 SOCs Zhentao Guo via B4 Relay
2026-09-24  7:55 ` [PATCH v10 6/6] arm64: defconfig: Enable CONFIG_VIDEO_AMLOGIC_VDEC Zhentao Guo via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0f29358-f5e8-4bf5-83aa-dba342b49e07@amlogic.com \
    --to=zhentao.guo@amlogic.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=mchehab@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®