From: Xianwei Zhao <xianwei.zhao@amlogic.com>
To: Felix Gu <ustc.gu@gmail.com>, Liang Yang <liang.yang@amlogic.com>,
Feng Chen <feng.chen@amlogic.com>,
Mark Brown <broonie@kernel.org>
Cc: linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: amlogic: spifc-a4: Fix DMA mapping error handling
Date: Fri, 6 Mar 2026 09:42:15 +0800 [thread overview]
Message-ID: <e26d90ba-043e-40c9-ba7b-7ccdb0a37606@amlogic.com> (raw)
In-Reply-To: <20260306-spifc-a4-v1-1-f22c9965f64a@gmail.com>
On 2026/3/6 01:24, Felix Gu wrote:
> Fix three bugs in aml_sfc_dma_buffer_setup() error paths:
> 1. Unnecessary goto: When the first DMA mapping (sfc->daddr) fails,
> nothing needs cleanup. Use direct return instead of goto.
> 2. Double-unmap bug: When info DMA mapping failed, the code would
> unmap sfc->daddr inline, then fall through to out_map_data which
> would unmap it again, causing a double-unmap.
> 3. Wrong unmap size: The out_map_info label used datalen instead of
> infolen when unmapping sfc->iaddr, which could lead to incorrect
> DMA sync behavior.
>
> Fixes: 4670db6f32e9 ("spi: amlogic: add driver for Amlogic SPI Flash Controller")
> Signed-off-by: Felix Gu<ustc.gu@gmail.com>
> ---
> drivers/spi/spi-amlogic-spifc-a4.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-amlogic-spifc-a4.c b/drivers/spi/spi-amlogic-spifc-a4.c
> index 2aef528cfc1b..3956869cfec1 100644
> --- a/drivers/spi/spi-amlogic-spifc-a4.c
> +++ b/drivers/spi/spi-amlogic-spifc-a4.c
> @@ -411,7 +411,7 @@ static int aml_sfc_dma_buffer_setup(struct aml_sfc *sfc, void *databuf,
> ret = dma_mapping_error(sfc->dev, sfc->daddr);
> if (ret) {
> dev_err(sfc->dev, "DMA mapping error\n");
> - goto out_map_data;
> + return ret;
> }
>
> cmd = CMD_DATA_ADDRL(sfc->daddr);
> @@ -429,7 +429,6 @@ static int aml_sfc_dma_buffer_setup(struct aml_sfc *sfc, void *databuf,
> ret = dma_mapping_error(sfc->dev, sfc->iaddr);
> if (ret) {
> dev_err(sfc->dev, "DMA mapping error\n");
> - dma_unmap_single(sfc->dev, sfc->daddr, datalen, dir);
> goto out_map_data;
> }
>
> @@ -448,7 +447,7 @@ static int aml_sfc_dma_buffer_setup(struct aml_sfc *sfc, void *databuf,
> return 0;
>
> out_map_info:
> - dma_unmap_single(sfc->dev, sfc->iaddr, datalen, dir);
> + dma_unmap_single(sfc->dev, sfc->iaddr, infolen, dir);
> out_map_data:
> dma_unmap_single(sfc->dev, sfc->daddr, datalen, dir);
>
>
Reviewed-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
> ---
> base-commit: 3f9cd19e764b782706dbaacc69e502099cb014ba
> change-id: 20260306-spifc-a4-d40f84506d6a
>
> Best regards,
> --
> Felix Gu<ustc.gu@gmail.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-03-06 1:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 17:24 Felix Gu
2026-03-06 1:42 ` Xianwei Zhao [this message]
2026-03-06 10:05 ` Markus Elfring
2026-03-09 19:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e26d90ba-043e-40c9-ba7b-7ccdb0a37606@amlogic.com \
--to=xianwei.zhao@amlogic.com \
--cc=broonie@kernel.org \
--cc=feng.chen@amlogic.com \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ustc.gu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®