From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02225CCFA13 for ; Sun, 9 Nov 2025 16:39:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sLJhq1W9usiW3pmWp8Xjlqcf8r3ymE3Te6nlwZsFwGU=; b=2qY5QMyUsxJ2iv pBLCwmH0IL8NLpAeBOSm9aLZfmqdQGPPEZCuWLtkeAL30V7DIUQulf0Bs0HTgYlLQ3HzFsrJtF+DS aallMEmvBJeU3UcBj0rLmBkQZE95OCZwtqb007lc6WTGV7zgnVZ6HG322rLL2YLCTkOXkdviuftKp kKnPh16oceeLBK9lRWklLKWXNdf9gLOxyFOAo/9qFNnOcKOc/+zRb1iqQJ5TP5tkyaxcBz7nzBAyc 2gdKm/CUcymRjcr7D/YhTliMALdk2i1lAOj0RHxbwescskimHyd6rAzRmWkAySniTuL6+GYKPaXq/ lmQ1zgPjCKstSEaOt9rA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vI8Ra-00000004A0Q-2erD; Sun, 09 Nov 2025 16:39:10 +0000 Received: from smtpout-02.galae.net ([185.246.84.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vI8RW-000000049z4-1DJu for linux-amlogic@lists.infradead.org; Sun, 09 Nov 2025 16:39:09 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id EB0491A197F; Sun, 9 Nov 2025 16:39:00 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id BCD0D606F5; Sun, 9 Nov 2025 16:39:00 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 66E9011853189; Sun, 9 Nov 2025 17:38:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1762706339; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=ZPRMEMcp2dhUGBHSuTRmxmLz/+slEndBNL5XpFqtZ1U=; b=aIoKA3TZ8t6K+Vrshq3NfDorKiZuRejrlRcVM0UIqysbh10hoVWL/cFDQhnbe6lSgmOWR0 uarz8vGDSht8iVMcwkPYyBxJjPFdP7M6zXkR37d8DrJIdoZygxRdQq+7li1H0hHStZwqWR daNbvdSgrgRc7RjtZdrQcXdI8UR0Aph/BG+sFxJJTMPqR/sWkHAj6VUwTAXQK8OSr8e/Mr KGNYX84FHVQkFyJhxmFq51m5AWO/5263nSruhA8vU2zzrFNPt2eFYtVdJFTHqJkYsTJkpW nyIToGDmgTbgMXEt7bAePomqHPtkWBJ+w4z9jj9+8PmpuLrHiKK2RuV0GMylRw== Message-ID: Date: Sun, 9 Nov 2025 17:38:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 16/16] net: stmmac: visconti: use stmmac_get_phy_intf_sel() To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , Andrew Lunn , AngeloGioacchino Del Regno , "David S. Miller" , Emil Renner Berthing , Eric Dumazet , Jakub Kicinski , Jerome Brunet , Keguang Zhang , Kevin Hilman , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Martin Blumenstingl , Matthias Brugger , Maxime Coquelin , Minda Chen , Neil Armstrong , netdev@vger.kernel.org, Nobuhiro Iwamatsu , Paolo Abeni References: <14f80863-5766-437a-8e38-8991a1a725f9@bootlin.com> From: Maxime Chevallier Content-Language: en-US In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251109_083906_917064_B4A02F88 X-CRM114-Status: UNSURE ( 9.37 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 08/11/2025 08:58, Russell King (Oracle) wrote: > On Fri, Nov 07, 2025 at 07:23:26PM +0100, Maxime Chevallier wrote: >> Hi Russell, >> >> On 07/11/2025 15:29, Russell King (Oracle) wrote: >>> - switch (plat_dat->phy_interface) { >>> - case PHY_INTERFACE_MODE_RGMII: >>> - case PHY_INTERFACE_MODE_RGMII_ID: >>> - case PHY_INTERFACE_MODE_RGMII_RXID: >>> - case PHY_INTERFACE_MODE_RGMII_TXID: >>> - phy_intf_sel = ETHER_CONFIG_INTF_RGMII; >>> - break; >>> - case PHY_INTERFACE_MODE_MII: >>> - phy_intf_sel = ETHER_CONFIG_INTF_MII; >>> - break; >>> - case PHY_INTERFACE_MODE_RMII: >>> - phy_intf_sel = ETHER_CONFIG_INTF_RMII; >>> - break; >>> - default: >>> + int phy_intf_sel; >>> + >>> + phy_intf_sel = stmmac_get_phy_intf_sel(plat_dat->phy_interface); >>> + if (phy_intf_sel != PHY_INTF_SEL_GMII_MII && >>> + phy_intf_sel != PHY_INTF_SEL_RGMII && >>> + phy_intf_sel != PHY_INTF_SEL_RMII) { >>> dev_err(&pdev->dev, "Unsupported phy-mode (%d)\n", plat_dat->phy_interface); >>> return -EOPNOTSUPP; >>> } >> >> Probably not too big of a deal, but don't we now incorrectly accept the >> "gmii" mode ? > > We will accept GMII mode, but (a) does that matter, and (b) shouldn't > the DT binding be checking the phy-mode (we have some bindings that do.) Thanks for the clarification, that's fine by me then :) Maxime _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic