From: Mark Brown <broonie@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: lgirdwood@gmail.com,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-pwm@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Dmitry Rokosov" <ddrokosov@sberdevices.ru>
Subject: Re: [RFC PATCH v1] regulator: pwm-regulator: Fix continuous get_voltage for disabled PWM
Date: Fri, 22 Dec 2023 11:54:54 +0000 [thread overview]
Message-ID: <e32e0ccd-0e7c-4d74-aa2c-0b8155d97698@sirena.org.uk> (raw)
In-Reply-To: <CAFBinCDJnVzE2sMwu52MQGTKW7dtCuUoj63ZZHhJPJO0+dZDkg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 949 bytes --]
On Thu, Dec 21, 2023 at 11:42:29PM +0100, Martin Blumenstingl wrote:
> On Thu, Dec 21, 2023 at 10:45 PM Mark Brown <broonie@kernel.org> wrote:
> > Hrm. Perhaps the regulator should figure out that it's on with a
> > minimum voltage of 1.14V in this case - AIUI that broadly corresponds to
> > your change except for the fact that it doesn't recognise that there's
> > actually an output in this case since it assumes that disabling the PWM
> > disables the output which isn't the case with this hardware. We'd need
> > to know more about the PWM in that case though I think.
> If you have any specific questions then feel free to ask.
> Generally it's a very simple PWM controller:
> - when disabled the output is LOW
> - when enabled the output matches the requested period and duty cycle
> as best as possible (depending on the available input clocks)
We would need to know more at runtime to do the correct thing I think.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-12-22 11:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 21:12 Martin Blumenstingl
2023-12-21 21:45 ` Mark Brown
2023-12-21 22:07 ` Uwe Kleine-König
2023-12-22 11:53 ` Mark Brown
2023-12-21 22:42 ` Martin Blumenstingl
2023-12-22 11:54 ` Mark Brown [this message]
2023-12-22 12:24 ` Mark Brown
2023-12-21 22:03 ` Uwe Kleine-König
2023-12-22 0:17 ` Martin Blumenstingl
2023-12-22 7:10 ` Uwe Kleine-König
2023-12-22 10:12 ` Martin Blumenstingl
2023-12-22 10:27 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e32e0ccd-0e7c-4d74-aa2c-0b8155d97698@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ddrokosov@sberdevices.ru \
--cc=hkallweit1@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®