mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Ronald Claveau <linux-kernel-dev@aliel.fr>
To: sashiko-reviews@lists.linux.dev
Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
	linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org,
	robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org,
	vkoul@kernel.org, olteanv@gmail.com
Subject: Re: [PATCH v2 06/11] pmdomain: amlogic: meson-ee-pwrc: power up memories for boot-enabled domains
Date: Sat, 21 Nov 2026 19:57:45 +0100	[thread overview]
Message-ID: <e92bbf55-08f2-4cc0-ad08-cbbcde9f93ac@aliel.fr> (raw)
In-Reply-To: <sashiko-outbox-225878@kernel.org>

On 11/20/26 19:58, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] pmdomain: amlogic: duplicated memory power-up loop in
>   meson_ee_pwrc_on()
> --
> 
> commit a69a64ee3e13ba7f9072dbadb0f25ec3e146c336
> Author: Ronald Claveau <linux-kernel-dev@aliel.fr>
> 
> pmdomain: amlogic: meson-ee-pwrc: power up memories for boot-enabled domains
> 
> This commit introduces a helper to clear the HHI memory power-down bits
> for power domains that are found already enabled at probe time.
> 
>> diff --git a/drivers/pmdomain/amlogic/meson-ee-pwrc.c b/drivers/pmdomain/amlogic/meson-ee-pwrc.c
>> index 338f70d77bf03..404af46192562 100644
>> --- a/drivers/pmdomain/amlogic/meson-ee-pwrc.c
>> +++ b/drivers/pmdomain/amlogic/meson-ee-pwrc.c
>> @@ -428,6 +428,16 @@ static int meson_ee_pwrc_on(struct generic_pm_domain *domain)
>>  				       pwrc_domain->clks);
>>  }
>>  
>> +static void meson_ee_pwrc_mem_power_up(struct meson_ee_pwrc_domain *dom)
>> +{
>> +	int i;
>> +
>> +	for (i = 0; i < dom->desc.mem_pd_count; i++)
>> +		regmap_update_bits(dom->pwrc->regmap_hhi,
>> +				   dom->desc.mem_pd[i].reg,
>> +				   dom->desc.mem_pd[i].mask, 0);
>> +}
> 
> [Severity: Low]
> This isn't a bug, but meson_ee_pwrc_on() right above has the same loop:
> 
> drivers/pmdomain/amlogic/meson-ee-pwrc.c:meson_ee_pwrc_on() {
>     ...
> 	for (i = 0 ; i < pwrc_domain->desc.mem_pd_count ; ++i)
> 		regmap_update_bits(pwrc_domain->pwrc->regmap_hhi,
> 				   pwrc_domain->desc.mem_pd[i].reg,
> 				   pwrc_domain->desc.mem_pd[i].mask, 0);
>     ...
> }
> 
> Could meson_ee_pwrc_mem_power_up() be defined above meson_ee_pwrc_on()
> and reused there as well?
> 

Good reminder, will do it in v3.

-- 
Best regards,
Ronald

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2026-11-21 18:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 18:15 [PATCH v2 00/11] phy/drm: amlogic: Extract Meson HDMI TX PHY into a dedicated driver Ronald Claveau via B4 Relay
2026-11-20 18:15 ` [PATCH v2 01/11] dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Fix compatible matching in conditionals Ronald Claveau via B4 Relay
2026-11-20 18:15 ` [PATCH v2 02/11] dt-bindings: phy: amlogic: Add Meson HDMI TX PHY binding Ronald Claveau via B4 Relay
2026-11-20 18:15 ` [PATCH v2 03/11] dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Add hdmi-phy child node Ronald Claveau via B4 Relay
2026-11-20 18:15 ` [PATCH v2 04/11] phy: amlogic: Add Meson HDMI TX PHY driver Ronald Claveau via B4 Relay
2026-11-20 18:15 ` [PATCH v2 05/11] dt-bindings: display: amlogic,meson-dw-hdmi: Add phys Ronald Claveau via B4 Relay
2026-11-20 18:15 ` [PATCH v2 06/11] pmdomain: amlogic: meson-ee-pwrc: power up memories for boot-enabled domains Ronald Claveau via B4 Relay
2026-11-20 18:58   ` sashiko-bot
2026-11-21 18:57     ` Ronald Claveau [this message]
2026-11-20 18:15 ` [PATCH v2 07/11] drm/meson: dw-hdmi: Drop manual HHI clock and memory PD setup Ronald Claveau via B4 Relay
2026-11-20 18:15 ` [PATCH v2 08/11] drm/meson: dw-hdmi: Use the generic PHY framework for the HDMI TX PHY Ronald Claveau via B4 Relay
2026-11-20 19:20   ` sashiko-bot
2026-11-21 19:10     ` Ronald Claveau
2026-11-20 18:15 ` [PATCH v2 09/11] arm64: dts: amlogic: Add HDMI TX PHY node for G12 Ronald Claveau via B4 Relay
2026-11-20 18:15 ` [PATCH v2 10/11] arm64: dts: amlogic: Add HDMI TX PHY node for GXBB Ronald Claveau via B4 Relay
2026-11-20 18:15 ` [PATCH v2 11/11] arm64: dts: amlogic: Add HDMI TX PHY node for GXL Ronald Claveau via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e92bbf55-08f2-4cc0-ad08-cbbcde9f93ac@aliel.fr \
    --to=linux-kernel-dev@aliel.fr \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®