mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Liang Yang <liang.yang@amlogic.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Jianxin Pan <jianxin.pan@amlogic.com>,
	Yixun Lan <yixun.lan@amlogic.com>,
	<linux-mtd@lists.infradead.org>,
	<linux-amlogic@lists.infradead.org>,
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] mtd: rawnand: meson: fix bit map use in meson_nfc_ecc_correct()
Date: Wed, 3 Aug 2022 19:13:25 +0800	[thread overview]
Message-ID: <e954f248-614b-5f59-b6c3-13d67575c416@amlogic.com> (raw)
In-Reply-To: <YuI2zF1hP65+LE7r@kili>

Hi Dan,

Thanks.

On 2022/7/28 15:12, Dan Carpenter wrote:
> [ EXTERNAL EMAIL ]
> 
> The meson_nfc_ecc_correct() function accidentally does a right shift
> instead of a left shift so it only works for BIT(0).  Also use
> BIT_ULL() because "correct_bitmap" is a u64 and we want to avoid
> shift wrapping bugs.
> 
> Fixes: 8fae856c5350 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>>From review.  Untested.
> 
>   drivers/mtd/nand/raw/meson_nand.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> index 829b76b303aa..ad2ffd0ca800 100644
> --- a/drivers/mtd/nand/raw/meson_nand.c
> +++ b/drivers/mtd/nand/raw/meson_nand.c
> @@ -454,7 +454,7 @@ static int meson_nfc_ecc_correct(struct nand_chip *nand, u32 *bitflips,
>   		if (ECC_ERR_CNT(*info) != ECC_UNCORRECTABLE) {
>   			mtd->ecc_stats.corrected += ECC_ERR_CNT(*info);
>   			*bitflips = max_t(u32, *bitflips, ECC_ERR_CNT(*info));
> -			*correct_bitmap |= 1 >> i;
> +			*correct_bitmap |= BIT_ULL(i);
>   			continue;
>   		}
>   		if ((nand->options & NAND_NEED_SCRAMBLING) &&
> @@ -800,7 +800,7 @@ static int meson_nfc_read_page_hwecc(struct nand_chip *nand, u8 *buf,
>   			u8 *data = buf + i * ecc->size;
>   			u8 *oob = nand->oob_poi + i * (ecc->bytes + 2);
>   
> -			if (correct_bitmap & (1 << i))
> +			if (correct_bitmap & BIT_ULL(i))
>   				continue;
>   			ret = nand_check_erased_ecc_chunk(data,	ecc->size,
>   							  oob, ecc->bytes + 2,

Acked-by: Liang Yang <liang.yang@amlogic.com>

Thanks,
Liang

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2022-08-03 11:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28  7:12 Dan Carpenter
2022-08-03 11:13 ` Liang Yang [this message]
2022-09-20  8:10 ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e954f248-614b-5f59-b6c3-13d67575c416@amlogic.com \
    --to=liang.yang@amlogic.com \
    --cc=dan.carpenter@oracle.com \
    --cc=jbrunet@baylibre.com \
    --cc=jianxin.pan@amlogic.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=narmstrong@baylibre.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=yixun.lan@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®