From mboxrd@z Thu Jan 1 00:00:00 1970 From: narmstrong@baylibre.com (Neil Armstrong) Date: Fri, 23 Nov 2018 14:15:44 +0100 Subject: [PATCH] drm/meson: add support for 1080p25 mode In-Reply-To: References: <1542793169-13008-1-git-send-email-christianshewitt@gmail.com> <2a9d9fa9-c9ba-c624-28da-dd3804faf438@baylibre.com> Message-ID: To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org Hi Michal, On 23/11/2018 13:57, Michal Lazo wrote: > I would suggest same aproach as for > "meson_hdmi_encp_mode_1080p30" > and "meson_hdmi_encp_mode_1080p60" > > so duplicate "meson_hdmi_encp_mode_1080p50" > with name "meson_hdmi_encp_mode_1080p25" The configs are litterally the same for 1080p25 and 1080p60 unlike 1080p30/1080p60, so I don't see the point about duplicating a same table for the sake of naming. We will the exact same thing to support the 2160p50/2160p60 modes by reusing the same config are 2160p25/2160p50, and I don't see the point of duplication the tables here aswell. Neil > > now the code looks really like common copy paste problem > Michal Lazo > On Wed, Nov 21, 2018 at 10:47 AM Neil Armstrong wrote: >> >> On 21/11/2018 10:39, Christian Hewitt wrote: >>> This essential mode for PAL users is missing, so add it. >>> >>> Signed-off-by: Christian Hewitt >>> --- >>> drivers/gpu/drm/meson/meson_venc.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c >>> index acbbad3..ab16046 100644 >>> --- a/drivers/gpu/drm/meson/meson_venc.c >>> +++ b/drivers/gpu/drm/meson/meson_venc.c >>> @@ -714,6 +714,7 @@ struct meson_hdmi_venc_vic_mode { >>> { 5, &meson_hdmi_encp_mode_1080i60 }, >>> { 20, &meson_hdmi_encp_mode_1080i50 }, >>> { 32, &meson_hdmi_encp_mode_1080p24 }, >>> + { 33, &meson_hdmi_encp_mode_1080p50 }, >>> { 34, &meson_hdmi_encp_mode_1080p30 }, >>> { 31, &meson_hdmi_encp_mode_1080p50 }, >>> { 16, &meson_hdmi_encp_mode_1080p60 }, >>> >> >> Exact, I forgot this mode... >> >> Thanks for the change ! >> >> Acked-by: Neil Armstrong >> >> I'll add : >> Fixes: 335e3713afb87 ("drm/meson: Add support for HDMI venc modes and settings") >> when applying to drm-misc-fixes. >> >> Neil >> >> _______________________________________________ >> linux-amlogic mailing list >> linux-amlogic at lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-amlogic > > >