From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
Thierry Reding <thierry.reding@gmail.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Kevin Hilman <khilman@baylibre.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-pwm@vger.kernel.org,
JunYi Zhao <junyi.zhao@amlogic.com>
Subject: Re: [PATCH v2 6/6] arm64: dts: amlogic: migrate pwms to new meson8 v2 binding
Date: Wed, 22 Nov 2023 09:41:06 +0100 [thread overview]
Message-ID: <eb95e27d-f408-4e25-bd53-37ff88474537@linaro.org> (raw)
In-Reply-To: <20231117125919.1696980-7-jbrunet@baylibre.com>
On 17/11/2023 13:59, Jerome Brunet wrote:
> Update Amlogic based SoC PWMs to meson8-pwm-v2 compatible
Please write proper commit msgs.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
...
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi
> index 18f7b730289e..690552e5a104 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi
> @@ -237,8 +237,6 @@ &pwm_ef {
> status = "okay";
> pinctrl-0 = <&pwm_e_pins>;
> pinctrl-names = "default";
> - clocks = <&clkc CLKID_FCLK_DIV4>;
> - clock-names = "clkin0";
> };
>
> &saradc {
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index 2673f0dbafe7..bf00672b9009 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -329,14 +329,14 @@ i2c_A: i2c@8500 {
> };
>
> pwm_ab: pwm@8550 {
> - compatible = "amlogic,meson-gx-pwm", "amlogic,meson-gxbb-pwm";
> + compatible = "amlogic,meson8-pwm-v2";
This is just wrong. NAK.
Replacing specific and correct (nothing in commit msg said these are
incorrect!) compatibles with generic, unspecific one is a no-go. It does
not make sense to replace correct code with incorrect...
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2023-11-22 8:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 12:59 [PATCH v2 0/6] pwm: meson: dt-bindings fixup Jerome Brunet
2023-11-17 12:59 ` [PATCH v2 1/6] dt-bindings: pwm: amlogic: fix s4 bindings Jerome Brunet
2023-11-19 16:04 ` Rob Herring
2023-11-17 12:59 ` [PATCH v2 2/6] dt-bindings: pwm: amlogic: add new compatible for meson8 pwm type Jerome Brunet
2023-11-19 16:05 ` Rob Herring
2023-11-20 8:27 ` Neil Armstrong
2023-11-20 9:18 ` Jerome Brunet
2023-11-20 9:55 ` neil.armstrong
2023-11-20 10:04 ` Jerome Brunet
2023-11-22 8:37 ` Krzysztof Kozlowski
2023-11-22 14:34 ` Jerome Brunet
2023-11-22 15:04 ` Krzysztof Kozlowski
2023-11-22 15:23 ` Jerome Brunet
2023-11-22 15:46 ` Krzysztof Kozlowski
2023-11-22 16:14 ` Jerome Brunet
2023-11-22 18:09 ` Krzysztof Kozlowski
2023-11-17 12:59 ` [PATCH v2 3/6] pwm: meson: prepare addition of new compatible types Jerome Brunet
2023-11-17 12:59 ` [PATCH v2 4/6] pwm: meson: add generic compatible for meson8 to sm1 Jerome Brunet
2023-11-17 12:59 ` [PATCH v2 5/6] arm: dts: amlogic: migrate pwms to new meson8 v2 binding Jerome Brunet
2023-11-22 8:39 ` Krzysztof Kozlowski
2023-11-22 14:52 ` Jerome Brunet
2023-11-22 15:10 ` Krzysztof Kozlowski
2023-11-17 12:59 ` [PATCH v2 6/6] arm64: " Jerome Brunet
2023-11-22 8:41 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb95e27d-f408-4e25-bd53-37ff88474537@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=junyi.zhao@amlogic.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®