From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF875D167FB for ; Fri, 9 Jan 2026 10:13:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ShnUlCCnr72DoN5n0UgZdWNUIavqtJCiJd09UjPUN5Q=; b=az9S89Sj1qbUkeDaHNswN2FUhz SYyuaB9fWLYrG467d/qCM1RPG8J+0BJw+ErSKijqGER5qdbSnYcbse6YYfh26nuCYdu+6rCCsYiE2 lAvDF2IE+we/EqjtnZFC515OiBn6AQ42nnfUqUwA7dBGyU9+8cLDmCFjK5XtWwq6F3pcC2OBOqrOq mSzk47nGjJ5gxRksKBbiqDqJE6yyk+x3/SXc4avRJgLesmSvtdnqg2j0pRzk+q+2slUQVrem8lJFZ S5lqpKJ6A/S9b4UwC67eimK2oIXdcvN6Jcj8cx0IUKFtaUMz5vWkI05O/Mp1+qVDvHirLzObMu44h icVjowqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ve9Uq-000000026ek-40qf; Fri, 09 Jan 2026 10:13:32 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ve9Un-000000026dS-3u5z for linux-amlogic@lists.infradead.org; Fri, 09 Jan 2026 10:13:31 +0000 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-432d2c96215so1184708f8f.3 for ; Fri, 09 Jan 2026 02:13:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767953607; x=1768558407; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=azmATrh1ehd50qg4sLH5mbIDJwpy+FR7iJS1nCS0pn0=; b=dK92hhUSBpk1eTdTeovHqDPx80bXn/D3xQX8ashm6kWIdwYm7hdsB3pfFpV0LzJ1p5 qchyUtmvi+U6LsHR0N+z7FVoKzIZpQzAX6jEnOsaF/3IqdheVHQZ/5bQP7diO8UHbXop WFvp1K3OB4Ao7Dlm4KT2fjECJLn93yQW2jbbzoLDeSGjmxZzQsVg7va6fEKlFdnlsoxq Gi5Yaq9nD6rpkIW05jzrNoyR2beD6A4LApBE189IgFgG9deqs0m6TjOOqwnbcNuHkLq7 P58vAoP+Q3lhFB4Z2nvoCiu0QqrFomxsHQ2rVa/I5kygoEBvBeJ2sikbJzB7tNWq7fQ4 SV4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767953607; x=1768558407; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=azmATrh1ehd50qg4sLH5mbIDJwpy+FR7iJS1nCS0pn0=; b=XjoGLOoiTjSTrDOYE1SgsDSyGPODDoD5gYnGmI0ZhumOh2jCPnEP+Oal6PCmP5851V NILVS+UeI0o7HsEy6ovDGWUVCErq/9AERP56F46RUYOkxFyEi2INMIB9E+7uan/exIGh hyy8kJ0KvEIMm0ORyLl2m31aiSJXKE2a4kedXb2BBPRu8fhS18MkQ7BalM3AGQN0pqZl kiuLsdMYZg63dTgqvXct+f+QykeLcFAuPjgnb985Yvj+vNeEoqBIfcJLxmIPKDcliaYU VosCkSlb8A14BS455QwylSw4cXSOo7I7Vis1kq3M+X4cZ+tDxDeTK5YIpXuZqsdv6Zvn kdgQ== X-Forwarded-Encrypted: i=1; AJvYcCUF9A4dyNLRKKi+OowhYwu+S6bOlCKRTKcpYOxXr6jFKArD0Jkni1qUcOD7xira2w1hw9Qd1qdU4/HrgkUB@lists.infradead.org X-Gm-Message-State: AOJu0YxEloVfwgyAtA4yYY8cDygLohmBfxuIGYcjcpIz4cjLM9QKzFDx wrFpQi19JAF7tx1+3Cj1F+0xu+GS0zYFEpFKBETG6JbFMhCnT6EuCOKu1yKs+A62nNk= X-Gm-Gg: AY/fxX6L9SPdYuW2iOAZYvkpVaQLanxZVsuHyMmKSIDYkuL9/GmNrE9MPJ4RwY1EGdU CmZ1dlu4UqdyCgxFeHU+KPaLeAcvRCl5ZT+UjKPN+zQUSdJQOjkIFP/UqreQu6yvFbISHSVDq3p XRcsBpwiYe1Q10gTTJWkqxm/dmbFj8/EbNckxbcyYUygAb2sDJ8w0F+joirKEsrCuZuvkI2M/zf ThOUVBIu+R9Q83nhpvQ2NtBeFPYAfSa4XjTCTbCAn+W4qjUugRZlGTx1f5RMEDcb4UcnfpJYfEm LaJYD1JJEn4N43YMTS582nwFQCli53LaIM1hZDGoQJXxVqz9LCgFevQIxkLpVIZNcjPo5nt7WYe Q3GRzq73e+B9tXs4ZzicMFibaUcxcsoBs/ZdwyIoo7YZkBUu4fKci07sCt5hrSE5ClwoeYT6StG 1jqjOq7aufGArAinAIw3J9T7Ii5JT69Fp4CrLPL2AmgpnuGB6OUtzv9ReHnFNCSNM= X-Google-Smtp-Source: AGHT+IFCikJ03J/WgyrsSQPwxIM5AkWewsU7YWY0NL1QPgGkyLNv66hXXYzshWOTAsB92VRUvv8j1A== X-Received: by 2002:a5d:5f94:0:b0:432:5bac:3915 with SMTP id ffacd0b85a97d-432c37c87e4mr11007824f8f.39.1767953607247; Fri, 09 Jan 2026 02:13:27 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:d283:7a7e:4c57:678d? ([2a01:e0a:3d9:2080:d283:7a7e:4c57:678d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e175csm21370007f8f.14.2026.01.09.02.13.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jan 2026 02:13:26 -0800 (PST) Message-ID: Date: Fri, 9 Jan 2026 11:13:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH v2 2/6] drm/meson/dw-hdmi: convert to of_drm_find_and_get_bridge() To: Luca Ceresoli , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Matthias Brugger , AngeloGioacchino Del Regno , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm Cc: Marek Szyprowski , Hui Pu , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20260109-drm-bridge-alloc-getput-drm_of_find_bridge-3-v2-0-8d7a3dbacdf4@bootlin.com> <20260109-drm-bridge-alloc-getput-drm_of_find_bridge-3-v2-2-8d7a3dbacdf4@bootlin.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260109-drm-bridge-alloc-getput-drm_of_find_bridge-3-v2-2-8d7a3dbacdf4@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260109_021330_004091_512993AB X-CRM114-Status: GOOD ( 17.31 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 1/9/26 11:02, Luca Ceresoli wrote: > of_drm_find_bridge() is deprecated. Move to its replacement > of_drm_find_and_get_bridge() which gets a bridge reference, and ensure it > is put when done. > > dw_hdmi->bridge is used only in dw_hdmi_top_thread_irq(), so in order to > avoid potential use-after-free ensure the irq is freed before putting the > dw_hdmi->bridge reference. > > Acked-by: Maxime Ripard > Signed-off-by: Luca Ceresoli > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c > index 0d7c68b29dff..fef1702acb14 100644 > --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c > @@ -778,7 +778,7 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > if (IS_ERR(meson_dw_hdmi->hdmi)) > return PTR_ERR(meson_dw_hdmi->hdmi); > > - meson_dw_hdmi->bridge = of_drm_find_bridge(pdev->dev.of_node); > + meson_dw_hdmi->bridge = of_drm_find_and_get_bridge(pdev->dev.of_node); > > DRM_DEBUG_DRIVER("HDMI controller initialized\n"); > > @@ -789,8 +789,12 @@ static void meson_dw_hdmi_unbind(struct device *dev, struct device *master, > void *data) > { > struct meson_dw_hdmi *meson_dw_hdmi = dev_get_drvdata(dev); > + struct platform_device *pdev = to_platform_device(dev); > + int irq = platform_get_irq(pdev, 0); > > + devm_free_irq(dev, irq, meson_dw_hdmi); > dw_hdmi_unbind(meson_dw_hdmi->hdmi); > + drm_bridge_put(meson_dw_hdmi->bridge); > } > > static const struct component_ops meson_dw_hdmi_ops = { > Acked-by: Neil Armstrong Thanks, Neil _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic