From: Xianwei Zhao <xianwei.zhao@amlogic.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Da Xue <da@libre.computer>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: amlogic: gxl: set i2c bias to pull-up
Date: Mon, 28 Apr 2025 10:36:45 +0800 [thread overview]
Message-ID: <ef96c3a2-f1ab-4615-8f7f-43050718e2df@amlogic.com> (raw)
In-Reply-To: <CAFBinCCUQizs=XWq7knm-4=3=hzPDNee9RZj9LDD2Mi6DHYBrQ@mail.gmail.com>
Hi Martin,
On 2025/4/28 05:08, Martin Blumenstingl wrote:
> [ EXTERNAL EMAIL ]
>
> On Fri, Apr 25, 2025 at 10:31 PM Da Xue <da@libre.computer> wrote:
>>
>> GXL I2C pins need internal pull-up enabled to operate if there
>> is no external resistor. The pull-up is 60kohms per the datasheet.
>>
>> We should set the bias when i2c pinmux is enabled.
>>
>> Signed-off-by: Da Xue <da@libre.computer>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> +Xianwei Zhao (who has recently upstreamed Amlogic A4 pinctrl support).
> I suspect we need a similar change for all other (Meson8, Meson8b,
> GXBB, G12A, ...) SoCs as well.
> Can you confirm this? And if not, why does only GXL need this special treatment?
>
The A4 pinctrl driver mainly differs in the implementation method, and
the differences between chips are primarily described in the DTS, rather
than requiring the submission of bindings and code each time a new SoC
pinctrl driver support is added. In theory, previous chips could also be
supported by new drivers.
>
> Best regards,
> Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2025-04-28 2:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 20:31 Da Xue
2025-04-27 21:08 ` Martin Blumenstingl
2025-04-28 2:36 ` Xianwei Zhao [this message]
2025-04-28 2:46 ` Da Xue
2025-04-28 7:32 ` Neil Armstrong
2025-04-29 2:08 ` Da Xue
2025-05-04 21:03 ` Martin Blumenstingl
2025-05-05 12:27 ` neil.armstrong
2025-05-05 12:36 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef96c3a2-f1ab-4615-8f7f-43050718e2df@amlogic.com \
--to=xianwei.zhao@amlogic.com \
--cc=conor+dt@kernel.org \
--cc=da@libre.computer \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®