From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F380C3A5A2 for ; Tue, 3 Sep 2019 08:16:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FF2822CF8 for ; Tue, 3 Sep 2019 08:16:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MDtYPoqH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FF2822CF8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wlzLI2QhXK419KqEbz1iWzB25GRBWW+ly9Vay8WTFB4=; b=MDtYPoqHaIriIO BsC1KzLcCxL81+OepHF1JxR+o4NiV7aahDQ2SP6kQQbRtY66Z79fTLic5dOzxwgwP6GC7ja7Q18uH aQ44JioClgSxtxBm/D97s0xK2hicacew1QwKICG8u8PzHj8rpTJfFNpwhYhRWBTOhnlwhEbYRzpvc LBbB0INm3VCrP/qXzvxUIdQ+muhQJwwZu6uo4ioWAJAOrGO8sEXu3KT6f8FYG2EcO1awS84/pSO9V T5glYQz98U6QfwWMNbdp4F9aRbRJUnPaAXDU/IolkJtVOQbKV5lljd4obBNi1N4z+7XLrnfaUe8FF IzNoLcgiG5PYU2i3Eedw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i53zE-0002D5-CY; Tue, 03 Sep 2019 08:16:24 +0000 Received: from mail-sh.amlogic.com ([58.32.228.43]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i53z0-00022E-9A; Tue, 03 Sep 2019 08:16:11 +0000 Received: from [10.18.29.226] (10.18.29.226) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Tue, 3 Sep 2019 16:16:57 +0800 Subject: Re: [PATCH 4/4] arm64: dts: add support for A1 based Amlogic AD401 To: Neil Armstrong , Kevin Hilman , References: <1567493475-75451-1-git-send-email-jianxin.pan@amlogic.com> <1567493475-75451-5-git-send-email-jianxin.pan@amlogic.com> <97a462d6-d98e-f778-96d5-bacd4801df6b@baylibre.com> From: Jianxin Pan Message-ID: Date: Tue, 3 Sep 2019 16:16:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <97a462d6-d98e-f778-96d5-bacd4801df6b@baylibre.com> Content-Language: en-US X-Originating-IP: [10.18.29.226] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190903_011610_326707_15851455 X-CRM114-Status: GOOD ( 12.12 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Hanjie Lin , Victor Wan , Martin Blumenstingl , linux-kernel@vger.kernel.org, Qiufang Dai , Rob Herring , Jian Hu , Xingyu Chen , Carlo Caione , Tao Zeng , linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Neil, Thanks for your time. Please see my comments below. On 2019/9/3 15:42, Neil Armstrong wrote: > Hi, > > On 03/09/2019 08:51, Jianxin Pan wrote: >> Add basic support for the Amlogic A1 based Amlogic AD401 board: >> which describe components as follows: Reserve Memory, CPU, GIC, IRQ, [...] >> + chosen { >> + stdout-path = "serial0:115200n8"; >> + }; >> + memory@0 { >> + device_type = "memory"; >> + linux,usable-memory = <0x0 0x0 0x0 0x8000000>; > > I'll prefer usage of reg, it's handled the same but linux,usable-memory > is not documented. > OK, I will fix it in the next version. Thanks for your review. >> + }; >> +}; >> + >> +&uart_AO_B { >> + status = "okay"; >> + /*pinctrl-0 = <&uart_ao_a_pins>;*/ >> + /*pinctrl-names = "default";*/ > > Please remove these lines instead of commenting them. > OK, I will fix it in the next version. >> +}; >> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi >> new file mode 100644 >> index 00000000..b98d648 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi >> @@ -0,0 +1,121 @@ >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> +/* >> + * Copyright (c) 2019 Amlogic, Inc. All rights reserved. >> + */ >> + >> +#include >> +#include >> + >> +/ { [...] >> + >> + reserved-memory { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; > > Isn't there secmon reserved memory ? > A1 uses internal SRAM as secmon memory. And there is no secmon reserved memory in ddr side. >> + >> + linux,cma { >> + compatible = "shared-dma-pool"; >> + reusable; >> + size = <0x0 0x800000>; [...] >> > > Thanks, > Neil > > . > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic