From: Thomas Zimmermann <tzimmermann@suse.de>
To: Carlo Caione <ccaione@baylibre.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Mark Brown <broonie@kernel.org>, Daniel Vetter <daniel@ffwll.ch>,
David Airlie <airlied@gmail.com>,
Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 1/2] drm/tiny: ili9486: Enable driver module autoloading
Date: Mon, 2 Jan 2023 11:33:23 +0100 [thread overview]
Message-ID: <f130dcb9-6fe5-965c-c8fc-03b00f63dc62@suse.de> (raw)
In-Reply-To: <20221116-s905x_spi_ili9486-v4-1-f86b4463b9e4@baylibre.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1258 bytes --]
Hi
Am 19.12.22 um 10:02 schrieb Carlo Caione:
> SPI devices use the spi_device_id for module autoloading even on
> systems using device tree.
>
> Add the spi_device_id entry to enable autoloading for the 3.5inch RPi
> Display (rpi-lcd-35 and piscreen).
>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> ---
> drivers/gpu/drm/tiny/ili9486.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c
> index 1bb847466b10..8bf0dca0b05d 100644
> --- a/drivers/gpu/drm/tiny/ili9486.c
> +++ b/drivers/gpu/drm/tiny/ili9486.c
> @@ -183,6 +183,8 @@ MODULE_DEVICE_TABLE(of, ili9486_of_match);
>
> static const struct spi_device_id ili9486_id[] = {
> { "ili9486", 0 },
> + { "rpi-lcd-35", 0 },
> + { "piscreen", 0 },
Alphabetical sorting please.
With that:
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Best regards
Thomas
> { }
> };
> MODULE_DEVICE_TABLE(spi, ili9486_id);
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-01-02 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 9:02 [PATCH v4 0/2] Make ILI9486 driver working with 16-bits SPI controllers Carlo Caione
2022-12-19 9:02 ` [PATCH v4 1/2] drm/tiny: ili9486: Enable driver module autoloading Carlo Caione
2023-01-02 10:33 ` Thomas Zimmermann [this message]
2022-12-19 9:02 ` [PATCH v4 2/2] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers Carlo Caione
2022-12-19 13:43 ` [PATCH v4 0/2] Make ILI9486 driver working with 16-bits " Neil Armstrong
2023-01-02 10:03 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f130dcb9-6fe5-965c-c8fc-03b00f63dc62@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=broonie@kernel.org \
--cc=ccaione@baylibre.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbrunet@baylibre.com \
--cc=kamlesh.gurudasani@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®