From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14334C2BA83 for ; Wed, 12 Feb 2020 07:33:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCEF1206DB for ; Wed, 12 Feb 2020 07:33:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a0H3/BaC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCEF1206DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BzUAvWjF6G8VJJficfTgOw8QaPW7x0HcPZ9H7m/Ucuw=; b=a0H3/BaCBgRb2Z Lr3eqfeNesH6Pw4IRbG1kFoNmWbN4AV0+QUGR1Ez3KMFvIioaS4iryaoHAosVKvCZq7ZF3ldpJCY/ a75uodMP+bPXJVMM57cud88E+WqMOSm3bLLTuJ/Z9q9vtgdE37KGlTMNTtVRaroFl//M5LJUEJ3jJ ktgoMJCeiISAQK0sDi1xMiiFUbXk2ViCB+PJVAj13red4l3JeH2NlQPBegP8RfHq5MrI4VsNrOS4C xRWi4ZpQiJTu0+chfN12TmklXh+BmyIki3UjWGcngZsgtWngbdl+f0yBDeQd31SWme6sVb6Wx8oGC QQrr5tjMOO0iEq1W+Bvw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1mWO-0003WR-G6; Wed, 12 Feb 2020 07:33:20 +0000 Received: from mail-sh.amlogic.com ([58.32.228.43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1mWM-0003Vt-5P; Wed, 12 Feb 2020 07:33:19 +0000 Received: from [10.18.90.120] (10.18.90.120) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Wed, 12 Feb 2020 15:33:42 +0800 Subject: Re: [PATCH v8 1/3] dt-bindings: phy: Add Amlogic A1 USB2 PHY Bindings To: Jerome Brunet , Kishon Vijay Abraham I , Neil Armstrong , Rob Herring , Greg Kroah-Hartman , Kevin Hilman References: <1581419454-12667-1-git-send-email-hanjie.lin@amlogic.com> <1581419454-12667-2-git-send-email-hanjie.lin@amlogic.com> <1jpnelb9pe.fsf@starbuckisacylon.baylibre.com> From: Hanjie Lin Message-ID: Date: Wed, 12 Feb 2020 15:33:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <1jpnelb9pe.fsf@starbuckisacylon.baylibre.com> Content-Language: en-US X-Originating-IP: [10.18.90.120] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200211_233318_212005_52ED0572 X-CRM114-Status: UNSURE ( 9.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Victor Wan , Jianxin Pan , Stephen Boyd , Michael Turquette , linux-usb@vger.kernel.org, Yue Wang , Martin Blumenstingl , Liang Yang , Qiufang Dai , Xingyu Chen , Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jian Hu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 2020/2/11 20:16, Jerome Brunet wrote: > > On Tue 11 Feb 2020 at 12:10, Hanjie Lin wrote: > >> Add the Amlogic A1 Family USB2 PHY Bindings >> >> It supports Host mode only. >> >> Signed-off-by: Yue Wang >> Signed-off-by: Hanjie Lin >> Reviewed-by: Rob Herring >> --- >> .../bindings/phy/amlogic,meson-g12a-usb2-phy.yaml | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-g12a-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-g12a-usb2-phy.yaml >> index 57d8603..3b7e763 100644 >> --- a/Documentation/devicetree/bindings/phy/amlogic,meson-g12a-usb2-phy.yaml >> +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-g12a-usb2-phy.yaml >> @@ -14,6 +14,7 @@ properties: >> compatible: >> enum: >> - amlogic,meson-g12a-usb2-phy >> + - amlogic,meson-a1-usb2-phy >> >> reg: >> maxItems: 1 >> @@ -49,6 +50,20 @@ required: >> - reset-names >> - "#phy-cells" >> >> +allOf: > > Is 'allOf' really needed when there is only one if clause ? > Hi jerome: Yes, this 'allOf' is not necessary here. I will remove it. Thanks, Hanjie >> + - if: >> + properties: >> + compatible: >> + enum: >> + - amlogic,meson-a1-usb-ctrl >> + >> + then: >> + properties: >> + power-domains: >> + maxItems: 1 >> + required: >> + - power-domains >> + >> examples: >> - | >> phy@36000 { > > . > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic