From: Neil Armstrong <narmstrong@baylibre.com>
To: "tangbin@cmss.chinamobile.com" <tangbin@cmss.chinamobile.com>,
clabbe <clabbe@baylibre.com>,
herbert <herbert@gondor.apana.org.au>,
davem <davem@davemloft.net>
Cc: linux-amlogic <linux-amlogic@lists.infradead.org>,
linux-crypto <linux-crypto@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto:amlogic - use platform_get_irq_optional()
Date: Thu, 2 Apr 2020 17:35:42 +0200 [thread overview]
Message-ID: <f4cb309e-a873-5529-5be2-6992f7d89a96@baylibre.com> (raw)
In-Reply-To: <202004022329105659148@cmss.chinamobile.com>
Hi,
On 02/04/2020 17:29, tangbin@cmss.chinamobile.com wrote:
> Dear Neil：
> Thank you for your replay，maybe my description is not so clear。What I want to say is：In this place, when something goes wrong, platform_get_irq() will print an error message, and this function will print both，so if we want to avoid the situation of repeat output，we can remove dev_err() here or use platform_get_irq_optional() instead of platform_get_irq()。Thank you very much。
Please do not top-post.
Since the irq is not optional, removing the dev_err() is the right way to go.
Neil
>
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>
> *From:* Neil Armstrong <mailto:narmstrong@baylibre.com>
> *Date:* 2020-04-02 21:26
> *To:* Tang Bin <mailto:tangbin@cmss.chinamobile.com>; clabbe <mailto:clabbe@baylibre.com>; herbert <mailto:herbert@gondor.apana.org.au>; davem <mailto:davem@davemloft.net>
> *CC:* linux-amlogic <mailto:linux-amlogic@lists.infradead.org>; linux-crypto <mailto:linux-crypto@vger.kernel.org>; linux-kernel <mailto:linux-kernel@vger.kernel.org>
> *Subject:* Re: [PATCH] crypto:amlogic - use platform_get_irq_optional()
> Hi,
>
> On 02/04/2020 13:33, Tang Bin wrote:
> > In order to simply code,because platform_get_irq() already has
> > dev_err() message.
> >
> > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> > ---
> > drivers/crypto/amlogic/amlogic-gxl-core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
> > index 9d4ead2f7..37901bd81 100644
> > --- a/drivers/crypto/amlogic/amlogic-gxl-core.c
> > +++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
> > @@ -252,7 +252,7 @@ static int meson_crypto_probe(struct platform_device *pdev)
> >
> > mc->irqs = devm_kcalloc(mc->dev, MAXFLOW, sizeof(int), GFP_KERNEL);
> > for (i = 0; i < MAXFLOW; i++) {
> > - mc->irqs[i] = platform_get_irq(pdev, i);
> > + mc->irqs[i] = platform_get_irq_optional(pdev, i);
> > if (mc->irqs[i] < 0) {
> > dev_err(mc->dev, "Cannot get IRQ for flow %d\n", i);
> > return mc->irqs[i];
> >
>
> NACK, the irq is not optional, I don't see why platform_get_irq_optional() should be used here
> and how it could "simply code".
>
> Neil
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2020-04-02 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 11:33 Tang Bin
2020-04-02 13:26 ` Neil Armstrong
[not found] ` <202004022329105659148@cmss.chinamobile.com>
2020-04-02 15:35 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4cb309e-a873-5529-5be2-6992f7d89a96@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®