mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] drm/meson: Fixes for drm_crtc_vblank_on/off support
Date: Thu, 22 Nov 2018 11:15:21 +0100	[thread overview]
Message-ID: <f8cd32d4-6475-ae07-edf8-9f458279d0e0@baylibre.com> (raw)
In-Reply-To: <20181121171525.6593-1-narmstrong@baylibre.com>

On 21/11/2018 18:15, Neil Armstrong wrote:
> Since Linux 4.17, calls to drm_crtc_vblank_on/off are mandatory, and we get
> a warning when ctrc is disabled :
> " driver forgot to call drm_crtc_vblank_off()"
> 
> But, the vsync IRQ was not totally disabled due the transient hardware
> state and specific interrupt line thus adding proper IRQ masking from
> the HHI system control registers.
> 
> Finally, due to changed in the atomic_disable code path with the updated
> fbdev emulation, checking the crct state with an atomic_disable call
> leads to warning in further atomic_begin() with a leftover event not cleared.
> 
> To Summarize :
> - Make sure that the CRTC code will call the enable/disable_vblank hooks.
> - *Really* mask the Vsync IRQ
> - Allways consume the state event in atomic_disable()
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  drivers/gpu/drm/meson/meson_crtc.c | 6 +++++-
>  drivers/gpu/drm/meson/meson_venc.c | 3 +++
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 

[...]

Well it doesn't totally solve the issue....

Will resend a fixed version..

Neil

      reply	other threads:[~2018-11-22 10:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-21 17:15 Neil Armstrong
2018-11-22 10:15 ` Neil Armstrong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8cd32d4-6475-ae07-edf8-9f458279d0e0@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®