From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nick Xie <nick@khadas.com>
Cc: neil.armstrong@linaro.org, khilman@baylibre.com,
martin.blumenstingl@googlemail.com, jbrunet@baylibre.com,
krzk+dt@kernel.org, jic23@kernel.org, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, xieqinick@gmail.com
Subject: Re: [PATCH v1 1/4] dt-bindings: iio: adc: amlogic,meson-saradc: add S4 compatible
Date: Sat, 28 Feb 2026 12:20:35 +0100 [thread overview]
Message-ID: <fcca7245-9b0a-4c9c-a7e1-588322fac567@kernel.org> (raw)
In-Reply-To: <20260228-quirky-lemon-reindeer-1045f6@quoll>
On 28/02/2026 12:18, Krzysztof Kozlowski wrote:
> On Sat, Feb 28, 2026 at 02:58:37PM +0800, Nick Xie wrote:
>> Add the compatible string for the SARADC (Successive Approximation
>> Register ADC) IP block found in the Amlogic Meson S4 SoC.
>
> ... which is fully compatible with g12a?
>
> Write proper explanations.
>
>>
>> Signed-off-by: Nick Xie <nick@khadas.com>
>> ---
>> .../devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml
>> index bb9825e7346dd..5496a0dc714aa 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml
>> +++ b/Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml
>> @@ -27,6 +27,7 @@ properties:
>> - amlogic,meson-gxm-saradc
>> - amlogic,meson-axg-saradc
>> - amlogic,meson-g12a-saradc
>> + - amlogic,meson-s4-saradc
>
> If this is compatible with other device, you need proper fallback.
>
>> - const: amlogic,meson-saradc
>
> And this one is now kind of fake - how does this device use it?
I checked now - NOTHING uses it. This is completely useless fallback,
don't write such schema. Add a comment that usage of this fallback is
not allowed for new devices and instead create proper compatibility
(look at your driver code).
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-02-28 11:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 6:58 [PATCH v1 0/4] iio: adc: meson-saradc: add support for Meson S4 Nick Xie
2026-02-28 6:58 ` [PATCH v1 1/4] dt-bindings: iio: adc: amlogic,meson-saradc: add S4 compatible Nick Xie
2026-02-28 11:18 ` Krzysztof Kozlowski
2026-02-28 11:20 ` Krzysztof Kozlowski [this message]
2026-03-02 11:58 ` Martin Blumenstingl
2026-03-02 13:59 ` Krzysztof Kozlowski
2026-03-02 21:03 ` Martin Blumenstingl
2026-03-03 6:25 ` Krzysztof Kozlowski
2026-02-28 6:58 ` [PATCH v1 2/4] iio: adc: meson-saradc: add support for Meson S4 Nick Xie
2026-03-02 11:50 ` Martin Blumenstingl
2026-02-28 6:58 ` [PATCH v1 3/4] arm64: dts: amlogic: meson-s4: add internal SARADC controller Nick Xie
2026-03-02 11:50 ` Martin Blumenstingl
2026-02-28 6:58 ` [PATCH v1 4/4] arm64: dts: amlogic: meson-s4-s905y4-khadas-vim1s: add Function key support Nick Xie
2026-02-28 16:14 ` kernel test robot
2026-03-02 12:00 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcca7245-9b0a-4c9c-a7e1-588322fac567@kernel.org \
--to=krzk@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jbrunet@baylibre.com \
--cc=jic23@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=nick@khadas.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=xieqinick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome