From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD5A3606A333 for ; Thu, 12 Nov 2026 02:40:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=a7LMKhQJ; dkim=fail reason="signature verification failed" (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=KI/qRF06; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=JiyNngVp DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=I9e6G0Ped6HhDGVcu0//0UYvuRF1TDZD9paHryL+caA=; b=a7LMKhQJy620EsMaCNcktguzd0 q1zkiNcM/qoBIEvP2Ico8YqSWpPuY9fcdPiZHHWb6wUBAAKOTIhwYELOLlyswtH/i/Fflq24cMCh3 cdMlbq3C3pYNq259/l4q++hTgCaOGFenfPZP87VOgJmxEUjsHGiMyHIGDd6PIlrv/mFjUmGqf6GSH 6gsxmyDL+HGZXgPdDkjD3R0nLnBpnp60TaD/bVkjUoRCSWZLqGflidx4htMUnEFGWVrOdGffQRnng I3jnRuNzbfRb5iTccr61t2xpkUmjyCiCp07PfDbXcazeul7eNLUEiM/9og6IIhmk8e/XyXk7ydgwp ck73zvJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRKjg-00000008XtM-1fGA; Thu, 12 Nov 2026 02:40:24 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRKjd-00000008Xrw-3FAl for linux-amlogic@lists.infradead.org; Thu, 12 Nov 2026 02:40:22 +0000 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AC2aVoW1475381 for ; Thu, 12 Nov 2026 02:40:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iih96abnjxj/PozHFDBWYCK9JcXmwzDO9tgu+OyMggw=; b=KI/qRF060qDr0r2Y cJuOgXtsBpuDssWcFJlKOO1nnz751BpTeh9oz1oPGvjmslvWwhtLwO06nYw9Mz4r ecj4zy4uuMABNaIYsfdpdtFlcLHOb0GPfLodjZXjXNDK8Vf+XQwfP+fvVcSjA1fG 8h4TorsRex4rX7DoDD7Xb8uxUGXLLNcE7DByWRDzOUXxuwCBoKiBaRMH9GFL3BUA /SVMy9oqTiO0QrtV7oovqEHmjChkcnZA0sdNFtNSTh5HzTW33BNQPX4QbldT90Az F5ZYYFXjKa2Gozlp/vRRIx8hfdaKFek54kf3AKzEgLxcExHQcVbuPbqhhr1obTxj daAuAw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hvtymt9mx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Nov 2026 02:40:19 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-534f3fe0236so81270721cf.2 for ; Wed, 11 Nov 2026 18:40:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794451219; x=1795056019; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iih96abnjxj/PozHFDBWYCK9JcXmwzDO9tgu+OyMggw=; b=JiyNngVpyNY6NSzp/tmEW5EBraHtg72fHFEXQkdAx4zKs5LA5aChcKAAorA+xqskrS nCyGmuUpoInkQckky5su+E7JTZ6kYjjNXyTJlbfKZVkMmeD/SBLQ+oBvPX2VNeFzTBBH eFVsGHTIBZfGZgxwRBw48NZGu0JAoPtAGrJsaKeTrGWlBNwXJ/EAlztS+2BiQbDS5+sI 8FA4XYOW5bddRJVn7/YyZbjV38cdEwCcG9fLHLNj+K7V0YmlI8q9g61xn3D2IxYSXBmc KhUxNgSn2ZnGn64d/hNBKOttJ42q9MukbKA+x9CB8GlLec7cHHnACbyK3Lvtm99B/dXp +eow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794451219; x=1795056019; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iih96abnjxj/PozHFDBWYCK9JcXmwzDO9tgu+OyMggw=; b=anSMpWRtRuW+yJsSPspYRc9RtEDtu62CE5hD93X8YGAYzSODtHuIVhUoZhef+/5tki 1fYj87xhrGenr62UYC0itSn9PzajnGxjynBONUANqn54Ke7Gy3krHhPdpiIWxVk8T5o5 y27sq++92KhoXCg4Fr9dcHLsBwEQXKveejXs6Yixq/onMget8Gb6IDtHuL8Trxe6ziFE 3MHOMAbE/2vdR5sQp9dK8Q6uOX3PMgYcPZGLF/aDpv3cydG86pagCOQRBFMNyDhxtDq+ XcocTZo7TeOoArUPCQirlKscCm6TBLz0tJ4mcPtkRA0CvwxovltDFMVobJEXP8usHWpx UEmQ== X-Forwarded-Encrypted: i=1; AL+hErGQm6e6kdB3XFxPlWSnTAChe9y/oSa8kqR2P2uUkNAMRGofIhF1zo4xwV7v4qhxZhVIowUBKHz7Zyse4DUr@lists.infradead.org X-Gm-Message-State: APuU4Z/NphUKXzWiwpPj1oMWks/SugHf2phCIXObsrOcKnBKZ8KB8xdF ATlX6Qa2EzvrzSni3qjZx7gNrFIsFVd/G0lY1+bqceGnKqVGtAjQ8mD4+rL1KtvLPfujmAZPVJa zypxsdINxd/OEH/+Yr4FuFIWep3dks6PYdcAY+5VZfxVQ8tBf5rOKWmlNoz7hV7xl5Lx0xBJtqw == X-Gm-Gg: AYBFou1d/D/yTyL+S5IdnYtTt1J8csYMVzBNX/3HhznM/w6n6Ixb/pCkcSCiwh+yCN6 LaVL94PbbNn0e9afUC6792xG9cd4I1e7nfVLacXmrYX/BgmNQUYm/wqH/PhoyizHGBBTQPeBsOj bgIwen38js6nStiG7XgerT5GJi8CvNidhyjKTk6WWfl5BznA4ozdTzOfZgDXjAz285KO8XFI09A JzqkLqsayr2e/TxOpktWV2Gf6xJTB0feABN+rwVtHseeH0IzOfTGPPIP9lhJkNBHfzDkWfqtZ9H OiHCzmLnSOVOx9gu3Hcnu+O4bmJFyhI9RiucTWhA0ukyqIvcjL567+nXKl6zJ3a/vWixWhTgaK1 TkVHzatXYsRdVzNUQs4spOC1UHV+m+MPr+60zGBGY7/5DVADw/Bnd1qR5YV83nMCqZnWnYu7zOl jb0FXZhPh90kVeoIcqP8VGLB3OVv1UCJWFXaQgF4o= X-Received: by 2002:a05:622a:4e0a:b0:536:352d:65e9 with SMTP id d75a77b69052e-556c25188e0mr64866151cf.65.1794451219054; Wed, 11 Nov 2026 18:40:19 -0800 (PST) X-Received: by 2002:a05:622a:4e0a:b0:536:352d:65e9 with SMTP id d75a77b69052e-556c25188e0mr64861391cf.65.1794451209677; Wed, 11 Nov 2026 18:40:09 -0800 (PST) Received: from [10.111.167.254] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5550bd33340sm64426881cf.21.2026.11.11.18.39.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2026 18:40:09 -0800 (PST) Message-ID: Date: Thu, 12 Nov 2026 10:39:56 +0800 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 6/9] drm/msm/dp: don't take extra references on multiple plug events To: Dmitry Baryshkov , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Heikki Krogerus , Greg Kroah-Hartman , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Francesco Dolcini , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Tomi Valkeinen , Bjorn Andersson , Konrad Dybcio , Pengyu Luo , Chaoyi Chen Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org References: <20261024-hpd-irq-events-v8-0-6ee949e7a384@oss.qualcomm.com> <20261024-hpd-irq-events-v8-6-6ee949e7a384@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: <20261024-hpd-irq-events-v8-6-6ee949e7a384@oss.qualcomm.com> X-Proofpoint-GUID: rLi94ekrsBJ_XmT3aOQMq6aLbwyI82Yy X-Proofpoint-ORIG-GUID: rLi94ekrsBJ_XmT3aOQMq6aLbwyI82Yy X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTEyMDAxMCBTYWx0ZWRfX3ChbrkR70qVp /iPw83hJunhr75XzpD48TXQk44VJK0R5DBzBMXX18ELDD2N9g4HUHWF33bGx/s55P9bSqGO1yjj k34MQeEqd9B3sZanUcyadabsMoEe4p3sC1L6oN8F92QF6C2TLMn3l1+PJc1wvRheeGmGQ6ItfZU Ulhs7fCj6MYTmxgOdAFS/0ln3neJ+4weK6FiDgUehZMwrbVQKZBVSBitV1JylBwrp0rjiMzX+OU r2YcWom0o+lB+TRtAHBVFyMacKzrTDsXa82U4r4sWMdGOSJbU+VmfhNq92AJFcpx4LQarNEsUy4 ypPopyxk9iNmNPwgt3X1BxFfN9rasDNEtXymTpcCjiIhEDSoY6Lb51RpDv98Upt2x6CsNYpA/lA p3OzfYBg1SanCjpZ/pRz26VAPtNAFKfWE27H5Q9SoVkJfjVR1aDSX7Ysd2NFg7oXGOY3aQdMZfs 8ZP4b2kvHWmXB/pKWLA== X-Proofpoint-Spam-Info: AW1haW4tMjYxMTEyMDAxMCBTYWx0ZWRfX4RtxuWWpbDUu W8Iop/aZ7L4Zmye0V9iNFSPKq8nYJadoCcefonbeoVNj1QB0lkPq5PF0Cm1A2owmebMSDvvyx/F grJZAoekMaK+OpAoRWG705cci7Zv6mk= X-Authority-Analysis: v=2.4 cv=Q4BHcI2a c=1 sm=1 tr=0 ts=6af52713 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=UkfVDg3vQ6na--iosyQA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-12_01,2026-11-11_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 adultscore=0 suspectscore=0 clxscore=1011 bulkscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611120010 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261111_184021_930025_908C7B0B X-CRM114-Status: GOOD ( 20.52 ) X-Spam-Score: -2.8 (--) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 10/24/2026 8:35 AM, Dmitry Baryshkov wrote: > The upper layers might signal multiple sequential HPD plug events. Don't > take extra references and skip all further HPD plug events until we > receive the unplug event. > > Fixes: 3ea2d1c3d154 ("drm/msm/dp: turn link_ready into plugged") > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dp/dp_display.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index fa8942922b53..ce919a26fba2 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -412,6 +412,9 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display_private *dp) > > guard(mutex)(&dp->plugged_lock); > > + if (dp->plugged) > + return 0; > + > ret = pm_runtime_resume_and_get(&pdev->dev); > if (ret) { > DRM_ERROR("failed to pm_runtime_resume\n"); > Hi, the issue reported by the AI is real. There is a regression in the SST case: when .detect() runs first, it sets plugged to true. As a result, when msm_dp_hpd_plug_handle() is called, msm_dp_display_process_hpd_high() is skipped, which causes the subsequent failure. I tried removing the plugged update from .detect(), and that fixes the SST issue. The display works now. However, there is still an intermittent issue where the wrong resolution is selected. I suspect this is related to the timing of the EDID read: when fbcon comes up, the correct EDID may not be available immediately. _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic