From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 320CFC44506 for ; Sun, 12 Jul 2026 10:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8HblsPoEgxkzeCiEJ//SpmOy5FDWLfIxpKD+N4fp29w=; b=E0UmcTGx8lVNYX bVI+su/cQvHeEqBe4CxDVFElD8QNuHp3iMNK+93fsp4sb5oE85OC9FZvcOp39CO6Razq26QsuaiVO nvdr/VL00LUcG0dRKH+XOy+n9id8k89K/I/MEXoEpvHeTrVz79XAlcArdiW9feED/pXmRl/ERB+b5 oFnXbSPAD55ODnwkG5AqxQSyaQHvsgus0WeRNzKB3zHR5GoULaj3kLdez6Rbz/iXO4c1Mj4mrIyGF ZNcHK9l9XxwirgMl7o54CiH2mDdFW/sSuHnRji/h/xaIt/KpgtiSlNVrHjPmppzsbvm0HZT//Mmgy 8P+JTLCOlB5XeYlKgCgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wirgB-00000007NVI-2tJS; Sun, 12 Jul 2026 10:44:59 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wirg9-00000007NTz-1N4f for linux-amlogic@lists.infradead.org; Sun, 12 Jul 2026 10:44:58 +0000 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66CAcIaZ2130741 for ; Sun, 12 Jul 2026 10:44:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=Sb4ApefZutryRdB75QWmCb7+ x6M/kUCog+7gDuEDR90=; b=SHrCHjqs4df99NJG9bdHq119sHRuizAVPkyTBsbi mP51su7CI5aprYTPnlfhgyhKnr/zIt6o7Z01lHjNMV95wVeOyfWqIG7WJOeQqTFV w08ooD1SMRKwk0y3KWWKl/aO9UdzS/vjtU1NJwSCQzXEY7AD3Jf0GSyAyzKO1oZr nrEQxsMlq7BKi9Sm9pjThbaKr5hDuSSrARY8SZHy6EGueoQuiD6xmPVoJSIMUnPv keiJctLBV1zCeh2Yw/ZSgwgB6/cA1fyd8VoF8A7V60DZjcVl9z5UJ361uQsa4Oet jDuWGQnsv1DPTrXlstLtpV1WASkoIhBCtH1KGa673UFq+Q== Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fbf0gjhjs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 12 Jul 2026 10:44:56 +0000 (GMT) Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-5bdad49fe15so2561976e0c.0 for ; Sun, 12 Jul 2026 03:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783853096; x=1784457896; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Sb4ApefZutryRdB75QWmCb7+x6M/kUCog+7gDuEDR90=; b=Jm3SZiJW4M1reZ4gmz6bG+JwyF+AETaz66hdYbnGrXyLrdpfAVCS+ZvKwob0LzTFi4 5YVFP+Lgc1T4+EAd25WyF2HAKnB8+8odK9c/2w1NphxwHTi29160UYfEQ3jh13HfvWFb LDu/d/IGziyuj0k0T/jit5sz4+A10P2lcbzybqXZajChlU5IIEgo0Kvb+5UzVJMq0IHM WXvHw+xT8ry4xtp/v7OUp07SzpqnXjjwbiHt5xDiNCyhqISmVXreWUvRtADnOY4a07jS vWS3L18210Npo508WxnojeBJ7r4i5ae9A2QUw3jry3rFXaUwRoZAlAQL6/H37tx5kiA2 neww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783853096; x=1784457896; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Sb4ApefZutryRdB75QWmCb7+x6M/kUCog+7gDuEDR90=; b=j85bdlYByHUQj2EetI9OEQ/1sMrUDgv29WeNzpRVI7wSOaTGhwgDcj+u6fnSG1fh6M t2gNY3yzCVnPskRmPqabFfsZGgBobw4u+QmBudRqsXpjnxHb390Zq3t7nshHf9aUQ1KR 9U0Ag2Phxg7EOjGfB+bipLFMTD4/K/E5KnNaiFDDbNtdcQ0a7nZPMt5HRlnp8HfLAL3m YhBFCETDEKyvIq7C5I/i0RKGFRXuUyXERmmWpv5xy1DDh3DZEbSuvMibqKQbf0fGJRBk pKat6rE5ZjJQPd2z2a90hw70XQRHZ5vWStYNAd30nouLvv5qp7gbXI4cL/AG5YDf7jH7 Defg== X-Forwarded-Encrypted: i=1; AHgh+RrZN/z9cVh2KXbMh4BalKuOBTxTGT8OgWEO7r2E8So12JANuGV3blhmquTpNw+GKqyEiDcSNTxI8WPfqBmr@lists.infradead.org X-Gm-Message-State: AOJu0YwxJfMRng6n/urgHqPuD1k69sdaonsluHHXHF3p5DYxFbbPp+Yw /jIZJS+eCkbXR8xVPLGf+5bMurww/TydTzwqFE3mlGzvtQ6q0VwjpNTIGdxewXV4qA+rLY6J7Uy 8RtcclRH/iXWr+lSefZdBWFospmJDwi78VJeyfWwcQ+gKC4aDm3yQyCWtSiRWOENnN+dSV05q5A == X-Gm-Gg: AfdE7cnztkqDx75QW9SYISCkRSQGl9DkMRzCgCxGC26uW6F2ytn/44oChK2E9tgR+Wm IHs+34hWqgMmIjx5C8Ndti8NahULLN0acQImNHHo1F0ZCqFNiDPvdethlqzPFq6IjtggdxGoszW xtQD4W/WnDEfYitt1WlQ59qBypUygoYRGfAlkMZW7sd9KUgbafu3d/eYw7Am0g8bPCNlLR/woSp avWSfSEH0wX0bueooUe3At/7z5g4GHY7sN1OjxTgN3PbVszDllH7wYNsUL1pz/fFPd656mtK7d+ AgsvcqxrJR8L875msJhHvqVhN4aNN0adNoA6Ljt+BpPDKGiKOdEJQn+W8yHFdcJDdk8lLRLjMeC LMku+wVy/TsiDwghoQWebl8DMVYkZNjdUReCEg1lwd2dZQI8qSiX5kd50uD61ZMeRjk19Okfm14 JOKcQ0dDr89PUYI6k5/EmTXBoC X-Received: by 2002:a05:6122:d29:b0:5bf:bbe5:372 with SMTP id 71dfb90a1353d-5bfbf3b676dmr3706450e0c.12.1783853095632; Sun, 12 Jul 2026 03:44:55 -0700 (PDT) X-Received: by 2002:a05:6122:d29:b0:5bf:bbe5:372 with SMTP id 71dfb90a1353d-5bfbf3b676dmr3706406e0c.12.1783853095217; Sun, 12 Jul 2026 03:44:55 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39c84b854cesm19921011fa.27.2026.07.12.03.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 03:44:52 -0700 (PDT) Date: Sun, 12 Jul 2026 13:44:49 +0300 From: Dmitry Baryshkov To: Yongxing Mou Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Tomi Valkeinen , Bjorn Andersson , Konrad Dybcio , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH 3/5] drm/msm/dp: suppress bridge hotplug events during MST operation Message-ID: References: <20260629-msm-dp-msttypec-v1-0-646a10256233@oss.qualcomm.com> <20260629-msm-dp-msttypec-v1-3-646a10256233@oss.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260629-msm-dp-msttypec-v1-3-646a10256233@oss.qualcomm.com> X-Authority-Analysis: v=2.4 cv=Nq3htcdJ c=1 sm=1 tr=0 ts=6a537028 cx=c_pps a=+D9SDfe9YZWTjADjLiQY5g==:117 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=dRlQVyWoEjKAXtvccWIA:9 a=CjuIK1q_8ugA:10 a=vmgOmaN-Xu0dpDh8OwbV:22 X-Proofpoint-ORIG-GUID: vJcgJZn-CMxIQNrgr4eQIQnzicVkeaM9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEyMDExMiBTYWx0ZWRfX7/m238eKCjYu 0AXmuDooj0/uNU1ZDXD9LmAVhbEj3V/K4kwNntsz9g5EdZbx/CYmOP00eJSWbnSqwYaUNLqKNP7 pWRzPby1L48y4iuRIXJoshlfMkry21y2fJFtPtiaVdz0tQ6WVnHX1J/gt5emucEgItSwmzm0fjN UEsSiGXpfiq2RYVHH2zhP8FmdJj+sNGwxDWRSO2KDJ1DZNNHn9H4FFh6ac5BOAFWs5dLwt9yPJP meLWuNyjsoVK3Z1iEb5fjj6OIkcWppQ5ZUN9kVuoNjg99E0ebYAT5jxxZHOSuvRvsE48gKhJYL4 5b+p4Mb1DDwWCjHxxXDNllJnkHf1YPyL1zIDPM5nVUaE5G6gDD1NZZaw16JA1K0GH+GnWvneGIw unTk52/fzoPF2pxlEJH1r6UUPAE5F+Jx0ZGPN7jBiJgNVL46gcsfxhmJsxEo1FGqgUhb6Ii6Krh th5JCc0KoR4FgsE6cWA== X-Proofpoint-GUID: vJcgJZn-CMxIQNrgr4eQIQnzicVkeaM9 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEyMDExMiBTYWx0ZWRfX+RPhsRgJ+fBm 1cgrBxGwdGpOAYh8wC9TUsNZkC+jD9H3b9qi5mKKU99h5nwWrPEfuLEtpD3CqcXXdjL4BTRmeDw CO94BdFBftEozaHYA6uI8pjs6Pt2CXQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-12_04,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607120112 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260712_034457_386380_6AECD98F X-CRM114-Status: GOOD ( 26.34 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2026 at 10:48:05PM +0800, Yongxing Mou wrote: > The DP MST framework already generates the required hotplug events for > MST topology changes. > > Suppress connector hotplug event generation from the bridge connector > path while MST is active, and continue propagating HPD notifications to > the DP driver. > > Signed-off-by: Yongxing Mou > --- > drivers/gpu/drm/display/drm_bridge_connector.c | 6 ++++-- > drivers/gpu/drm/msm/dp/dp_display.c | 9 ++++++++- No, it can't go as this. The drm_bridge_connector part should have been a part of the first patch. > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/display/drm_bridge_connector.c b/drivers/gpu/drm/display/drm_bridge_connector.c > index 7334d6677604..82ed0dc450ab 100644 > --- a/drivers/gpu/drm/display/drm_bridge_connector.c > +++ b/drivers/gpu/drm/display/drm_bridge_connector.c > @@ -162,6 +162,7 @@ static void drm_bridge_connector_handle_hpd(struct drm_bridge_connector *drm_bri > { > struct drm_connector *connector = &drm_bridge_connector->base; > struct drm_device *dev = connector->dev; > + bool send_hotplug = true; > > /* > * IRQ-only notification: extra_status carries the event but > @@ -179,9 +180,10 @@ static void drm_bridge_connector_handle_hpd(struct drm_bridge_connector *drm_bri > connector->status = status; > mutex_unlock(&dev->mode_config.mutex); > > - drm_bridge_connector_hpd_notify(connector, status, extra_status, NULL); > + drm_bridge_connector_hpd_notify(connector, status, extra_status, &send_hotplug); > > - drm_kms_helper_connector_hotplug_event(connector); > + if (send_hotplug) > + drm_kms_helper_connector_hotplug_event(connector); But now I can also see that the idea seems to be incorrect. You are preventing the kernel from sending the events, but it doesn't really matter. If connection status oscillates, then other components might notice it even without the event being sent. > } > > static void drm_bridge_connector_hpd_cb(void *cb_data, > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 6835c68fe510..bc93b566fbca 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1790,10 +1790,17 @@ void msm_dp_bridge_hpd_notify(struct drm_bridge *bridge, > msm_dp_hpd_plug_handle(dp); > } else { > msm_dp_hpd_plug_handle(dp); > + /* mst_active is set in plug_handle; suppress SST hotplug */ > + if (send_hotplug && msm_dp_display->mst_active) > + *send_hotplug = false; > } > } else { > - if (hpd_link_status == ISR_DISCONNECTED) > + if (!msm_dp_display->mst_active) { > msm_dp_hpd_unplug_handle(dp); > + } else if (send_hotplug) { > + msm_dp_hpd_unplug_handle(dp); > + *send_hotplug = false; Why? Disconnected events definitely should be reported further. > + } > } > > pm_runtime_put_sync(&msm_dp_display->pdev->dev); > > -- > 2.43.0 > -- With best wishes Dmitry _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic