From: sashiko-bot@kernel.org
To: "Igor Velkov" <iav@iav.lv>
Cc: neil.armstrong@linaro.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] irqchip/meson-gpio: Allow the GPIO interrupts to wake the system
Date: Wed, 07 Oct 2026 22:04:29 +0000 [thread overview]
Message-ID: <sashiko-outbox-163402@kernel.org> (raw)
In-Reply-To: <20261008-meson-gpio-wake-v1-1-fec8a1f5d830@iav.lv>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] irqchip: meson-gpio: spurious wakeups due to missing IRQCHIP_MASK_ON_SUSPEND
--
commit 39ce695188f00617d3597fd256c103a4df7428f7
Author: Igor Velkov <iav@iav.lv>
irqchip/meson-gpio: Allow the GPIO interrupts to wake the system
This commit adds the IRQCHIP_SKIP_SET_WAKE flag to the meson_gpio_irq_chip
definition. This prevents enable_irq_wake() from failing and allows GPIO
interrupts routed through this controller to wake the system from suspend.
> diff --git a/drivers/irqchip/irq-meson-gpio.c b/drivers/irqchip/irq-meson-gpio.c
> index 91a9c337fe6d9..e0329ef5e4a21 100644
> --- a/drivers/irqchip/irq-meson-gpio.c
> +++ b/drivers/irqchip/irq-meson-gpio.c
> @@ -538,7 +538,7 @@ static struct irq_chip meson_gpio_irq_chip = {
> #ifdef CONFIG_SMP
> .irq_set_affinity = irq_chip_set_affinity_parent,
> #endif
> - .flags = IRQCHIP_SET_TYPE_MASKED,
> + .flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_SKIP_SET_WAKE,
[Severity: Medium]
Will this cause spurious wakeups from non-wakeup GPIO interrupts during
system suspend?
During suspend, suspend_device_irqs() lazily disables non-wakeup interrupts
by setting IRQD_IRQ_DISABLED, but without calling .irq_mask() because the
parent GIC lacks an .irq_disable() callback. The core IRQ power management
code only physically masks the interrupt if the top-level irq_chip provides
the IRQCHIP_MASK_ON_SUSPEND flag.
Since meson_gpio_irq_chip does not set IRQCHIP_MASK_ON_SUSPEND, non-wakeup
GPIO interrupts might remain unmasked at the GIC level. If a non-wakeup
interrupt triggers while the system is asleep, the GIC will forward it to
the CPU, potentially leading to an unintended wakeup and power drain.
Does this flag definition need to include IRQCHIP_MASK_ON_SUSPEND as well?
> };
>
> static int meson_gpio_irq_domain_translate(struct irq_domain *domain,
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261008-meson-gpio-wake-v1-1-fec8a1f5d830@iav.lv?part=1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-10-07 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 21:55 Igor Velkov via B4 Relay
2026-10-07 22:04 ` sashiko-bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-10-07 21:55 Igor Velkov via B4 Relay
2026-10-07 22:05 ` sashiko-bot
2026-10-08 8:36 ` Neil Armstrong
2026-10-08 14:19 ` Igor Velkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-163402@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=iav@iav.lv \
--cc=linux-amlogic@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®