Re: [PATCH] ASoC: meson: axg-fifo: return a negative error code when no irq is found

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] soc: meson: dev_err() causes log spam on EPROBE_DEFER in axg_fifo_probe()
--

commit 267006c95b3ed8ed3ac0f11cabf3a8125d79bc3b
Author: Haotian Zhang <vulab@iscas.ac.cn>

ASoC: meson: axg-fifo: return a negative error code when no irq is found

This commit updates axg_fifo_probe() to return -EINVAL when of_irq_get()
returns 0. Previously, it returned 0 which caused the probe to succeed
erroneously, leading to failures later during request_threaded_irq().

> diff --git a/sound/soc/meson/axg-fifo.c b/sound/soc/meson/axg-fifo.c
> index 75909196b7698..fdbee44f5101c 100644
> --- a/sound/soc/meson/axg-fifo.c
> +++ b/sound/soc/meson/axg-fifo.c
> @@ -365,7 +365,7 @@ int axg_fifo_probe(struct platform_device *pdev)
>  	fifo->irq = of_irq_get(dev->of_node, 0);
>  	if (fifo->irq <= 0) {
>  		dev_err(dev, "failed to get irq: %d\n", fifo->irq);

[Severity: Low]
Does this unconditionally log an error even when of_irq_get() returns
-EPROBE_DEFER?

If of_irq_get() returns -EPROBE_DEFER (-517) because the IRQ controller is
not yet available during boot, the condition fifo->irq <= 0 is true and
dev_err() will generate log spam.

Since this error handling block is being updated, could this be changed to
use dev_err_probe() instead? This would correctly suppress deferral log
messages, as is done for other resources in axg_fifo_probe().

> -		return fifo->irq;
> +		return fifo->irq ?: -EINVAL;
>  	}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009051724.3134644-1-vulab@iscas.ac.cn?part=1

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic