Re: [PATCH v6 4/9] drm/bridge: pass extra events to the HPD callback

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/bridge: misplaced hdmi5_bridge_hpd_notify() hunk breaks bisectability
--

commit c6cd0e6e9f3efd88f40aba30dc7463e072351c53
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

drm/bridge: pass extra events to the HPD callback

This commit adds drm_bridge_hpd_notify_extra() and updates the HPD callback
signature registered via drm_bridge_hpd_enable() to pass extra sink events
such as DisplayPort IRQ_HPD to underlying drivers.

[ ... ]

> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c b/drivers/gpu/drm/omapdrm/dss/hdmi5.c
> index c542ba6ce7d32..a21f9355594cc 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi5.c
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5.c
> @@ -427,7 +427,8 @@ static void hdmi5_bridge_disable(struct drm_bridge *bridge,
>  
>  static void hdmi5_bridge_hpd_notify(struct drm_bridge *bridge,
>  				    struct drm_connector *connector,
> -				    enum drm_connector_status status)
> +				    enum drm_connector_status status,
> +				    enum drm_connector_dp_event event)
>  {
>  	struct omap_hdmi *hdmi = drm_bridge_to_hdmi(bridge);
>  

[Severity: Low]
In drivers/gpu/drm/omapdrm/dss/hdmi5.c, hdmi5_bridge_hpd_notify() is assigned
to struct drm_bridge_funcs.hpd_notify rather than registered via
drm_bridge_hpd_enable():

static const struct drm_bridge_funcs hdmi5_bridge_funcs = {
	...
	.hpd_notify = hdmi5_bridge_hpd_notify,
	.edid_read = hdmi5_bridge_edid_read,
};

The hpd_notify callback signature in struct drm_bridge_funcs (in
include/drm/drm_bridge.h) and the other in-tree implementations (including
hdmi4_bridge_hpd_notify() in drivers/gpu/drm/omapdrm/dss/hdmi4.c) were
updated in parent commit 9cf55ff0f96b ("drm/bridge: pass down IRQ_HPD to the
drivers").

Because the hdmi5_bridge_hpd_notify() update landed in this patch instead,
building the kernel at commit 9cf55ff0f96b with CONFIG_DRM_OMAP and
CONFIG_OMAP5_DSS_HDMI enabled fails with an incompatible function pointer type
error when initializing hdmi5_bridge_funcs.hpd_notify.

Should this hunk be moved into commit 9cf55ff0f96b ("drm/bridge: pass down
IRQ_HPD to the drivers") to preserve bisectability?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261022-hpd-irq-events-v6-0-337ea3ddaa62@oss.qualcomm.com?part=4

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic