Re: [PATCH v7 3/9] drm/bridge: pass down IRQ_HPD to the drivers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/omap: missing event arg in hdmi5_bridge_hpd_notify() breaks build
--

commit 8fdca4f38003a51e3d398ac403cb300b423a0ffc
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

drm/bridge: pass down IRQ_HPD to the drivers

This commit adds the enum drm_connector_dp_event parameter to the
drm_bridge_funcs.hpd_notify callback so that DisplayPort IRQ_HPD events can
be passed down to bridge drivers.

[ ... ]

> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdrm/dss/hdmi4.c
> index bd6c4d2dcdc86..72972a6fe989b 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c
> @@ -429,7 +429,8 @@ static void hdmi4_bridge_disable(struct drm_bridge *bridge,
>  
>  static void hdmi4_bridge_hpd_notify(struct drm_bridge *bridge,
>  				    struct drm_connector *connector,
> -				    enum drm_connector_status status)
> +				    enum drm_connector_status status,
> +				    enum drm_connector_dp_event event)
>  {
>  	struct omap_hdmi *hdmi = drm_bridge_to_hdmi(bridge);
>  
> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index 1981d24a700d2..6382ef5f1ea28 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -509,7 +509,8 @@ struct drm_bridge_funcs {
>  	 */
>  	void (*hpd_notify)(struct drm_bridge *bridge,
>  			   struct drm_connector *connector,
> -			   enum drm_connector_status status);
> +			   enum drm_connector_status status,
> +			   enum drm_connector_dp_event event);

[Severity: Low]
Does this break compilation when CONFIG_OMAP5_DSS_HDMI is enabled?

While hdmi4_bridge_hpd_notify() in drivers/gpu/drm/omapdrm/dss/hdmi4.c is
updated here, hdmi5_bridge_hpd_notify() in drivers/gpu/drm/omapdrm/dss/hdmi5.c
still retains the old 3-argument signature:

drivers/gpu/drm/omapdrm/dss/hdmi5.c:
static void hdmi5_bridge_hpd_notify(struct drm_bridge *bridge,
				    struct drm_connector *connector,
				    enum drm_connector_status status)
{
	struct omap_hdmi *hdmi = drm_bridge_to_hdmi(bridge);

	hdmi_audio_hpd_notify(hdmi, status);
}
...
static const struct drm_bridge_funcs hdmi5_bridge_funcs = {
	...
	.hpd_notify = hdmi5_bridge_hpd_notify,
	.edid_read = hdmi5_bridge_edid_read,
};

Assigning hdmi5_bridge_hpd_notify to hdmi5_bridge_funcs.hpd_notify causes an
incompatible pointer type error during compilation when CONFIG_OMAP5_DSS_HDMI
is enabled, and also results in a function signature mismatch when
drm_bridge_connector_hpd_notify() invokes bridge->funcs->hpd_notify().

It looks like the hunk updating hdmi5_bridge_hpd_notify() ended up in the
subsequent commit c49a65530348 ("drm/bridge: pass extra events to the HPD
callback"). Should that change be moved into this commit so that the tree
remains bisectable?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261023-hpd-irq-events-v7-0-57a3aea3f09e@oss.qualcomm.com?part=3

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic