From: sashiko-bot@kernel.org
To: christian.koever-draxl@student.uibk.ac.at
Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org
Subject: Re: [PATCH v2 2/3] thermal/drivers/amlogic: add S4 support
Date: Fri, 06 Nov 2026 10:30:35 +0000 [thread overview]
Message-ID: <sashiko-outbox-201220@kernel.org> (raw)
In-Reply-To: <20261106101913.46664-3-christian.koever-draxl@student.uibk.ac.at>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] thermal: amlogic: redundant amlogic,s4-thermal match entry
--
commit d73de7ad59dbf743cca9b086493290c2c74eb121
Author: Christian Stefan Kövér-Draxl <ckoever@outlook.de>
thermal/drivers/amlogic: add S4 support
This commit adds a match table entry for "amlogic,s4-thermal" to
of_amlogic_thermal_match[], using the existing amlogic_thermal_t7_param
configuration.
> diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c
> index 60728de6968ac..4c107b3100c0d 100644
> --- a/drivers/thermal/amlogic_thermal.c
> +++ b/drivers/thermal/amlogic_thermal.c
> @@ -292,6 +292,10 @@ static const struct of_device_id of_amlogic_thermal_match[] = {
> .compatible = "amlogic,a1-cpu-thermal",
> .data = &amlogic_thermal_a1_cpu_param,
> },
> + {
> + .compatible = "amlogic,s4-thermal",
> + .data = &amlogic_thermal_t7_param,
> + },
> {
> .compatible = "amlogic,t7-thermal",
> .data = &amlogic_thermal_t7_param,
[Severity: Low]
As reported by Krzysztof Kozlowski on v1 [1], is a separate
"amlogic,s4-thermal" entry in of_amlogic_thermal_match[] needed when it uses
the exact same amlogic_thermal_t7_param data and binding constraints as
"amlogic,t7-thermal"? Pairing "amlogic,s4-thermal" with "amlogic,t7-thermal"
as a fallback compatible in the Devicetree binding would make this driver
change unnecessary.
[1] https://lore.kernel.org/r/20261030-funny-ibex-of-modernism-b995fe@quoll
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261106101913.46664-1-christian.koever-draxl@student.uibk.ac.at?part=2
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-11-06 10:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 10:19 [PATCH v2 0/3] " christian.koever-draxl
2026-11-06 10:19 ` [PATCH v2 1/3] dt-bindings: thermal: amlogic: add S4 christian.koever-draxl
2026-11-06 17:20 ` Conor Dooley
2026-11-06 10:19 ` [PATCH v2 2/3] thermal/drivers/amlogic: add S4 support christian.koever-draxl
2026-11-06 10:30 ` sashiko-bot [this message]
2026-11-06 10:19 ` [PATCH v2 3/3] thermal/drivers/amlogic: do not log the secure monitor deferral as an error christian.koever-draxl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-201220@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=christian.koever-draxl@student.uibk.ac.at \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®