From: sashiko-bot@kernel.org
To: "Jude Gyimah" <jude.gyimah87@gmail.com>
Cc: linux-sound@vger.kernel.org, linux-amlogic@lists.infradead.org,
neil.armstrong@linaro.org
Subject: Re: [PATCH 2/4] ASoC: meson: axg-pdm: select REGMAP_MMIO
Date: Sat, 07 Nov 2026 17:02:03 +0000 [thread overview]
Message-ID: <sashiko-outbox-203084@kernel.org> (raw)
In-Reply-To: <20261107165527.576383-3-jude.gyimah87@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: meson: axg-pdm: commit message refers to three stanzas but
only updates one
--
commit 1aa97aa37f974c96150326ff4ae32f1b755fbad0
Author: Jude Gyimah <jude.gyimah87@gmail.com>
ASoC: meson: axg-pdm: select REGMAP_MMIO
This commit adds a select REGMAP_MMIO statement to the SND_MESON_AXG_PDM
Kconfig entry to prevent link failures when SND_MESON_AXG_PDM is built-in
and REGMAP_MMIO is built as a module.
> Several stanzas in the same file already select REGMAP_MMIO,
> SND_MESON_G12A_TOACODEC among them. These three do not.
[Severity: Low]
What does "These three" refer to here? Nothing earlier in the commit
message names three stanzas, and this patch only updates SND_MESON_AXG_PDM
while the other stanzas are updated in separate commits.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261107165527.576383-1-jude.gyimah87@gmail.com?part=2
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-11-07 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 16:55 [PATCH 0/4] ASoC: meson: fix missing REGMAP_MMIO dependencies Jude Gyimah
2026-11-07 16:55 ` [PATCH 1/4] ASoC: meson: aiu: select REGMAP_MMIO Jude Gyimah
2026-11-07 16:55 ` [PATCH 2/4] ASoC: meson: axg-pdm: " Jude Gyimah
2026-11-07 17:02 ` sashiko-bot [this message]
2026-11-07 17:43 ` Jude Gyimah
2026-11-07 16:55 ` [PATCH 3/4] ASoC: meson: axg-spdifin: " Jude Gyimah
2026-11-07 16:55 ` [PATCH 4/4] ASoC: meson: axg-spdifout: " Jude Gyimah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-203084@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=jude.gyimah87@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®