From: "Robbert Kouprie" <robbert@radium.jvb.tudelft.nl>
To: "'Alan Cox'" <alan@lxorguk.ukuu.org.uk>
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: eepro100.c bug on 10Mbit half duplex (kernels 2.4.5 / 2.4.10 / 2.4.11pre6 / 2.4.11 / 2.4.10ac11)
Date: Thu, 11 Oct 2001 23:02:53 +0200 [thread overview]
Message-ID: <000001c15298$17f03790$020da8c0@nitemare> (raw)
In-Reply-To: <E15rlb9-0004QK-00@the-village.bc.nu>
Alan,
Your fix seems to have eliminated the problem. I found this strange, as
the device ids still did not match mine. So I added a PRINTK line in the
test, and found that _with_ your fix it DOES NOT get triggered. The ac
kernel WITH the bug however DOES trigger the test.
So, as I have tested both your and Linus' driver (in which the whole
"if" was missing), one has to conclude that both the bug in de ac driver
AND the whole missing line in Linus' kernel made the test succeed, where
is actually SHOULD NOT succeed. So actually my NIC is perfectly ok, but
not in combination with a workaround for a bug it doesn't have ;) This
was what broke things.
So, the 10Mbit half-duplex workaround breaks stuff on the devices that
do not suffer from the bug. This is dangerous... ;)
Anyway, I'm upgraded to 100Mbit now, and the bug is fixed, so I'm happy
:)
Thanx for your help.
Regards,
- Robbert
> -----Original Message-----
> From: Alan Cox [mailto:alan@lxorguk.ukuu.org.uk]
> Sent: donderdag 11 oktober 2001 21:34
> To: Robbert Kouprie
> Cc: 'Alan Cox'; linux-kernel@vger.kernel.org
> Subject: Re: eepro100.c bug on 10Mbit half duplex (kernels
> 2.4.5 / 2.4.10 / 2.4.11pre6 / 2.4.11 / 2.4.10ac11)
>
>
> > if ((pdev->device=0x2449) || ( (pdev->device > 0x1030) &&
> ^^^^^^^
>
> Well thats a bug (just fixed)
>
> > My device's id is: 8086:1229 - Intel, 82557 [Ethernet Pro 100]
> > The present ids are: 8086:1030 - 82559 InBusiness 10/100
> > 8086:1031-1039 - are not listed in my db
> > 8086:2449 - 82820 820 (Camino 2) Chipset
> > Ethernet
> >
> > For one thing, in Linus' 2.4.12 the if condition at line 802 isn't
> > present at all, so that sure isn't gonna work.
>
> Try enabling the test regardless and seeing if it helps on your box
>
>
next prev parent reply other threads:[~2001-10-11 21:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-11 12:29 Robbert Kouprie
2001-10-11 16:27 ` John Gluck
2001-10-11 16:52 ` Robbert Kouprie
2001-10-11 17:15 ` Alan Cox
2001-10-11 17:29 ` Robbert Kouprie
2001-10-11 19:19 ` Robbert Kouprie
2001-10-11 19:34 ` Alan Cox
2001-10-11 21:02 ` Robbert Kouprie [this message]
2001-10-11 17:42 ` Matthew S. Hallacy
2001-10-11 20:08 ` Ion Badulescu
2001-10-11 20:16 ` Dan Hollis
2001-10-12 8:41 Robbert Kouprie
2001-10-12 13:40 ` Ion Badulescu
2001-10-13 18:16 ` Robbert Kouprie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001c15298$17f03790$020da8c0@nitemare' \
--to=robbert@radium.jvb.tudelft.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®